Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-06-30 Thread Neel Patel
Hi Dave, On Thu, Jun 30, 2016 at 7:31 PM, Dave Page wrote: > Hi > > On Thu, Jun 30, 2016 at 10:42 AM, Neel Patel > wrote: > > Hi, > > > > Please find attached patch file for initial version of download file in > > runtime application. > > I've attached an update with some improved messages, and

[pgadmin-hackers] pgAdmin 4 commit: Beta 2.1 - a favour for our friends in QA.

2016-06-30 Thread Dave Page
Beta 2.1 - a favour for our friends in QA. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c45960df5e5a004f682eed16da02c0d41887a670 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Require passwords to be at least 6 chars long in setu

2016-06-30 Thread Dave Page
Require passwords to be at least 6 chars long in setup.py. Fixes #1322 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d79524ff60a4645af798ce1e926210320de26a99 Modified Files -- web/setup.py | 7 +-- 1 file changed, 5 insertions(

[pgadmin-hackers] pgAdmin 4 commit: Fix subnode header colour

2016-06-30 Thread Dave Page
Fix subnode header colour Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1d8ca8c1c2f6ff7f35b9f665824fa763df6621c Modified Files -- web/pgadmin/static/css/overrides.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sen

[pgadmin-hackers] pgAdmin 4 commit: Correct label

2016-06-30 Thread Dave Page
Correct label Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=685b2f4ab7fbc9cad00de81aaa55a7ee692d35d6 Modified Files -- .../server_groups/servers/databases/schemas/functions/__init__.py | 2 +- 1 file changed, 1 insertion(+),

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Dave Page
Hi On Thu, Jun 30, 2016 at 11:37 AM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. > Tested with json/json[]/jsonb/jsonb[] (on browsers & runtime). I can't add rows to a table with this patch applied: 1) Create a table create table test(id serial primary key, j json, jb jsonb, ja

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. Tested with json/json[]/jsonb/jsonb[] (on browsers & runtime). Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:26 PM, Dave Page wrote: > Thanks - and the json datat

[pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-06-30 Thread Neel Patel
Hi, Please find attached patch file for initial version of download file in runtime application. With this patch, we have implemented two features. *Feature 1 :- Normal "Download file" from runtime application* Previously "Download file" was not implemented in runtime application. With this pat

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-30 Thread Dave Page
Hi Harshal, On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal wrote: > Hi Dave, > > Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are > Shift+Command+E, Shift+Command+X, Shift+Command+A OK, those work, but I think we need to take a step back here (partly because Cmd+Shif

[pgadmin-hackers] pgAdmin 4 commit: Fix query execution keys in the Mac runtime. Needs mo

2016-06-30 Thread Dave Page
Fix query execution keys in the Mac runtime. Needs more work to sanitize with CodeMirror, but this is a step further. Fixes #1336 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa44122a8affb945e897b10b79799b73c335c954 Modified Files -

[pgadmin-hackers] pgAdmin 4 commit: Fix regression test harness to allow for removal of t

2016-06-30 Thread Dave Page
Fix regression test harness to allow for removal of the schema version from config.py Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80e108aa55eefe976b324f9a3f62de569d3fe0d3 Modified Files -- web/regression/testsuite.py | 6 ++

[pgadmin-hackers] pgAdmin 4 commit: Fix email validation

2016-06-30 Thread Dave Page
Fix email validation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71443decebed98fec067ac7a0cdedbd54198bad5 Modified Files -- web/setup.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- Sent via pgadmin-hackers maili

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Dave Page
Thanks - and the json datatype? On Thu, Jun 30, 2016 at 8:56 AM, Murtuza Zabuawala wrote: > Hi Dave, > > text type works fine even if it has json data. > > Regards, > Murtuza > >> On 30-Jun-2016, at 1:21 pm, Dave Page wrote: >> >> On Thu, Jun 30, 2016 at 8:11 AM, Murtuza Zabuawala >> wrote: >>>

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi Dave, text type works fine even if it has json data. Regards, Murtuza > On 30-Jun-2016, at 1:21 pm, Dave Page wrote: > > On Thu, Jun 30, 2016 at 8:11 AM, Murtuza Zabuawala > wrote: >> Hi, >> >> PFA updated patch, we have created backgrid jsonb type cell which will work >> within browser

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Dave Page
On Thu, Jun 30, 2016 at 8:11 AM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch, we have created backgrid jsonb type cell which will work > within browser & runtime. Does it resolve the issue for 'json' columns? What about a 'text' column containing json data? -- Dave Page Blog: http://pg

[pgadmin-hackers] Curious record sorting in pgadmin4

2016-06-30 Thread Colin Beckingham
On openSUSE Leap 42.1 using very latest pgadmin4 version using git pull, when I open a database, select a table and use the default view data all records I observe a very curious effect. With SQL such as select * order by ID ascending, when the output is paged across more than one set of 50 rec

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi, PFA updated patch, we have created backgrid jsonb type cell which will work within browser & runtime. Regards, Murtuza On 29-Jun-2016, at 3:54 pm, Dave Page wrote: Hi On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala wrote: Hi, PFA patch to fix the issue of jsonb type rendering issue

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-30 Thread Harshal Dhumal
Hi Dave, Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are Shift+Command+E, Shift+Command+X, Shift+Command+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:05 AM, Dav