Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi wr

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi Harshal, Can you please explain - what was missing in the last patch? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jul 7, 2016 at

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA updated patch for issue RM1260 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > Please ignore this patch as this h

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, Please ignore this patch as this has some minor issue. I'll sent updated one. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

[pgadmin-hackers] [Patch] Fix Unicode in errmsg

Hi All, Just a small patch to fix server addition/connection errors when using non-ascii languages (pt_BR in my case). I haven't delved enough into the codebase to be sure, but there might be more occurrences of errmsg that need decoding from ASCII to UTF-8. Is there any plans to port PgAdmi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > Hi, > > I think we need more changes than just that; > > - The path at the top should not be editable (it should be greyed in fact) > Ok > > - The path at the top should only show the directory path. The > filename should never be appended. > Ok

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Hi, I think we need more changes than just that; - The path at the top should not be editable (it should be greyed in fact) - The path at the top should only show the directory path. The filename should never be appended. - The CSS needs to be fixed so the filename textbox at the bottom is neve

[pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA patch for issue RM1260. Changes: Issue wasn't related to foreign table but was due the Select2 control. Now I have improved select2 control to handle null value in multi-select mode. Initial it was returning "null" instead it should return [] (empty array). -- *Harshal Dhumal* *Softwar

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Hi Please find the patch with issue fixed: File Browser - File does not exist error > it is due to wrong path formation. strip the leftmost slash only from the > file name selected not from the full path. Please review. *Reply to the comments:* The file browser is virtually unreadable (see scr

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end

Hi Please find attached patch with fix. Every time either a new row is added or pasted. Scroll to the bottom of the table div. Please review Thanks, Surinder Kumar RM#1435.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

Hi Dave, I have tried to fix most of the review comments. I have modified the patch on top of your changes. Please find attached updated patch file. Find my comments inline. Can you please review and let us know your feedback ? Thanks, Neel Patel On Fri, Jul 1, 2016 at 2:39 PM, Dave Page wrote