Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-26 Thread Dave Page
On Tue, Jul 26, 2016 at 3:06 PM, Dave Page wrote: > Hi > > On Tue, Jul 26, 2016 at 2:34 PM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> PFA updated patch to fix encoding issue, I have tested in Python2/3 and >> looks like working in both environment. >> >> Almost all nodes are affected with this

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-26 Thread Dave Page
Hi On Tue, Jul 26, 2016 at 2:34 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch to fix encoding issue, I have tested in Python2/3 and > looks like working in both environment. > > Almost all nodes are affected with this change, I tried to test & cover all > basic operations on nodes

[pgadmin-hackers] pgAdmin 4 commit: Fix numerous encoding issues. Fixes #1307. Fixes #147

2016-07-26 Thread Dave Page
Fix numerous encoding issues. Fixes #1307. Fixes #1479 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06e881570a2861cd2b679ec3cc637eab2577d941 Author: Murtuza Zabuawala Modified Files -- requirements_py2.txt

Re: [pgadmin-hackers] Fix for RM1154: Show proper error message for already delete object [pgadmin4]

2016-07-26 Thread Dave Page
Thanks, patch applied. On Tue, Jul 26, 2016 at 2:05 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for rm1154. > > > Issue fixed: Show proper error message if try to delete already deleted > object. > > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com >

[pgadmin-hackers] pgAdmin 4 commit: Give a more useful error message if attempting to dro

2016-07-26 Thread Dave Page
Give a more useful error message if attempting to drop an object that doesn't exist. Fixes #1154 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=166d42953ced62f527f8d1e512fd519026ac895c Author: Harshal Dhumal Modified Files -- ...

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-26 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix encoding issue, I have tested in Python2/3 and looks like working in both environment. Almost all nodes are affected with this change, I tried to test & cover all basic operations on nodes but still it requires some testing. This patch will cover below tickets,

[pgadmin-hackers] Fix for RM1154: Show proper error message for already delete object [pgadmin4]

2016-07-26 Thread Harshal Dhumal
Hi, PFA patch for rm1154. Issue fixed: Show proper error message if try to delete already deleted object. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases

Re: [pgadmin-hackers] PATCH: To disable SQLALCHEMY to tracking (pgAdmin4)

2016-07-26 Thread Dave Page
Thanks, applied. On Tue, Jul 26, 2016 at 11:49 AM, Murtuza Zabuawala wrote: > Hi All, > > PFA patch which will disable SQLALCHEMY track modification feature as it put > overhead on system. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise Postgre

[pgadmin-hackers] pgAdmin 4 commit: Disable SQLALCHEMY track modification feature as it p

2016-07-26 Thread Dave Page
Disable SQLALCHEMY track modification feature as it puts overhead on system, and if not set, now emits a warning. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3d96d5c053ad8cd7b636806b3ade72df3fa1e8a Author: Murtuza Zabuawala Modified File

Re: [pgadmin-hackers] Used font awesome icon instead of 'Add' caption for Add button

2016-07-26 Thread Dave Page
Thanks - applied. On Tue, Jul 26, 2016 at 9:56 AM, Akshay Joshi wrote: > Hi > > Forgot to add css changes. Attached is the modified patch. > > On Tue, Jul 26, 2016 at 1:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have used font awesome icon (+) for add butto

[pgadmin-hackers] pgAdmin 4 commit: Replace 'Add' buttons with '+'

2016-07-26 Thread Dave Page
Replace 'Add' buttons with '+' Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e803464ee0256c7211f101c7de2b6bbf9761ffc6 Author: Akshay Joshi Modified Files -- .../templates/fts_configuration/js/fts_configuration.js | 5

[pgadmin-hackers] pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser

2016-07-26 Thread Dave Page
Property 'URL' (of type string) not quoted in browser.js template when extending pgAdmin.Browser. Fixes #1504 Without quotes, the property can be mistakenly treated as a regex: e.g.: URL: /pgadmin/browser/, When that happens, JS engine throws "SyntaxError: invalid regular expression flag b" an

[pgadmin-hackers] PATCH: To disable SQLALCHEMY to tracking (pgAdmin4)

2016-07-26 Thread Murtuza Zabuawala
Hi All, PFA patch which will disable SQLALCHEMY track modification feature as it put overhead on system. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company disable_sqlalchemy_tracking.patch Description: Binary data -- Sent via pgadmin-ha

Re: [pgadmin-hackers] Used font awesome icon instead of 'Add' caption for Add button

2016-07-26 Thread Akshay Joshi
Hi Forgot to add css changes. Attached is the modified patch. On Tue, Jul 26, 2016 at 1:03 PM, Akshay Joshi wrote: > Hi All > > I have used font awesome icon (+) for add button instead of caption "Add" > where ever possible. Attached is the patch. Please review it and let me > know the review c

[pgadmin-hackers] Used font awesome icon instead of 'Add' caption for Add button

2016-07-26 Thread Akshay Joshi
Hi All I have used font awesome icon (+) for add button instead of caption "Add" where ever possible. Attached is the patch. Please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Fixes_Add_Cap