Re: [pgadmin-hackers] [pgAdmin4][Patch]: Using F5 for Query Execution in Query tool

2016-07-27 Thread Surinder Kumar
Hi Please find attached patch with following fixes: 1) This patch adds support for Function Keys(F5, F7, F8) as keyboard shortcuts. Following are the keyboard shortcuts for query tool operations such as: - Execute query --> *F5* - Explain query --> *F7* - Explain analyze query --> *Shif

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-07-27 Thread Priyanka Shendge
On 27 July 2016 at 20:12, Dave Page wrote: > Ahh, that explains it. Nice catch! It's working in both server and > desktop modes now :-). > Great. Thanks to Khushboo for helping Navnath in this task. Thank you. > On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh > wrote: > > Hi Dave, > >

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-07-27 Thread Dave Page
Ahh, that explains it. Nice catch! It's working in both server and desktop modes now :-). I've committed the patch, but can you please look at the following issues: 1) When testing SMTP, the encoded password used to connect to the server is displayed in both the logs and stdout (the "send: 'AUTH

[pgadmin-hackers] pgAdmin 4 commit: Minor readme tweak.

2016-07-27 Thread Dave Page
Minor readme tweak. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5987af1b445b978bcd8d34b513c05ff25f954191 Modified Files -- web/regression/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Test suite improvements:

2016-07-27 Thread Dave Page
Test suite improvements: - Test framework support API testing with multiple server for this we need to modify test_config.json(for user it’s test_config.json.in) and test_advanced_config.json(for user it’s test_advanced_config.json.in). Server details of PG and PPAS are included in both .in fi

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Dave Page
Ashesh; please review and commit this. Thanks. On Wed, Jul 27, 2016 at 3:07 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM1260 (V4). > > Fixed create and delete operations for foreign table. > > > -- > *Harshal Dhumal* > *Software Engineer* > > En

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
Hi, PFA updated patch for RM1260 (V4). Fixed create and delete operations for foreign table. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi wrote: > Hi Harshal, > > Duri

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-27 Thread Dave Page
Thanks - applied! On Wed, Jul 27, 2016 at 1:37 PM, Murtuza Zabuawala wrote: > Okay, Let me check on that. > > Meanwhile I'm attaching patch for making Provider optional in security > labels control. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprise

[pgadmin-hackers] pgAdmin 4 commit: Security label providers are an optional parameter. F

2016-07-27 Thread Dave Page
Security label providers are an optional parameter. Fixes #1478. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6e8d195dc7eb3630aa8db5cdc5e5a64194227f1 Author: Murtuza Zabuawala Modified Files -- .../schemas/tables/templates/colu

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Ashesh Vashi
Hi Harshal, During testing, I found that create, and delete operation on foreign table is not working. Foreign table node uses, it's own version of Select2 Control, which should have used maximum functionalities from the original NodeAjaxOptionsControl for consistency reason. Hence - I have made t

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-27 Thread Murtuza Zabuawala
Okay, Let me check on that. Meanwhile I'm attaching patch for making Provider optional in security labels control. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 5:04 PM, Dave Page wrote: > Hi

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-07-27 Thread Navnath Gadakh
Hi Dave, We have reproduced the issue you mentioned in the previous email. We need to skip the login related test cases when SERVER_MODE = False in the web/config_local.py. Please find the revised patch for the same. Thanks! On Fri, Jul 22, 2016 at 9:48 PM, Dave Page wrote: > Hi > > On F

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-27 Thread Dave Page
Hi On Wed, Jul 27, 2016 at 12:18 PM, Murtuza Zabuawala wrote: > Hi Dave, > > 1) Unicode conversion was working properly for function node, It was failing > due to wrong sql templates. > - I've fixed them. I just did a test, and it's still failing - see the attached screenshot. Aside from the enc

[pgadmin-hackers] pgAdmin 4 commit: Display basic query info when execution completes in

2016-07-27 Thread Dave Page
Display basic query info when execution completes in the query tool. Fixes #1507 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4f8273994ee00ac1fb98f6848339d4735c0bf05 Modified Files -- docs/en_US/images/preferences_sql_display.pn

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
and patch file -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM1260. > > In addition to RM1260 i

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
Hi, PFA updated patch for RM1260. In addition to RM1260 issue I have added following changes in this patch. 1] datamodel.js: Added option check against undefined. 2] foreign key: fixed first empty option issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb