[pgadmin-hackers] [Patch][pgAdmin4]: RM1532 - Query Tool can get stuck waiting for query result

2016-08-09 Thread Surinder Kumar
Hi When a query is running in query tool, the keyboard shortcuts should not respond untill it finished execution. Also, remove the string ** Error ** from generated error message. Please find attached patch and review. Thanks, Surinder Kumar RM1532.patch Description: Binary dat

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool button/menu inconsistencies. Fixes #14

2016-08-09 Thread Dave Page
Fix query tool button/menu inconsistencies. Fixes #1461 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=035066bd41941879ca73dfa26fb6d82261b4d8c8 Author: Akshay Joshi Modified Files -- .../tools/datagrid/templates/datagrid/index.htm

Re: [pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

2016-08-09 Thread Dave Page
Thanks, committed with a couple of minor tweaks. On Tue, Aug 9, 2016 at 3:07 PM, Akshay Joshi wrote: > Hi All > > Attached is the patch to fix RM #1461 Query tool button/menu > inconsistencies. Please review it and let me know the review comments. > > -- > *Akshay Joshi* > *Principal Software En

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-09 Thread Dave Page
Thanks - applied with some minor wording and README tweaks. On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh wrote: > Hi Dave, > > On Mon, Aug 8, 2016 at 9:15 PM, Dave Page > wrote: >> >> Hi >> >> I guess you need to test if tablespace_path is omitted, not just empty? > > Yes, thats right.. P

[pgadmin-hackers] pgAdmin 4 commit: Test suite enhancements:

2016-08-09 Thread Dave Page
Test suite enhancements: 1. The user will specify the tablespace path in test_config.json.in 2. If tablespace path not found, skip the test cases for that server(Only tablespace test cases) 3. Add the skipped test summary in the test result. (Now it's showing on console + in log file, but need

[pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

2016-08-09 Thread Akshay Joshi
Hi All Attached is the patch to fix RM #1461 Query tool button/menu inconsistencies. Please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1461.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Albe Laurenz
Neel Patel wrote: > We already have condition for QUrlQuery class as below. It will be used only > if Qt version is >= 5.0. > > #if QT_VERSION >= 0x05 > // Extract filename and query from encoded URL > QUrlQuery query_data(reply->url()); > QString file_name = query_data.queryItemV

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page
On Tue, Aug 9, 2016 at 2:21 PM, Ashesh Vashi wrote: > On Tue, Aug 9, 2016 at 6:47 PM, Dave Page wrote: > >> >> >> On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: >>> On Tue, Aug 9, 201

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page
On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi wrote: > On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: > >> >> >> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: >>> Hi On Tue, Aug 9,

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi
On Tue, Aug 9, 2016 at 6:47 PM, Dave Page wrote: > > > On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wro

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi
On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: > > > On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >>> wrote: >>> > Hi, >>> > >>>

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Neel Patel
Hi, We already have condition for QUrlQuery class as below. It will be used only if Qt version is >= 5.0. #if QT_VERSION >= 0x05 // Extract filename and query from encoded URL QUrlQuery query_data(reply->url()); QString file_name = query_data.queryItemValue("filename"); QStrin

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page
On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi wrote: > On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: > >> Hi >> >> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >> wrote: >> > Hi, >> > >> > PFA patch to fix the issue where message panel was showing incomplete >> info. >> > We may still mi

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi
On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: > Hi > > On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue where message panel was showing incomplete > info. > > We may still miss some messages from Psycopg2 driver due to limited size > of > >

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page
Hi On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where message panel was showing incomplete info. > We may still miss some messages from Psycopg2 driver due to limited size of > notices queue. > (RM#1523) A few thoughts on this (mostly based on my

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Albe Laurenz
Neel Patel wrote: >> WebViewWindow.h:20:20: error: QWebView: No such file or directory > From the logs, it looks like - Qt webkit component is missing in Qt4 > installation. > Are you building Qt from source, If yes then there will be option in > configure script to build Qt4 > with webkit.

[pgadmin-hackers] pgAdmin 4 commit: Add missing updates from the previous commit.

2016-08-09 Thread Dave Page
Add missing updates from the previous commit. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b13d5501635aa4dc439ef47c2c4142c6bafdb9b Modified Files -- web/pgadmin/browser/server_groups/servers/templates/servers/servers.js | 2 ++

[pgadmin-hackers] pgAdmin 4 commit: Add missing collection node child counts. Fixes #1250

2016-08-09 Thread Dave Page
Add missing collection node child counts. Fixes #1250 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9dfc7bff3511d09c881be84047567a3cbfaba1e3 Author: Akshay Joshi Modified Files -- .../browser/templates/browser/js/collection.js

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-09 Thread Dave Page
Awesome - just what I was expecting, and it works nicely :-). Thanks, committed. On Tue, Aug 9, 2016 at 12:00 PM, Akshay Joshi wrote: > Hi Dave > > I have implemented the logic as per your suggestion. When user will expand > the collection node label will get updated with collection count. Atta

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-09 Thread Akshay Joshi
Hi Dave I have implemented the logic as per your suggestion. When user will expand the collection node label will get updated with collection count. Attached is the new patch file, please review it and let me know the review comments. On Mon, Aug 8, 2016 at 5:50 PM, Dave Page wrote: > > > On Mo

[pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where message panel was showing incomplete info. We may still miss some messages from Psycopg2 driver due to limited size of notices queue. (RM#1523) Regards, Murtuza diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py ind