Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

On Sat, Aug 20, 2016 at 1:39 AM, Dave Page wrote: > Hi > > That's not a reliable check - you can just as easily use postgres as the > maintenance db on epas. > ​Yes, somehow i missed it.​ > > Why don't we just hide the option if disconnected, and if connected, then > check the server type? > ​Th

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

Hi That's not a reliable check - you can just as easily use postgres as the maintenance db on epas. Why don't we just hide the option if disconnected, and if connected, then check the server type? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.ent

[pgadmin-hackers] [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes

Hi Add support to select highlighted option in Select2 control on TAB press. Capture the TAB event on Keypress of Select2 selector, then trigger select item event of Select2 object. Please find attached patch and review. Thanks, Surinder Kumar RM1251.patch Description: Binary data -- Sent v

[pgadmin-hackers] [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

Hi *Issue:* Two reasons: 1) In Resource group menu, the check for server connected or not is missing. 2) When server is disconnected, server type is always set to 'pg' which is wrong and thus function always returns true. *Solution:* If server is disconnected, we should check server type based on

Re: [pgadmin-hackers] PATCH/s: RM#1387 - Bad handling of missing connection database server

Hi Can you re-base please? The nodes patch no longer applies. Ignoring that conflict though, the first test I did was to restart the app server when connected to a database. I then (after it restarted) to open the Schemas node in that database; nothing happened at all in the client, but on the se

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1570 - Cannot select template databases when creating a database

Thanks, applied. On Fri, Aug 19, 2016 at 3:17 PM, Surinder Kumar wrote: > Hi > > Issue: > We are using 'node-list-by-name' control to get list of db nodes using > database 'nodes' method which filters out names based on 'show system > objects' value. > > Solution: > Override node-list-by-name tra

[pgadmin-hackers] pgAdmin 4 commit: Allow template databases to be used when creating new

Allow template databases to be used when creating new databases. Fixes #1570 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5690dfda16ed114107a511db2870a0596ad59a5d Author: Surinder Kumar Modified Files -- .../server_groups/server

[pgadmin-hackers] [pgAdmin4][Patch]: RM1570 - Cannot select template databases when creating a database

Hi *Issue:* We are using 'node-list-by-name' control to get list of db nodes using database 'nodes' method which filters out names based on 'show system objects' value. *Solution:* Override node-list-by-name transform method and define a new method 'get_databases' which fetches all nodes includin

[pgadmin-hackers] pgAdmin 4 commit: More string tweaks.

More string tweaks. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5f6c63ead5c1e1ad106f8e3ec25c07905c92e44 Modified Files -- .../tools/datagrid/templates/datagrid/index.html | 4 ++-- web/pgadmin/tools/sqleditor/__init__.py

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature #1406 - Allow setting to use spaces instead of tab in query editor

Thanks, applied with some string tweaks. On Fri, Aug 19, 2016 at 10:55 AM, Surinder Kumar wrote: > Hi > > This patch adds support for following: > 1) Allow to use either use Tab/Spaces in editor. > 2) Allow to specify Tab Size. > > This settings are configurable in Preferences and will be applied

[pgadmin-hackers] pgAdmin 4 commit: Allow the user to configure tabs in the SQL editor. F

Allow the user to configure tabs in the SQL editor. Fixes #1406 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=761b54ce69b2aeaa3df4611ef810091e839ba5de Author: Surinder Kumar Modified Files -- web/pgadmin/browser/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Clarify font sizing description.

Clarify font sizing description. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f99c3b60cd9ab8e0e7a54621a7e52b6cf32dca0 Modified Files -- web/pgadmin/browser/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -

[pgadmin-hackers] pgAdmin 4 commit: Correct the win-build directory in .gitignore.

Correct the win-build directory in .gitignore. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80f1c2e7ac7e44681b332a2fb3051688d57be948 Modified Files -- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Update MFizz font library. Fixes #1311

Update MFizz font library. Fixes #1311 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eca47efb031aaa4659596b1dcdbee0036eaf699c Author: Khushboo Vashi Modified Files -- libraries.txt|2 +- web/pgadmin

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: Fix for RM#1311 - Toolbar icon shown in italics on Windows

Thanks, applied. On Fri, Aug 19, 2016 at 10:00 AM, Khushboo Vashi wrote: > Hi, > > Re-sending the updated patch with the binary option. > > Thanks, > Khushboo > > On Fri, Aug 19, 2016 at 12:06 PM, Khushboo Vashi > wrote: >> >> Hi, >> >> Please find the attached patch to fix the issue RM#1311 :

[pgadmin-hackers] pgAdmin 4 commit: Ensure fractional sizes work for the SQL font.

Ensure fractional sizes work for the SQL font. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33b48170087ea7fb9e8bc217e0973f411df82467 Modified Files -- web/pgadmin/browser/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [pgadmin-hackers] Fixes RM #1567 Exception display if select Font size less then 1 for SQL text

Thanks, applied. On Fri, Aug 19, 2016 at 8:43 AM, Akshay Joshi wrote: > Hi All > > I have fixed the RM #1567 "Exception display if select Font size less then > 1 for SQL text". Attached is the patch file, please review it and let me > know the review comments. > > -- > *Akshay Joshi* > *Principa

[pgadmin-hackers] pgAdmin 4 commit: Fix validation of numeric preference min/max values.

Fix validation of numeric preference min/max values. Fixes #1567 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86858b18f65d9c861196180b8fec6a7b704e7b70 Author: Akshay Joshi Modified Files -- web/pgadmin/utils/preferences.py | 16

[pgadmin-hackers] Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function

On 19 August 2016 at 15:17, Dave Page wrote: > I also have been left with 159(!) databases across my three test > servers as a result of these failures. > > Please ensure that cleanup is fixed as a matter of priority - we > should always remove test databases. > Yes, in tearDownClass() cleanup p

[pgadmin-hackers] [pgAdmin4][Patch]: Feature #1406 - Allow setting to use spaces instead of tab in query editor

Hi This patch adds support for following: 1) Allow to use either use Tab/Spaces in editor. 2) Allow to specify Tab Size. This settings are configurable in Preferences and will be applied to all code mirror instances in pgAdmin4. Also, while setting "Help string" for *SwitchControl* in preference

Re: [pgadmin-hackers] [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

On Thu, Aug 18, 2016 at 5:26 PM, Surinder Kumar wrote: > On Aug 18, 2016 9:42 PM, "Dave Page" wrote: >> >> Hi >> >> On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > Issue: >> > The table column data is incomplete for columns having more character >> > lengths. >> > >>

[pgadmin-hackers] pgAdmin 4 commit: Display full text from backgrid cells that overflow i

Display full text from backgrid cells that overflow in a tooltip. Fixes #1442 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5b0cd29d87e535819666830c5ce512854403b74 Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/b

[pgadmin-hackers] Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function

I also have been left with 159(!) databases across my three test servers as a result of these failures. Please ensure that cleanup is fixed as a matter of priority - we should always remove test databases. Sidenote: Why are we creating so many? It would be *far* more efficient to create just one

Re: [pgadmin-hackers] Fix for RM 1252 Support CREATE LANGUAGE

Thanks, applied. On Fri, Aug 12, 2016 at 2:58 PM, Akshay Joshi wrote: > Hi All > > I have fixed RM #1252 "Support CREATE LANGUAGE". Attached is the patch > file, please review it and let me know the review comments. > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20

[pgadmin-hackers] pgAdmin 4 commit: Support CREATE LANGUAGE. Fixes #1252

Support CREATE LANGUAGE. Fixes #1252 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dffb020f1c898cb8f178dbacb378cd9a658832a Author: Akshay Joshi Modified Files -- .../servers/databases/languages/__init__.py| 150 +

[pgadmin-hackers] Fixes RM #1567 Exception display if select Font size less then 1 for SQL text

Hi All I have fixed the RM #1567 "Exception display if select Font size less then 1 for SQL text". Attached is the patch file, please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1567.pat