[pgadmin-hackers] [pgAdmin4][Patch]: RM#1238

2016-08-25 Thread Neel Patel
Hi, Please find attached minor patch for the fix of RM-1238. *Issue :- * Proper quoted SQL string was not generated. To resolve this issue, we formed proper SQL and now user can debug the function mentioned in RM case. Please review it and let us know for any comments. Thanks, Neel Patel RM_1

[pgadmin-hackers] pgAdmin 4 commit: Internal sever error displayed if create New user map

2016-08-25 Thread Akshay Joshi
Internal sever error displayed if create New user mapping with public user. Fixes #1468 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b72448ec92d725bd711e4449045830c5c8369e0 Modified Files -- .../user_mapping/templates/user_mapp

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Murtuza Zabuawala
Hi, Please find updated patch. I have also fixed the issue in package node which was displaying create menu in PG server. (separate patch attached) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 25, 2016 at 4:34 PM, Akshay J

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Akshay Joshi
Hi Murtuza Following are my review comments: - Create "Synonym" option is visible for Postgres Servers, when right click on schema node. - Unable to create Public Synonym faced "Internal Server Error". - SQL help not working when click on "[i]" button. - "Public Synonyms?" switch c

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Murtuza Zabuawala
Hi, PFA updated patch with `--binary` option for .png files. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for synonym

Re: [pgadmin-hackers] PATCH: id and pid is not being sent in response (pgAdmin4)

2016-08-25 Thread Akshay Joshi
Thanks. Patch applied On Wed, Aug 24, 2016 at 11:37 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where when user creates new domain, it > missing id & pid in response. > RM#1586 > > Please review. > > -- > Regards, > Murtuza Zabuawa

[pgadmin-hackers] pgAdmin 4 commit: domain node: id and pid is not being generated. Fixes

2016-08-25 Thread Akshay Joshi
domain node: id and pid is not being generated. Fixes #1586 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05473a7a35b0c09b73a5615a07cfe300ffd893bf Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/databases/sc