[pgadmin-hackers] Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function

2016-08-26 Thread Priyanka Shendge
Hi Dave, PFA patch for sequence node. I have made few modification to delete operation (added cascade delete) and added sequence label to pickle dict as synonym is dependant on it. Thank you. On 23 August 2016 at 18:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 23 Au

[pgadmin-hackers] [pgAdmin4][patch]: RM #1226

2016-08-26 Thread Neel Patel
Hi, Please find attached patch for fix of RM-1226. *Issue :- * Previously, "Set breakpoint" (Indirect debugging) option was missing for trigger and trigger function node. Now with this patch, user can able to debug trigger function. Please review it and let us know for any comments. Thanks, Ne

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Priyanka Shendge
1 more point to add: 5. Synonyms should only run for EPAS server On 26 August 2016 at 16:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Hi Murtuza, > > Please find my review comments below: > > 1. Please attach test_advanced_config.json.in file to read the config data > 2. Wh

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Priyanka Shendge
Hi Murtuza, Please find my review comments below: 1. Please attach test_advanced_config.json.in file to read the config data 2. While reading data from config file "owner" field is missing 3. Please add synonym pickle object to ../regression/test_utils.py file 4. Can we have config data parameter

[pgadmin-hackers] pgAdmin 4 commit: Getting 'AttributeError' in pgadmin4/web/pgadmin/brow

2016-08-26 Thread Akshay Joshi
Getting 'AttributeError' in pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py. Fixes #1464 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b05464a04a533a36f30f808b1bc0ab6d3062180 Modified Files -- web/pgadmin/browser/

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Akshay Joshi
Thanks, patch applied. On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch. > > I have also fixed the issue in package node which was displaying create > menu in PG server. (separate patch attached) > > -- > Regards,

[pgadmin-hackers] pgAdmin 4 commit: Implemented Synonym node for EPAS

2016-08-26 Thread Akshay Joshi
Implemented Synonym node for EPAS Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a78dd7ad3e9361f9c3b7f1d9d593fe685eb3f66 Author: Murtuza Zabuawala Modified Files -- .../packages/templates/package/js/package.js | 30 +- .../