Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog

2016-09-11 Thread Surinder Kumar
On Mon, Sep 12, 2016 at 11:13 AM, Murtuza Zabuawala wrote: > Hi Surinder, > > Just a heads up, When server is not connected and listed down in browser > tree then node has attribute 'type' instead of 'server_type'. > I have fixed similar issue few days ago Ref. link >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog

2016-09-11 Thread Murtuza Zabuawala
Hi Surinder, Just a heads up, When server is not connected and listed down in browser tree then node has attribute 'type' instead of 'server_type'. I have fixed similar issue few days ago Ref. link

[pgadmin-hackers] [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog

2016-09-11 Thread Surinder Kumar
Hi *Please find attached with following fixes:* 1) The function '*canCreateProc*' that checks if package is auth to create under catalog gets failed due to improper check of 'type'. Instead check should be like node_hierarchy['server'].*server_type* == "ppas" not node_hierarchy['server'].*type* =

Re: [pgadmin-hackers] python-click dependency

2016-09-11 Thread Ashesh Vashi
It was added by new flask depndency. On Sep 11, 2016 14:49, "Dave Page" wrote: > I've never even heard of python-click before! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 11

Re: [pgadmin-hackers] python-click dependency

2016-09-11 Thread Dave Page
I've never even heard of python-click before! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 11 Sep 2016, at 10:00, Devrim Gündüz wrote: > > > Hi, > > I think pgadmin4 depends on python-clic

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-11 Thread Devrim Gündüz
Hi, On Fri, 2016-09-09 at 11:26 +0100, Dave Page wrote: > For users to run in desktop mode, nothing else should be required, > except possibly a shortcut to the runtime executable. Any chance to add .desktop file to git, like we did for pgadmin3? > For all users, a config_distro.py file may be

[pgadmin-hackers] python-click dependency

2016-09-11 Thread Devrim Gündüz
Hi, I think pgadmin4 depends on python-click, but I did not see it mentioned anywhere. If so, can you please add it to requirements files, and also let me know the minimum version required? Thanks! -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red H

[pgadmin-hackers] Startup error on RHEL 7

2016-09-11 Thread Devrim Gündüz
Hi, Just saw this on my RHEL 7 test box. This is pgadmin4 1.0rc1, Python 2.7, python-flask-babel-0.11.1: # /usr/bin/python2 /usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.py Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.py", line 58, in