Cool - thanks, committed!
On Wed, Sep 14, 2016 at 2:57 PM, Navnath Gadakh
wrote:
> Hi Dave,
>
> Please find the revised patch with suggested modifications.
>
> On Wed, Sep 14, 2016 at 5:25 PM, Dave Page
> wrote:
>>
>> Hi
>>
>> On Tue, Sep 13, 2016 at 3:39 PM, Navnath Gadakh
>> wrote:
>> > Hi Da
Introduce a test config database for the regression tests, and track/remove
objects that are created during testing.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3d8836f6187e1f9a9dcdf2ab2e0c4d7c2ce46bd
Author: Navnath Gadakh
Modified File
Thanks, applied.
On Wed, Sep 14, 2016 at 2:21 PM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA minor patch to fix the issue where query tool attempts to "load
> arrow_right_spearmint.png" file.
> RM#1693
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise
Don't have the query tool try to load arrow_right_spearmint.png. Fixes #1693
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3807ba047beeb0cc3a34894d9cd40954990db972
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/tools/sql
Hi Dave,
Please find the revised patch with suggested modifications.
On Wed, Sep 14, 2016 at 5:25 PM, Dave Page
wrote:
> Hi
>
> On Tue, Sep 13, 2016 at 3:39 PM, Navnath Gadakh
> wrote:
> > Hi Dave,
> > Please find the patch for drop objects functionality for test
> > framework.
> > Now, t
Hi,
PFA minor patch to fix the issue where query tool attempts to "load
arrow_right_spearmint.png" file.
RM#1693
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_1693.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing
Hi
On Tue, Sep 13, 2016 at 1:09 PM, Priyanka Shendge
wrote:
>
>
> On 13 September 2016 at 14:18, Dave Page wrote:
>>
>> Hi
>>
>> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
>> wrote:
>> > Hi Dave,
>> > As we know that, we are using two JSON files one is for basic
>> > configuration of
Hi
On Tue, Sep 13, 2016 at 3:39 PM, Navnath Gadakh
wrote:
> Hi Dave,
> Please find the patch for drop objects functionality for test
> framework.
> Now, test framework is able to drop all objects(like server, database,
> schema, etc.) which are created during test suite execution. Code inclu
Fix condition check for avoiding sorting of columns.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcc81d32cce16bc77a873bd7ea54b501b9bffdfd
Modified Files
--
web/pgadmin/static/js/pgadmin.js | 2 +-
1 file changed, 1 insertion(+),
Oops, missed that :-(. Thanks, applied.
On Wed, Sep 14, 2016 at 11:48 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA minor patch to fix condition checking which was went into code with
> commit: 4ba8f4830bcdd8a9085b212
>
> Thanks to Surinder for pointing out.
>
>
> --
> Regards,
> Murtuza Zabuawala
>
Hi,
PFA minor patch to fix condition checking which was went into code with
commit: 4ba8f4830bcdd8a9085b212
Thanks to Surinder for pointing out.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
fixed_condition_checking.patch
Description
On Wed, Sep 14, 2016 at 11:23 AM, Surinder Kumar
wrote:
> On Wed, Sep 14, 2016 at 3:30 PM, Dave Page wrote:
>>
>> Thanks - committed with a couple of minor formatting tweaks:
>>
>> - Remove the leading space before arguments (e.g. s/, /\r\t/ instead
>> of s/,/\r\t/)
>> - Put the first argument on
Thanks - applied with a minor change to treat the save drop-down menu
button in the same way as the save button itself.
On Wed, Sep 14, 2016 at 10:03 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA minor patch to fix the issue where executing a query disables the Save
> button in the query tool
> RM#1
On Wed, Sep 14, 2016 at 3:30 PM, Dave Page wrote:
> Thanks - committed with a couple of minor formatting tweaks:
>
> - Remove the leading space before arguments (e.g. s/, /\r\t/ instead
> of s/,/\r\t/)
> - Put the first argument on a new line as well.
It seems fine except the case when there ar
Don't disable the save button when executing a query in the query tool. Fixes
#1695
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db7b8a8fa5035fa7b40bae67ecec38bfaa643027
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/t
On Wed, Sep 14, 2016 at 3:47 PM, Dave Page wrote:
> Awesome job tracking this one down!
>
Thanks.
>
> Thanks, patch applied.
>
> On Wed, Sep 14, 2016 at 9:23 AM, Surinder Kumar
> wrote:
> > Hi
> >
> > Issue:
> > On debugging deeply into the code mirror JS library, I found that Ctrl-V
> > even
Awesome job tracking this one down!
Thanks, patch applied.
On Wed, Sep 14, 2016 at 9:23 AM, Surinder Kumar
wrote:
> Hi
>
> Issue:
> On debugging deeply into the code mirror JS library, I found that Ctrl-V
> event is mapped for "goPageDown" which is the reason paste not working in
> Mac Runtime.
Fix CMD+V (Paste) in the Mac runtime. Finally fixes #1478
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3035ae13df42b759d0af64d99c21c5ca26f76776
Author: Surinder Kumar
Modified Files
--
web/pgadmin/browser/templates/browser/js/br
Thanks, applied.
On Wed, Sep 14, 2016 at 8:22 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to fix the issue where we were sorting columns based on labels
> instead of their position.
> RM#1687
>
> Please review.
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
>
Don't sort columns (tables, views, matviews, catalogs etc) on the treeview by
name, but by ordinal. Fixes #1687
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ba8f4830bcdd8a9085b212a853a2075c288566b
Author: Murtuza Zabuawala
Modified Files
Remove blank lines in the formatting of SELECT scripts for functions. Fixes
#1690
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ee631d6fcfb3a8683859f671ea852bc0ded2f95
Author: Surinder Kumar
Modified Files
--
.../server_groups/
Thanks - applied.
On Tue, Sep 13, 2016 at 2:41 PM, Surinder Kumar
wrote:
> Hi
>
> Trailing spaces included in SELECT Script due to Indentation issue.
> Please find attached patch.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To m
On Wed, Sep 14, 2016 at 10:32 AM, Devrim Gündüz wrote:
>
> Hi,
>
> On Wed, 2016-09-14 at 09:26 +0100, Dave Page wrote:
>
>> I think it's actually a dependency of something else, not a direct
>> dependency of pgAdmin.
>
> It is listed both in requirements_py2.txt and requirements_py3.txt.
Right -
Thanks - committed with a couple of minor formatting tweaks:
- Remove the leading space before arguments (e.g. s/, /\r\t/ instead
of s/,/\r\t/)
- Put the first argument on a new line as well.
Please double-check I didn't break anything that I've missed!
On Tue, Sep 13, 2016 at 12:41 PM, Surinder
Fix function signature generation for reverse engineered SQL. Fixes #1674
1) In SQL pane, the signature in comments had arguments with name and type, Now
it will show arguments with type only.
2) There is no indent+newline between arguments (there isn't even a space). -
Fixed
3) The default va
Ensure View Data on a table with zero columns doesn't throw an error. Fixes
#1677
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=751327eacc2eabcd170df39371d055a199bb8976
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/too
Thanks, applied.
On Tue, Sep 13, 2016 at 9:03 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to fix the issue where code breaks when user tries to view data on
> table which do not have any column(s).
> RM#1677
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
>
Thanks, applied.
On Tue, Sep 13, 2016 at 9:01 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA minor patch for rules node where it was throwing when user tries to
> create new rule.
> RM#1681
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL C
Fix creation of DO INSTEAD rules. Fixes #1681
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=046f6dd44240e53f553036b990dd036f35c99a7c
Author: Murtuza Zabuawala
Modified Files
--
.../servers/databases/schemas/tables/templates/rules
Hi,
I pushed pgadmin4 1.0 rc1 RPMs for RHEL 7 and Fedora 23 & 24 to PostgreSQL YUM
repository:
http://yum.postgresql.org
It is currently only in 9.6 repository. Any tests are really appreciated,
before pushing it to other branches. I added about 30 new packages to
repository to satisfy dependnc
Thanks, applied.
On Tue, Sep 13, 2016 at 8:58 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to fix the issue where user tries to refresh on Table collection
> node it was throwing error.
> RM#1686
>
> Issue: Nodes method was not implemented properly to handle such request in
> Table node.
>
>
Fix a typo in the error handling in the browser that caused some errors to be
reported to the console only.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a67c4fc1dc8c15317fde3b5bf4dde88465841740
Author: Murtuza Zabuawala
Modified Files
Hi,
On Wed, 2016-09-14 at 09:26 +0100, Dave Page wrote:
> I think it's actually a dependency of something else, not a direct
> dependency of pgAdmin.
It is listed both in requirements_py2.txt and requirements_py3.txt.
Cheers,
--
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreS
Fix error when refreshing table node. Fixes #1686
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=071b609a44dcb68991ea03c5ca6d5b72467c7cf6
Author: Murtuza Zabuawala
Modified Files
--
.../servers/databases/schemas/tables/__init__.py
Hi,
PFA minor patch to fix the issue where executing a query disables the Save
button in the query tool
RM#1695
Please review.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_1695.patch
Description: Binary data
--
Sent via pgadmin
On Tue, Sep 13, 2016 at 10:07 PM, Devrim Gündüz wrote:
>
> Hi,
>
> Per https://www.crummy.com/software/BeautifulSoup/ , beautifulsoup4 requires
> Python 2.7+, which is not available on RHEL 6, which includes PY 2.6.
>
> I don't intend to build PY 2.7 into RHEL 6 (*swh*) , so any recommendations
>
Hi
*Issue:*
On debugging deeply into the code mirror JS library, I found that* Ctrl-V
event *is mapped for *"goPageDown" *which is the reason paste not working
in Mac Runtime.
I have removed this mapping temporary from Code-mirror key map object once
code mirror JS library is loaded.
In Mac Runt
Hi,
PFA patch to fix the issue where we were sorting columns based on labels
instead of their position.
RM#1687
Please review.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/templates/browser/js/browser.js
38 matches
Mail list logo
