Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

Hi On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh wrote: > Hi Dave, > Please find the patch for the enhanced test result summary for testing > framework. The code for this, was completed before drop object's > functionality & independent from drop objects work. > Drop objects work will take

Re: [pgadmin-hackers] PATCH: To fix the issue in various node for special character (pgAdmin4)

Thanks, applied. On Fri, Sep 16, 2016 at 3:22 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch which will fix the issue where user was not able to create > objects if parent schema has special characters in it. > RM#1598 > > Issue: > We had escape special character in labels to prevent XSS

[pgadmin-hackers] pgAdmin 4 commit: Allow creation of objects in schemas with special cha

Allow creation of objects in schemas with special chars in the name. Fixes #1598 This was caused through generation of SQL based on HTML-escaped labels, not the raw versions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc5ce22de90b214e890d

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

Thanks - committed with a couple of changes: - I re-formatted the SQL - s/lables/labels Awesome speedup BTW - deleting 25K rows went from >10 minutes to virtually instant. Good work. On Fri, Sep 16, 2016 at 12:34 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find updated patch. > > > Regar

[pgadmin-hackers] pgAdmin 4 commit: Bulk delete rows in SlickGrid. Fixes #1696

Bulk delete rows in SlickGrid. Fixes #1696 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c044af95856500bcd01284db7f6c3afc1c9a3e4f Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/command.py | 27

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue where several default privileges cause e

Fix an issue where several default privileges cause error on database. Fixes #1670 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5f04d03c62efff8eb25c1dbc1e5283804d7de2f Author: Murtuza Zabuawala Modified Files -- .../schema/pg/

Re: [pgadmin-hackers] PATCH: To fix the isssue where several default privileges cause error (pgAdmin4)

Thanks, applied. On Fri, Sep 16, 2016 at 12:17 PM, Murtuza Zabuawala wrote: > Hi, > > > PFA patch to fix the issue where several default privileges cause error on > database. > RM#1670 > > Issue: > There were multiple rows returned by subquery that was the issue. > > -- > Regards, > Murtuza Zabua

[pgadmin-hackers] pgAdmin 4 commit: Fix updating of matview definitions. Fixes #1595

Fix updating of matview definitions. Fixes #1595 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92bc312d2dc58923c4463569edd83f8f2242304f Author: Surinder Kumar Modified Files -- .../servers/databases/schemas/views/__init__.py|

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1595 - "no results to fetch error" displayed if modify definition with other table

Thanks, applied. On Fri, Sep 16, 2016 at 11:14 AM, Surinder Kumar wrote: > Hi > > Issues fixed: > > 1) Creating a m-view with definition and then updating view with new > definition, it results into an error "No results to fetch". > > 2) When definition of m-view is updated, it creates a new m-vi

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

On Fri, Sep 16, 2016 at 3:35 AM, Dave Page wrote: > Ashesh, Murtuza, Surinder, > > Any thoughts on how we can achieve this easily, and where we're > lacking notifications? We did have activity notification in the > treeview, but that never worked overly well and now I come to think of > it, I don

[pgadmin-hackers] PATCH: To fix the issue in various node for special character (pgAdmin4)

Hi, PFA minor patch which will fix the issue where user was not able to create objects if parent schema has special characters in it. RM#1598 *Issue:* We had escape special character in labels to prevent XSS Vulnerability in node browser tree which cause this issue. -- Regards, Murtuza Zabuawal

[pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

Hi Dave, Please find the patch for the enhanced test result summary for testing framework. The code for this, was completed before drop object's functionality & independent from drop objects work. Drop objects work will take time, I am working on that for remaining nodes. Meanwhile, we go ahea

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

Hi Dave, Please find updated patch. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Sep 16, 2016 at 3:31 PM, Dave Page wrote: > Can you rebase this please? > > Thanks. > > On Thu, Sep 15, 2016 at 11:08 AM, Mur

[pgadmin-hackers] PATCH: To fix the isssue where several default privileges cause error (pgAdmin4)

Hi, PFA patch to fix the issue where several default privileges cause error on database. RM#1670 *Issue:* There were multiple rows returned by subquery that was the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1670.patch D

Re: [pgadmin-hackers] Sequence queries on pg_depend lacking classid filter

Thanks - committed with a minor change to remove a duplicate WHERE clause that you added to one of the queries. On Thu, Sep 15, 2016 at 5:22 PM, Magnus Hagander wrote: > There are a number of cases where queries in both pgadmin4 and pgadmin3 are > done against pg_depend but falis to constrain the

[pgadmin-hackers] pgAdmin 4 commit: Add classid filter to queries on pg_depend. Fixes #17

Add classid filter to queries on pg_depend. Fixes #1705 There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid. In particular, if for example a constraint and a sequence exists with the same oid (which is pe

Re: [pgadmin-hackers] Documentation patch for pgAdmin 4

Thanks - applied! On Thu, Sep 15, 2016 at 3:55 PM, Susan Douglas wrote: > Hi All, > > The attached patch contains updates to the doc files to add new dialogs, and > update minor changes on existing dialogs. Let me know if there are any > problems! > > Thanks! > > -- Susan > -- Dave Page VP

[pgadmin-hackers] [pgAdmin4][Patch]: RM1595 - "no results to fetch error" displayed if modify definition with other table

Hi *Issues fixed:* 1) Creating a m-view with *definition* and then updating view with* new definition,* it results into an error *"No results to fetch"*. 2) When definition of m-view is updated, it creates a new m-view with different OID, but it wasn't updating the old OID with new OID of tree n

[pgadmin-hackers] pgAdmin 4 commit: Documentation update

Documentation update Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f98e6c207bc8f04497342f69718e8a2cf6ef2ec Author: Susan Douglas Modified Files -- docs/en_US/browser.rst | 6 +-- docs/en_US/check_dialog.rs

[pgadmin-hackers] pgAdmin 4 commit: Fix a syntax error when creating a trigger function o

Fix a syntax error when creating a trigger function on PPAS 9.5+. Fixes #1600 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=165b93a968e0f78e92260a39fd408a94ffd4a66f Author: Surinder Kumar Modified Files -- .../functions/templates

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server

Thanks, applied. On Thu, Sep 15, 2016 at 1:05 PM, Surinder Kumar wrote: > Hi > > An extra comma at the end of function statement results in Syntax Error > while saving. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgad

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1669 - Cannot remove nor change length definition on column in "The Table Dialog"

Thanks, committed. On Thu, Sep 15, 2016 at 11:21 AM, Surinder Kumar wrote: > Hi > > Please find attached patch. >> >> Add proper check for the column length and precision in Jinja template. > > > Please review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadm

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue when changing the length of a column in

Fix an issue when changing the length of a column in the table dialogue. Fixes #1669 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ce5b38f4a099ed90f3ab8c15ebd778252fe0104 Author: Surinder Kumar Modified Files -- .../schemas/tab

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

Can you rebase this please? Thanks. On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue of slow performance while deleting rows from > grid. > RM#1696 > > Issue: > As per logic implemented for Backgrid, we were deleting individual rows, > means If user

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

Hi Seçkin, On Fri, 2016-09-16 at 11:42 +0300, Seçkin Alan wrote: > https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadm > in4/F- > 24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b > 6bb3615eebde2f253ebef438d3c27d48 > > Could you look this fil

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue in the Query Tool which causes it to han

Fix an issue in the Query Tool which causes it to hang in some installations of Chrome 53.0.2785.116 on Mac. This commit also modifies the Query Tool to load SlickGrid using require.js. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f32427c5

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

pgAdmin 4 is the correct speeling :-) On Fri, Sep 16, 2016 at 9:42 AM, Seçkin Alan wrote: > Hi Devrim, > > https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadmin4/F-24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b6bb3615eebde2f253ebef438d3c27d

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

Hi Devrim, https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadmin4/F-24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b6bb3615eebde2f253ebef438d3c27d48 Could you look this file ? this variable is incorrect Name=pgAdmin III Its should be Name=p

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

Ashesh, Murtuza, Surinder, Any thoughts on how we can achieve this easily, and where we're lacking notifications? We did have activity notification in the treeview, but that never worked overly well and now I come to think of it, I don't recall seeing it recently. I'm thinking we need something:

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

Hi, On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote: > > Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-) \o/ Can't wait ;) > Let me know when packages available and ready to use, and I'll add a > page to the website to point people at them. They are currently avail

Re: [pgadmin-hackers] python-click dependency

Hi, On Mon, 2016-09-12 at 09:21 +0100, Dave Page wrote: > Ah, OK - added to requirements. Thanks dude! Cheers, -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR signature.asc Descrip