Re: [pgadmin-hackers] PATCH: RM#1735

Hi Team, On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi wrote: > Hi Dave/Team, > > I've fixed the issue "No default schema when creating some schema objects". > > For package, allowing to change the schema at the create time only, as the > logic required to change schema of an existing package r

[pgadmin-hackers] PATCH: RM#1733

Hi Dave/Team, Please find the patch for the issue - 'Filter option taking too much time to load'. Actually - it wasn't taking any time, but - we did not hide the loading div properly. Please find the patch, which also takes care of other similar possible issue along with the above issue. -- Tha

[pgadmin-hackers] PATCH: RM#1736

Hi Dave/Team, Please find the patch for the "Cannot create a view". When we do not select the schema name, this error comes at backend-side. The client-side issue has been taken care by the patch for RM#1735. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <

[pgadmin-hackers] PATCH: RM#1735

Hi Dave/Team, I've fixed the issue "No default schema when creating some schema objects". For package, allowing to change the schema at the create time only, as the logic required to change schema of an existing package required a lot of changes. And, I am reluctant to do it at this phase of the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

Umm, no it wasn't - sorry. I see the same issue with Types. Can you fix that, and check all other nodes as well please? Thanks. On Fri, Sep 23, 2016 at 1:29 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar > wrote: >> Hi, >> >> Please find updated pa

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

Thanks, applied. On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar wrote: > Hi, > > Please find updated patch with changes: > 1) On debugging through JS files, the issue was in synonym update method > which wasn't returning node object. > 2) retrieving schema name in node.sql for creating node obj

Re: [pgadmin-hackers] PATCH: To fix the '/logout' redirects to '/' (pgAdmin4)

Thanks, applied. On Fri, Sep 23, 2016 at 11:38 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where '/logout' redirects to '/', which cause > issue if pgAdmin4 is running in virtual root environment. > RM#1691 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.ent

[pgadmin-hackers] pgAdmin 4 commit: Ensure we go back to the login page after logging out

Ensure we go back to the login page after logging out, when installed at a virtual root. Fixes #1691 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c855234f865d61e034196830f9afd7bdd391607 Author: Murtuza Zabuawala Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

Hi, Please find updated patch with changes: 1) On debugging through JS files, the issue was in synonym update method which wasn't returning node object. 2) retrieving schema name in node.sql for creating node object in update method. Please review and let me know for comments. On Fri, Sep 23, 20

[pgadmin-hackers] PATCH: To fix the '/logout' redirects to '/' (pgAdmin4)

Hi, PFA patch to fix the issue where '/logout' redirects to '/', which cause issue if pgAdmin4 is running in virtual root environment. RM#1691 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/brows

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

Hi On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar wrote: > Hi > > Issue: > on updating node, we deselect and then again select the node updated to > refresh the panel. but it needs some delay of few milliseconds between > deselect and select to fix this issue. > > Please find attached patch and

Re: [pgadmin-hackers] PATCH: pgAgent support

Thanks - working on the rest of the comments. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Sep 23, 2016 at 2:40 PM, Dave Page wrote:

[pgadmin-hackers] pgAdmin 4 commit: Change rolvaliduntil format to "YYYY-MM-DD HH:mm:ss Z

Change rolvaliduntil format to "-MM-DD HH:mm:ss Z" for consistency with the rest of the app. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8797b3f3bf39832129f49cfaa535d2eb3c64b51c Author: Ashesh Vashi Modified Files -- .../b

Re: [pgadmin-hackers] PATCH: pgAgent support

Thanks, applied. On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi wrote: > Hi Dave, > > > On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote: >> >> Hi >> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi >> wrote: >>> >>> Hi Dave, >>> >>> Please find the patch for support for paAgent in pgAdmin 4. >

Re: [pgadmin-hackers] PATCH: Do not display 'CREATE Script' on Server-group & Server node (pgAdmin4)

Thanks, applied. On Fri, Sep 23, 2016 at 7:27 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue where we were displaying 'CREATE Script' on > Server-group & Server node. > RM#1578 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enter

[pgadmin-hackers] pgAdmin 4 commit: Don't offer CREATE Script options on servers or serve

Don't offer CREATE Script options on servers or server groups. Fixes #1578 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f18c4554113dd05d9318ba1f36557ca15eef4a5b Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/tem

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

On Fri, Sep 23, 2016 at 1:45 PM, Dave Page wrote: > On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar > wrote: > > > > > > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar > >> wrote: > >> > Hi Dave/Ashesh > >> > > >> > The

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

On Fri, Sep 23, 2016 at 1:54 PM, Dave Page wrote: > > > On Fri, Sep 23, 2016 at 9:18 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Fri, Sep 23, 2016 at 1:47 PM, Dave Page wrote: >> >>> On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar >>> wrote: >>> > Actually It doesn't brok

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

On Fri, Sep 23, 2016 at 9:18 AM, Ashesh Vashi wrote: > On Fri, Sep 23, 2016 at 1:47 PM, Dave Page wrote: > >> On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar >> wrote: >> > Actually It doesn't broke anywhere, instead It runs successfully. On >> > debugging I found that it runs the subprocess.Po

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

On Fri, Sep 23, 2016 at 1:47 PM, Dave Page wrote: > On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar > wrote: > > Actually It doesn't broke anywhere, instead It runs successfully. On > > debugging I found that it runs the subprocess.Popen() utility but it > doesn't > > run internally the pg_dump

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar wrote: > Actually It doesn't broke anywhere, instead It runs successfully. On > debugging I found that it runs the subprocess.Popen() utility but it doesn't > run internally the pg_dump utitliy. On running the same command on windows > cmd prompt it

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar wrote: > > > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page wrote: >> >> Hi >> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar >> wrote: >> > Hi Dave/Ashesh >> > >> > The thing we can do is: >> > 1) We can display loading message same as other panel