On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar
wrote:
> On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote:
>>
>> Hi
>>
>> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
>> wrote:
>> > Hi
>> >
>> > This fix is for exclusion constraint.
>> > The options like "order" and "nulls" must be conditiona
On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote:
> Hi
>
> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
> wrote:
> > Hi
> >
> > This fix is for exclusion constraint.
> > The options like "order" and "nulls" must be conditional. i.e. include
> only
> > when access method type is other than "gi
Hi
On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
wrote:
> Hi
>
> This fix is for exclusion constraint.
> The options like "order" and "nulls" must be conditional. i.e. include only
> when access method type is other than "gist".
When creating an index, the asc/desc options are disabled if gist
Hi
This fix is for exclusion constraint.
The options like "order" and "nulls" must be conditional. i.e. include only
when access method type is other than "gist".
Please find attached patch and review.
On Fri, Oct 21, 2016 at 4:38 PM, Dave Page wrote:
> Thanks, applied.
>
> On Thu, Oct 20, 201
Thanks, applied.
On Fri, Oct 21, 2016 at 3:55 PM, Surinder Kumar
wrote:
> I missed to add the check "destroy only if select2 has destroy property'. in
> previous patch.
> It was reproducible when I select access method of exclusion constraint from
> combo box.
>
> Please find attached patch and r
Ensure select2 instances have a destroy property before calling destroy.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19bd021696247cf895488bef61535f5b2b9444a6
Author: Surinder Kumar
Modified Files
--
web/pgadmin/static/js/backfo
Thanks, applied.
On Fri, Oct 21, 2016 at 3:06 PM, Harshal Dhumal
wrote:
> Hi,
>
> PFA patch for RM1875.
>
> Issue fixed:
> 1. Exclusion constraint added support for pg-9.6
> 2. Fixed index out of list (python error) when Exclusion constraint is
> created without name.
>
>
> --
> Harshal Dhumal
>
Fix exclusion constraint support on 9.6. Fixes #1875
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2952faab5edcaf8dd75870fcab08f41af637ff88
Author: Harshal Dhumal
Modified Files
--
.../servers/databases/schemas/tables/__init__.py
Fix refreshing of FTS Dictionaries. Fixes #1837
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23a0fc2f223943b574272d7c976c8897e4da7a84
Author: Surinder Kumar
Modified Files
--
.../fts_dictionaries/templates/fts_dictionary/sql/9.1
Thanks, patch applied.
On Fri, Oct 21, 2016 at 2:41 PM, Surinder Kumar
wrote:
> Hi
>
> The schema was supposed to be returned from nodes.sql but it wasn't.
> I have verified refresh of other nodes which is working fine.
>
> Please find attached patch and review.
>
> Thanks
> Surinder Kumar
>
>
>
Thanks - applied, with one change to *enable* the SQL tabs everywhere.
On Fri, Oct 21, 2016 at 2:41 PM, Harshal Dhumal
wrote:
> Hi,
>
> PFA updated patch for RM1878
>
> Issues fixed:
>
> 1. ProgrammingError: can't adapt type 'Undefined' for schedule
> 2. Fixed malformed array literal issue raised
Ensure steps and schedules can be created in empty jobs. Fixes #1878
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef0d26c29459ef9bd168e249d4578f325e8403f2
Modified Files
--
.../servers/pgagent/schedules/__init__.py | 68
I missed to add the check "destroy only if select2 has destroy property'.
in previous patch.
It was reproducible when I select access method of exclusion constraint
from combo box.
Please find attached patch and review.
On Sat, Oct 15, 2016 at 12:50 AM, Dave Page wrote:
> Thanks, applied.
>
>
On Fri, Oct 21, 2016 at 2:40 PM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to fix the issue where it was not reporting error when it fails to
> starts & went into infinite loop recursion of popup when task is deleted
> from server(which is a transient issue).
> RM#1679
Thanks, applied.
> Note
Ensure we handle external processes that fail to start. Fixes #1679
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6d018c44f73bcf54644a8341065fbc282792205
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/misc/bgprocess/pro
Allow package bodies to be dropped. Fixes #1867
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e9108e0f356e7f510dd7fac7a2953b5e1bde235
Author: Surinder Kumar
Modified Files
--
.../schemas/packages/templates/package/ppas/9.1_plus/
Thanks, applied.
On Fri, Oct 21, 2016 at 2:18 PM, Surinder Kumar
wrote:
> Hi
>
> While editing the package properties, if pkg body is empty, It should drop
> the package. but it wasn't generating drop package query.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> -
Thanks, applied.
On Fri, Oct 21, 2016 at 8:35 AM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the patch to fix RM 1887: Preferences values ate not stored
> properly.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your
Ensure preferences values are stored properly. Fixes #1877
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a97d21cc907f32930d7e91c31a943eec83243493
Author: Khushboo Vashi
Modified Files
--
web/pgadmin/preferences/templates/preferen
Hi,
PFA patch for RM1875.
Issue fixed:
1. Exclusion constraint added support for pg-9.6
2. Fixed index out of list (python error) when Exclusion constraint is
created without name.
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQ
Fix quoting of objects names for external utilities. Fixes #1603, fixes #1220,
fixes #1221
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a1795e4a0c0c97ebfcc30b207d69a7f142cf169
Author: Khushboo Vashi
Modified Files
--
web/pgadm
Thanks, patch applied.
On Fri, Oct 21, 2016 at 6:14 AM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the attached patch to fix below RMs:
>
> 1603: [Web Based] Export database failed if object contains double quotes
> 1220: Backup database is not working with special characters
> 1221: Maintena
Thanks, patch applied.
On Thu, Oct 20, 2016 at 7:07 PM, Harshal Dhumal
wrote:
> Hi,
>
> PFA patch for RM1863.
>
> Issue fixed: Correctly interpret composite data type for columns while
> generating sql.
> also minor UI improvement in foreign key column tab
>
> --
> Harshal Dhumal
> Software Engin
Properly quote type names in RE-SQL for tables. Fixes #1863
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aef508ff910a97bd6eeedd5fcb39a1b924998841
Author: Harshal Dhumal
Modified Files
--
.../servers/databases/schemas/tables/__in
Hi
The schema was supposed to be returned from nodes.sql but it wasn't.
I have verified refresh of other nodes which is working fine.
Please find attached patch and review.
Thanks
Surinder Kumar
RM1837.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@p
Hi,
PFA updated patch for RM1878
Issues fixed:
1. ProgrammingError: can't adapt type 'Undefined' for schedule
2. Fixed malformed array literal issue raised by postgres while creating
schedule
3. Fixed update of schedule.
4. Fixed update of step.
5. disabled sql tab (create sql tab) for step.
--
Hi,
PFA patch to fix the issue where it was not reporting error when it fails
to starts & went into infinite loop recursion of popup when task is deleted
from server(which is a transient issue).
RM#1679
*Note:* There is still TODO in this RM which I have added in code, for
which I'm not able find
Thanks, patch applied.
On Thu, Oct 20, 2016 at 4:40 PM, Surinder Kumar
wrote:
> Hi
>
> I am able to reproduce the issue by changing server username to "Суриндер"
> in russian locale.
> Steps:
> 1) Rename server username to "Суриндер" by editing server properties.
> 2) Double click on sever. Enter
Handle non-ascii responses from the server when connecting. Fixes #1822
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da3a37ab1974b8c862bba86a45a8463527d21c7c
Author: Surinder Kumar
Modified Files
--
web/pgadmin/browser/server_gr
Thanks, patch applied.
On Thu, Oct 20, 2016 at 1:37 PM, Surinder Kumar
wrote:
> Hi,
>
> When a File Manager is closed by clicking cancel button. Its dom element not
> destroyed.. So on traversing into directories, when it tries to get
> currently selected file type, it looks into the dom element
Ensure the File Manager honours the file type while traversing the directories.
Fixes #1858
When a File Manager is closed by clicking cancel button. Its dom element not
destroyed.. So on traversing into directories, when it tries to get currently
selected file type, it looks into the dom elemen
Hi
While editing the package properties, if pkg body is empty, It should drop
the package. but it wasn't generating drop package query.
Please find attached patch and review.
Thanks,
Surinder Kumar
RM1867.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hacke
Hi,
On Fri, Oct 21, 2016 at 5:03 PM, Dave Page wrote:
> Hi
>
> On Fri, Oct 21, 2016 at 12:32 PM, Neel Patel
> wrote:
> > Hi,
> >
> >
> > On Fri, Oct 21, 2016 at 4:48 PM, Dave Page wrote:
> >>
> >> Hi
> >>
> >> There are still issues I'm afraid:
> >>
> >> - When execution stops, we seem to kee
Thanks, patch applied.
On Thu, Oct 20, 2016 at 11:39 AM, Surinder Kumar
wrote:
> Hi,
>
> Code to parse security privileges was missing. So, its sql wasn't displayed.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-h
Show security labels in the reverse engineered SQL for domains. Fixes #1574
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=406dab069dfff14591a6ace8e6e36a3243f6fea0
Author: Surinder Kumar
Modified Files
--
.../server_groups/servers
Thanks, patch applied.
On Thu, Oct 20, 2016 at 10:37 AM, Surinder Kumar
wrote:
> Hi
>
> Issues fixed:
>
> 1) In Python 3, parameter "cmp" is removed from sorted method. So File
> Manager won't open.
> As we are sorting data on JS side using Natural sort, so on server side
> sorting is not require
Fix the file manager when used under Python 3. Fixes #1872
Issues fixed:
1) In Python 3, parameter "cmp" is removed from sorted method. So File Manager
won't open.
As we are sorting data on JS side using Natural sort, so on server side sorting
is not required.
2) Improvement in Exception handl
Don't allow setting of security labels on edbspl stored procedures (by
correctly checking the node type). Fixes #1576
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d29ccea2997d2cf6c83aab46acc0871f2bda57b5
Author: Murtuza Zabuawala
Modified
Thanks, applied.
On Thu, Oct 20, 2016 at 10:30 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA minor patch to fix the issue where behaviour of security label control
> was different when in CREATE mode & in EDIT mode.
> RM#1576
>
> issue:
> Corrected the condition for node type checking.
>
> --
> Rega
Hi
On Fri, Oct 21, 2016 at 12:32 PM, Neel Patel
wrote:
> Hi,
>
>
> On Fri, Oct 21, 2016 at 4:48 PM, Dave Page wrote:
>>
>> Hi
>>
>> There are still issues I'm afraid:
>>
>> - When execution stops, we seem to keep polling for more results
>> indefinitely.
>
> Do you mean after completion of first
Hi,
On Fri, Oct 21, 2016 at 4:48 PM, Dave Page wrote:
> Hi
>
> There are still issues I'm afraid:
>
> - When execution stops, we seem to keep polling for more results
> indefinitely.
>
Do you mean after completion of first successful debugging ?
If yes, we are polling because user can start sam
Resolve a PG 9.6 compatibility issue in the regression test for Languages.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1908e86d223b27e2e40ca128432a08589d082a0e
Author: Navnath Gadakh
Modified Files
--
.../servers/databases/lang
Thanks, applied.
On Thu, Oct 20, 2016 at 10:09 AM, Navnath Gadakh
wrote:
> Hi Dave,
>Please find revised patch for languages API test cases. Resolved some
> PG9.6 compatibility issues.
>
> Thanks.
>
> On Tue, Oct 18, 2016 at 7:08 PM, Dave Page
> wrote:
>>
>> Thanks, applied.
>>
>> On Tue
Hi
There are still issues I'm afraid:
- When execution stops, we seem to keep polling for more results indefinitely.
- When executing for a second time, the messages tab isn't cleared,
and new messages don't seem to be appended to it either. I would
expect the tab to be cleared.
On Thu, Oct 20,
Thanks, applied (and I dealt with the RM).
On Thu, Oct 20, 2016 at 7:58 AM, Surinder Kumar
wrote:
> Hi,
>
> While fixing RM1840, I found when we add new index, it doesn't add under
> right parent. i.e. columns collection. because wrong parent is given in
> response.
> I also verified other nodes.
Add new indexes to the correct parent on the treeview. Fixes #1880
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48ee8490f04cbe397d5f010481819d2297e5fa2b
Author: Surinder Kumar
Modified Files
--
.../server_groups/servers/database
Thanks, applied.
On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar
wrote:
> Hi,
>
> The options like "sort" and "nulls" must be conditional. i.e. include only
> when access method type is other than "gist" or "gin".
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
Don't specify ASC/DESC options for index types that don't support them. Fixes
#1840
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06039320b941d3d98f1ab044320ba177e47d0f9c
Author: Surinder Kumar
Modified Files
--
.../schemas/tabl
Properly generate exclusion constraint SQL. Fixes #1861
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6874a1a2471e357d21276c432a6a69948650455f
Author: Harshal Dhumal
Modified Files
--
.../schemas/tables/constraints/exclusion_cons
Thanks, applied.
On Thu, Oct 20, 2016 at 7:28 AM, Harshal Dhumal
wrote:
> Hi,
>
> PFA minor patch for RM1861.
>
> Issue fixed: SQL not generated for exclusion constraint on table
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise Postg
Ensure the grant wizard works with objects with special characters in the name.
Fixes #1599
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9155c2111f3f276614987f55e083da63239855d6
Author: Surinder Kumar
Modified Files
--
web/pgad
Thanks, applied.
On Thu, Oct 20, 2016 at 6:40 AM, Surinder Kumar
wrote:
> Hi,
>
> Issue:
> The schema name was passed into the template files to get schema name in
> response which doesn't escape special characters.
>
> Now schema is fetched using a JOIN statement on needed tables.
>
> Please fin
Hi,
Please ignore this patch as I haven't fixed same issue for schedule. Also
there is issue "malformed array literal" when we try to save schedule.
I'll be sending updated patch.
Thanks Harshal,
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enter
Hi,
PFA attached patch for pgagent issue RM1878
issue fixed: ProgrammingError: can't adapt type 'Undefined'
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/s
Hi,
Please find the patch to fix RM 1887: Preferences values ate not stored
properly.
Thanks,
Khushboo
diff --git a/web/pgadmin/preferences/templates/preferences/preferences.js b/web/pgadmin/preferences/templates/preferences/preferences.js
index 09788fc..e02c926 100644
--- a/web/pgadmin/preferenc
55 matches
Mail list logo
