Re: [pgadmin-hackers] Content Security Policy

2017-01-09 Thread Dave Page
Hi On Tue, Jan 10, 2017 at 8:51 AM, Jonas Thelemann wrote: > Good day pgadmin-hackers, > > my name is Jonas Thelemann and I just joined this mailing list. It's my > first mailing list, so I try my best to not make any mistakes. > I joined because I want to contribute some small adjustments to pga

[pgadmin-hackers] Content Security Policy

2017-01-09 Thread Jonas Thelemann
Good day pgadmin-hackers, my name is Jonas Thelemann and I just joined this mailing list. It's my first mailing list, so I try my best to not make any mistakes. I joined because I want to contribute some small adjustments to pgadmin. More precisely to address CSP (Content Security Policy

[pgadmin-hackers] pgAdmin 4 commit: Fix copyright year on doc page. Fixes #2045

2017-01-09 Thread Dave Page
Fix copyright year on doc page. Fixes #2045 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe1d2f98050616c3be5d6a7c176e00510b0b2f2e Modified Files -- docs/en_US/coding_standards.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

2017-01-09 Thread Dave Page
Thanks - that works nicely, so patch applied. On Mon, Jan 9, 2017 at 3:42 PM, Surinder Kumar wrote: > Hi Dave, > > I just missed the code for swapping left and right values if order is > descending. It's fixed. > Please find attached patch and review. > > On Mon, Jan 9, 2017 at 9:05 AM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Fix sorting of numerics in the statistics grids. Fixe

2017-01-09 Thread Dave Page
Fix sorting of numerics in the statistics grids. Fixes #1938 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86f6857cb75c342972186255f19832f93f0a6c45 Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/backgrid/backgrid.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

2017-01-09 Thread Surinder Kumar
Hi Dave, I just missed the code for swapping left and right values if order is descending. It's fixed. Please find attached patch and review. On Mon, Jan 9, 2017 at 9:05 AM, Dave Page wrote: > Hi > > On Friday, January 6, 2017, Surinder Kumar com> wrote: > >> Hi, >> >> As the type of data we g

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-09 Thread Dave Page
Patch applied (once Murtuza showed me how to recreate the problem). Thanks! On Mon, Jan 9, 2017 at 2:42 PM, Dave Page wrote: > Hi > > On Mon, Jan 9, 2017 at 10:46 AM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> I followed, >> >> 1) First click on main properties panel. >> >> 2) Sample definiti

[pgadmin-hackers] pgAdmin 4 commit: Use the correct OID for retrieving properties of fres

2017-01-09 Thread Dave Page
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c19f93b3b4ff749da1f94e559910fa7bf9f389c Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-09 Thread Dave Page
Hi On Mon, Jan 9, 2017 at 10:46 AM, Murtuza Zabuawala wrote: > Hi Dave, > > I followed, > > 1) First click on main properties panel. > > 2) Sample definition, > > CREATE TABLE public.test_table > ( > id character varying(3) COLLATE pg_catalog."default" NOT NULL, > col1 bigint, > CONST