Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Fahar Abbas
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might be possible that you tested on Python 3+. Please confirm? On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > That's strange. > > I tested in Chrome, Need check in IE. > > Mean

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread George Gelashvili
Thanks for bringing that to our attention! Here's the latest patch On Fri, Jan 20, 2017 at 10:38 AM, Dave Page wrote: > On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili > wrote: > > > > Here is an updated patch which starts the server up when the test starts > and > > uses the values from co

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili wrote: > > Here is an updated patch which starts the server up when the test starts and > uses the values from config.py for server name etc. It still requires > installing chromedriver before running. Should we add something to the > readme abou

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
Hi On Thu, Jan 19, 2017 at 11:15 PM, George Gelashvili wrote: > Here's an updated patch which polls to wait for the app to start instead of > sleeping for 10 seconds. I see the browser opening now, and it immediately loads pgAdmin. Then, it prompts me for a reload whenever the test is run, which

Re: [pgadmin-hackers][Patch] Python 3 compatibility

2017-01-20 Thread Dave Page
Thanks, patch applied. On Thu, Jan 19, 2017 at 10:12 PM, George Gelashvili wrote: > Hello > > We stumbled on the following error when running tests off of master: > > Traceback (most recent call last): > File "web/regression/runtests.py", line 254, in > servers_info = test_utils.get_config

[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the regression tests

2017-01-20 Thread Dave Page
Python 3 fix for the regression tests Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d4cffc608c44a5574fbe433ab9fa1f9fbd58ed Author: George Gelashvili Modified Files -- web/regression/test_utils.py | 2 +- 1 file changed, 1 insert

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Murtuza Zabuawala
That's strange. I tested in Chrome, Need check in IE. Meanwhile can try with Chrome/Firefox? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas wrote: > Hi Murtaza, > > I just applied this patc

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-20 Thread Dave Page
FYI, I've reverted this patch for now, as I found it was causing other problems. On Fri, Jan 20, 2017 at 5:40 AM, Murtuza Zabuawala wrote: > Let me check > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Jan 20, 2017

[pgadmin-hackers] pgAdmin 4 commit: Revert "Handle comments on databases with datallowcon

2017-01-20 Thread Dave Page
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024" This reverts commit e431eb9d8ecc28572b39d26c9effcf66f70f6ae1. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac4178233b8772f964825f8c8e0c95e23feddcc1 Modifi

Re: [pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]

2017-01-20 Thread Dave Page
Thanks, applied. On Thu, Jan 19, 2017 at 6:41 AM, Harshal Dhumal wrote: > Hi, > > This patch includes following change: > Properly remove any event listeners added by subnode control. > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Properly remove any event listeners added by subnode

2017-01-20 Thread Dave Page
Properly remove any event listeners added by subnode control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=415119d5814054cdce6f16a9545ccd35c91270a7 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/backform.pgadmin.

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Fahar Abbas
Sure Will test this on Monday will be leaving in few minutes. Kind Regards, On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Fahar, > > Could you please test this updated patch? > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Murtuza Zabuawala
Hi Fahar, Could you please test this updated patch? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas wrote: > Thanks Dave. > > On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote: > >> Not surp

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-01-20 Thread Dave Page
On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM 2069 - Wrong tablespace > displayed in table properties. > > When the table is created without a tablespace, the "pg_default" tablespace > gets selected rather than the default tablespace