Hi,
PFA patch to fix the issue in test suite for template loader.
*Issue(Python3):*
murtuza@vm:~/pgadmin4/web/regression$ python3 runtests.py
pgAdmin 4 - Application Initialisation
==
The configuration database - '/../.pgadmin/test_pgadmin4.db' does not exist
Hi Dave,
PFA updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jan 30, 2017 at 8:07 PM, Dave Page wrote:
> Can you rebase this please?
>
> Thanks.
>
> On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zabuawala
> wrote:
> >
Here's the patch with one more fix -- cleaning up the connections that get
created in pgAdmin.
On Mon, Jan 30, 2017 at 2:28 PM, George Gelashvili
wrote:
> so, it sounds like you're saying our accaptable_test_db is unacceptable :-P
>
> here's a patch that takes an "--exclude" flag (see README) a
so, it sounds like you're saying our accaptable_test_db is unacceptable :-P
here's a patch that takes an "--exclude" flag (see README) and doesn't
create dbs that don't get cleaned up afterwards
On Fri, Jan 27, 2017 at 11:28 AM, Dave Page wrote:
> On Fri, Jan 27, 2017 at 4:11 PM, Dave Page wro
Thanks - committed!
On Mon, Jan 30, 2017 at 4:16 PM, Atira Odhner wrote:
> Whoops we accidentally left in hardcoded db config we used for running tests
> from our IDE.
>
> Here's a fixed patch.
>
> On Mon, Jan 30, 2017 at 6:45 AM, Dave Page wrote:
>>
>> Hi
>>
>> On Fri, Jan 27, 2017 at 5:18 PM,
Bypass recovery checks with older servers. This is required for Greenplum which
is based on PG 8.3 at present.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6b67fc66a40d477be06ac743af63c71aeb952fd
Author: Atira Odhner
Modified Files
--
Whoops we accidentally left in hardcoded db config we used for running
tests from our IDE.
Here's a fixed patch.
On Mon, Jan 30, 2017 at 6:45 AM, Dave Page wrote:
> Hi
>
> On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili
> wrote:
> > This bypasses checking if the DB is in recovery for versio
Awesome. Thanks folks!
On Mon, Jan 30, 2017 at 6:35 AM, Fahar Abbas
wrote:
> Sure Dave.
>
> On Mon, Jan 30, 2017 at 4:33 PM, Dave Page wrote:
>
>> Thanks Murtuza. Fixed and committed. George; I stuck with the original
>> filename for the loader - I couldn't come up with anything better.
>>
>> F
For the record, the author was Neel, not Murtuza as I put in the commit message.
Sorry Neel!
On Mon, Jan 30, 2017 at 1:06 PM, Dave Page wrote:
> Thanks, patch applied.
>
> On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel
> wrote:
>> Hi,
>>
>> Please find attached patch file for the fix of RM#2015.
Can you rebase this please?
Thanks.
On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> Please find a patch to fix the issue in timestamp & time type when user
> tries to provide scale/lengt to them.
> I did some refactoring in code to handle it at one place, affected nodes
> wou
Hi
On Mon, Jan 30, 2017 at 5:31 AM, Murtuza Zabuawala
wrote:
> Hi Dave,
>
> Please find updated patch, Tested against maintenance database as well.
I can change parameters on the maintenance DB now, but it still
crashes if I try to change the comment. Both operations on other
databases seem to w
Ensure dialogues cannot be moved under the navbar. Fixes #2047
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e546208fa4ac91bbe1759e3981522158ee703e
Author: Surinder Kumar
Modified Files
--
web/pgadmin/static/css/overrides.css |
Thanks, patch applied.
On Mon, Jan 30, 2017 at 5:09 AM, Surinder Kumar
wrote:
> Hi Dave,
>
> Solution:
> Setting z-index: 10 of .pg-navbar menu class to allow panel float over the
> menu bar.
>
> Please find attached patch.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing
Thanks, patch applied.
On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel wrote:
> Hi,
>
> Please find attached patch file for the fix of RM#2015.
>
> Below additional issues are fixed along with description provided in RM.
>
> When user update any of the parameter - trigger gets disappear from browser
Resolve various trigger issues. Fixes #2015
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser
tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl"
trigge
Hi
Can you rebase this please?
Thanks.
On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Jan 20, 2017 at 5:31 PM, Dave Page wrote:
>>
>> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
>> wrote:
>> > Hi
On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar
wrote:
> Hi Dave,
>
> Please find updated patch.
>
> On Mon, Jan 16, 2017 at 10:01 PM, Dave Page wrote:
>>
>> Hi
>>
>> On Fri, Jan 13, 2017 at 9:24 AM, Surinder Kumar
>> wrote:
>> > Hi
>> >
>> > Please find attached patch and review.
>> >
>> > On
Hi
On Fri, Jan 27, 2017 at 10:30 AM, Neel Patel
wrote:
> Hi,
>
> Please find attached patch file for the fix of RM#2110.
>
> When user try to save the file through fileManager then it gives error
> saying "Invalid Path" while getting folder details from python server. This
> issue is only reprodu
Hi
On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili
wrote:
> This bypasses checking if the DB is in recovery for versions of postgres
> that don't support pg_is_in_recovery() (anything pre-9.0, such as
> Greenplum).
>
> This patch depends on the "Refactor sql template version picking" patch.
T
Sure Dave.
On Mon, Jan 30, 2017 at 4:33 PM, Dave Page wrote:
> Thanks Murtuza. Fixed and committed. George; I stuck with the original
> filename for the loader - I couldn't come up with anything better.
>
> Fahar; This is a fairly major change. Please test thoroughly on
> different versions of P
Create a template loader for SQL templates.
This will automatically find the correct version of a template for the server
version, and allows us to remove templates that were previously duplicated for
different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from ED
Thanks Murtuza. Fixed and committed. George; I stuck with the original
filename for the loader - I couldn't come up with anything better.
Fahar; This is a fairly major change. Please test thoroughly on
different versions of PG and EPAS to ensure that the correct SQL
templates are being used. They'
On Sat, Jan 28, 2017 at 1:00 AM, Jan Alexander Steffens
wrote:
> On Fri, Jan 27, 2017 at 5:56 PM Dave Page wrote:
>>
>> On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens
>> wrote:
>> > I did mean Py_SetPath, not PySys_SetPath.
>>
>> Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so
On Fri, Jan 27, 2017 at 5:56 PM Dave Page wrote:
> On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens
> wrote:
> > I did mean Py_SetPath, not PySys_SetPath.
>
> Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so I assumed it
> was a typo.
>
> > Unfortunately, after checking
> > again
24 matches
Mail list logo
