[pgadmin-hackers] SlickGrid

2017-02-13 Thread Sarah McAlear
Hi Hackers, We saw a story about transferring query results to SlickGrid on Redmine ( https://redmine.postgresql.org/issues/2036). We are considering more selection options (in addition to by-row) within the results display, which got us wondering about the use of SlickGrid. It appears that Slick

[pgadmin-hackers] Autoformatting

2017-02-13 Thread Raffi Holzer
Hi Hackers, We are looking into auto formatting SQL text in the SQL editor. However, some users have expressed that this can be done in different ways. Are there preferences in this community fo rhow autoformatting should be done? -- Raffi Holzer Product Manager Pivotal Labs

[pgadmin-hackers][patch] Fixes QT build when not signing

2017-02-13 Thread George Gelashvili
Hello Hackers! We were building the QT app locally with QTDIR, PGDIR, PYTHON_HOME, and PYTHON_VERSION set, and by running: make appbundle We were seeing the runtime error: > Could not find QtWebEngineProcess > Abort trap: 6 after a successful python server start. We found that the setup before

[pgadmin-hackers] Feature Suggestions

2017-02-13 Thread Raffi Holzer
Hi everyone, For those who don't know, Pivotal Labs is working with Greenplum to make pgAdmin 4 compatible with Greenplum. In addition to that, we have also been conducting user research and figuring out ways in which the user experience of pgAdmin might be improved. Below are a few of the ideas w

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-02-13 Thread Dave Page
Hi, I've been playing with this for the last couple of hours, and I just can't get it to work reliably; - A good percentage of the time the browser opens with a URL of "data:," and does nothing more. This appears to happen if tests fail, which still leaves server processes running in the backgrou

[pgadmin-hackers] pgAdmin 4 commit: Add comment to note command line qmake usage.

2017-02-13 Thread Dave Page
Add comment to note command line qmake usage. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40f2520fa6af69fd9d87278f427e3484afd03a4a Modified Files -- runtime/pgAdmin4.pro | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgad

[pgadmin-hackers] pgAdmin 4 commit: Allow the Python interpreter to be overridden on the

2017-02-13 Thread Dave Page
Allow the Python interpreter to be overridden on the build command line. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e103b2b31576cc930aa44d3cc636fef32f1e1e85 Modified Files -- docs/en_US/Makefile.sphinx | 3 ++- 1 file changed, 2

[pgadmin-hackers] pgAdmin 4 commit: Update the runtime build to allow users to force buil

2017-02-13 Thread Dave Page
Update the runtime build to allow users to force building with QtWebKit in Qt5, instead of QtWebEngine. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88aac7a4c956f1803d079ade5ab4b6a92f9cb7b3 Modified Files -- runtime/BrowserWindo

[pgadmin-hackers] pgAdmin 4 commit: Another Python 3.x compatibility fix.

2017-02-13 Thread Dave Page
Another Python 3.x compatibility fix. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae10da4371625a24b7a37101eda63c428757be12 Modified Files -- .../schemas/tables/templates/table/sql/tests/test_tables_node.py | 5 - 1 file c

[pgadmin-hackers] pgAdmin 4 commit: Fix Python 2.6 compatibility.

2017-02-13 Thread Dave Page
Fix Python 2.6 compatibility. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56bd1f6c050cd0414cd61abc6909456ae1301573 Modified Files -- web/regression/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent vi

[pgadmin-hackers] pgAdmin 4 commit: Fix Python 3 compatibility.

2017-02-13 Thread Dave Page
Fix Python 3 compatibility. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f181d2babf908d3963e8b012842287ee6720b7 Modified Files -- .../schemas/tables/templates/table/sql/tests/test_tables_node.py| 2 +- 1 file changed, 1

[pgadmin-hackers] pgAdmin 4 commit: Make syntax highlighting more visible by making keywo

2017-02-13 Thread Dave Page
Make syntax highlighting more visible by making keywords and numbers bolder. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1340c1c2ee3503bedd0dd1d89484afc8216d396b Author: Atira Odhner Modified Files -- web/pgadmin/static/css/ove

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

2017-02-13 Thread Dave Page
Thanks, patch applied. On Thu, Feb 9, 2017 at 7:03 PM, Atira Odhner wrote: > Here's the updated patch > > On Thu, Feb 9, 2017 at 8:52 AM, Atira Odhner wrote: >> >> Good point! I guess I was asleep at the wheel on this one. I didn't notice >> it was a library. >> >> >> On Thu, Feb 9, 2017, 4:37 A

[pgadmin-hackers] pgAdmin 4 commit: Basic support for viewing tables in Greenplum. Patch

2017-02-13 Thread Dave Page
Basic support for viewing tables in Greenplum. Patch from George & Tira @ Pivotal. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec9e8b79a3f8bd8ee6bcb685247a54efaa80c5fa Author: Atira Odhner Modified Files -- .../tables/template

Re: [pgadmin-hackers][patch] We can see tables in Greenplum!

2017-02-13 Thread Dave Page
Thanks, applied! On Thu, Feb 9, 2017 at 3:57 PM, Atira Odhner wrote: > Great! Here is an updated patch set. > > -Tira & George > > On Thu, Feb 9, 2017 at 12:33 AM, Murtuza Zabuawala > wrote: >> >> Hello, >> >> Regarding test output, >> >> >> Comment Style-1: If we comment like >> >> """Test Cas