[pgadmin-hackers] pgAdmin 4 commit: Correct node labels in Preferences for EDB functions

2017-02-16 Thread Dave Page
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbaad81f00167c715048f55428e7d7915db9314e Author: Surinder Kumar Modified Files -- .../schemas/packages

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixes RM2126 - Duplicate values displayed for functions and procedures in Preferences

2017-02-16 Thread Dave Page
Thanks, patch applied. On Fri, Feb 10, 2017 at 9:33 AM, Surinder Kumar wrote: > Hi > > Issue: The function and procedure nodes displayed under schema nodes and > packages node, so both were sharing same name. > > Solution: > Overrides the register_preferences method for EdbFuncModule and > EdbPro

[pgadmin-hackers] pgAdmin 4 commit: Fix exclusion constraint reverse engineered SQL. Fixe

2017-02-16 Thread Dave Page
Fix exclusion constraint reverse engineered SQL. Fixes #2115 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=833629d438d22390e12a77b135ba09684810a82d Author: Surinder Kumar Modified Files -- .../schemas/tables/templates/table/sql/m

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2115 - Wrong SQL displayed for exclusion constraints with gist method

2017-02-16 Thread Dave Page
Thanks, patch applied. On Fri, Feb 10, 2017 at 1:51 PM, Surinder Kumar wrote: > Hi > > The Macro template was referring to the old code that's why it generates > wrong sql. > Now the changes made in RM1840 are incorporated into macro template as well. > > Please find attached patch. > > Thanks >

[pgadmin-hackers] pgAdmin 4 commit: Various encoding fixes. Fixes #2160

2017-02-16 Thread Dave Page
Various encoding fixes. Fixes #2160 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ad1316990cf54da665546ad2dff367557b98262 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/__init__.py | 12 +

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Handling of non-ascii with Python2.7

2017-02-16 Thread Dave Page
Thanks, patch applied. On Mon, Feb 13, 2017 at 6:42 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user enters non ascii username/password > (invalid credentials) while creating new server and it throws error. > RM#2160 > > This patch also includes some other minor fixes

Re: [pgadmin-hackers][patch] Fixes QT build when not signing

2017-02-16 Thread Dave Page
Thanks - patch applied with minor tweaks to make it fail much earlier if framework.conf isn't present, and to update to current versions of Python/Qt. On Tue, Feb 14, 2017 at 3:18 PM, Atira Odhner wrote: > Sure, sounds good. We accidentally had a stray chmod hanging out, which we > removed. We al

[pgadmin-hackers] pgAdmin 4 commit: Ensure the Mac Appbundle builds correctly both with a

2017-02-16 Thread Dave Page
Ensure the Mac Appbundle builds correctly both with and without code signing. Correct current versions of Python/Qt while we're passing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3041f1113ef492d5c08b241b2fb162d47d5abb1 Author: Atira Odhn

[pgadmin-hackers] pgAdmin 4 commit: Qt 5.8 seems to generate an additional header we shou

2017-02-16 Thread Dave Page
Qt 5.8 seems to generate an additional header we should ignore. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9ddd64a8b84b4c00cdb76ccfb99b6d6a2273edf Modified Files -- runtime/.gitignore | 1 + 1 file changed, 1 insertion(+) --

[pgadmin-hackers] pgAdmin 4 commit: Add a makefile target to run the regression tests.

2017-02-16 Thread Dave Page
Add a makefile target to run the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05d2373c9a5373e051fe983607a5bad1682dd97a Modified Files -- Makefile | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgadmin-ha

[pgadmin-hackers] pgAdmin 4 commit: Tidy up the regression test output a little.

2017-02-16 Thread Dave Page
Tidy up the regression test output a little. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03f292ce5143a64e76e1c335d800753bee7f888d Modified Files -- .../schemas/fts_configurations/tests/test_fts_configuration_get.py | 3 +-- .../

Re: [pgadmin-hackers][patch] Fixes QT build when not signing

2017-02-16 Thread Atira Odhner
Thanks! On Thu, Feb 16, 2017, 6:26 AM Dave Page wrote: > Thanks - patch applied with minor tweaks to make it fail much earlier > if framework.conf isn't present, and to update to current versions of > Python/Qt. > > On Tue, Feb 14, 2017 at 3:18 PM, Atira Odhner wrote: > > Sure, sounds good. We

Re: [pgadmin-hackers] connection error

2017-02-16 Thread George Gelashvili
nd here's a patch On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili wrote: > Hi Hackers! > > Our tests found a bug with the current version of master, that was > introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262. > It is throwing an error when the server starts up and retur

Re: [pgadmin-hackers] connection error

2017-02-16 Thread Dave Page
Thanks, applied. On Thu, Feb 16, 2017 at 4:31 PM, George Gelashvili wrote: > nd here's a patch > > On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili > wrote: >> >> Hi Hackers! >> >> Our tests found a bug with the current version of master, that was >> introduced by the commit 9ad1316990cf5

[pgadmin-hackers] pgAdmin 4 commit: Don't try to decode connection error strings that are

2017-02-16 Thread Dave Page
Don't try to decode connection error strings that are null. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03a161cc0a48f5dbc0d76c7e2a5a75373c292b30 Author: George Gelashvili Modified Files -- web/pgadmin/browser/server_groups/serv

[pgadmin-hackers] Results screen/Data output work

2017-02-16 Thread Robert Eckhardt
All, I was looking at the mailing list this morning and realized that we had been remiss in discussing what we (Pivotal) are working on. The primary chunk of work we are doing it to get The data output window to behave similarly to how it behaves in pgAdmin3. Specifically we want users to be able