[pgadmin-hackers] pgAdmin 4 commit: Add selenium to the Pip requirements for the automate

2017-02-24 Thread Dave Page
Add selenium to the Pip requirements for the automated tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f69916372239491767dc58040d65d069704f201 Modified Files -- requirements_py2.txt | 1 + requirements_py3.txt | 1 + 2 files c

Re: [pgadmin-hackers] [Patch] Organize Vendorized Assets

2017-02-24 Thread Dave Page
Thanks, patch applied! On Fri, Feb 24, 2017 at 4:02 PM, Sarah McAlear wrote: > Here's our new patch. > If it looks a lot like the last one, that's because we actually just didn't > clear our cache last night and were seeing in-flight css changes. End-of-day > hallucinations :-p > > Tira & Sarah >

[pgadmin-hackers] pgAdmin 4 commit: Move 3rd party client code into vendor/ directories f

2017-02-24 Thread Dave Page
Move 3rd party client code into vendor/ directories for ease of maintenance. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0a31e55aeadf96cfe3c33c2ebb17de687c59a68 Author: Sarah McAlear Modified Files -- web/pgadmin/browser/__ini

Re: [pgadmin-hackers] [PlumAdmin][Weekly Design Update]

2017-02-24 Thread Adam Brusselback
I just wanted to chime in because both of these features are things I used heavily in previous jobs with different DBMS. > History : Enabling users to be able to see their full queries within the > history panel > > What we know > >- > >Users want to reuse queries when they are iterating u

[pgadmin-hackers] pgAdmin 4 commit: Ensure primary key column names are quoted in View Da

2017-02-24 Thread Dave Page
Ensure primary key column names are quoted in View Data mode of the Query Tool. Fixes #2208 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b19081421b980fbfe8c125201ea7f55e7d6a9c48 Modified Files -- .../tools/sqleditor/templates/sq

[pgadmin-hackers] pgAdmin 4 commit: Fix display of boolean nulls in the query tool. Fixes

2017-02-24 Thread Dave Page
Fix display of boolean nulls in the query tool. Fixes #2205 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40ff651ef36ff0817ee382947ae76482d732160b Author: Surinder Kumar Modified Files -- .../static/js/slickgrid/slick.pgadmin.edi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2205 - Indeterminate state for [null] values in boolean type cell doesn't show up

2017-02-24 Thread Dave Page
Thanks, patch applied. On Fri, Feb 24, 2017 at 1:16 PM, Surinder Kumar wrote: > Hi > > While looking into issue 2199, I found while performing select query in > query tool, the checkbox indeterminate state doesn't show up for [null] > value on double click. > > Please find attached patch and revi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed

2017-02-24 Thread Dave Page
Thanks, patch applied. On Fri, Feb 24, 2017 at 12:35 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch. > > Changes: > > 1) Add typecaster for numeric and double precision. > > 2) As numeric data is typecasted into string type, we need not to do > parseInt value in javascript. >

[pgadmin-hackers] pgAdmin 4 commit: Fix display of long integers and decimals. Fixes #203

2017-02-24 Thread Dave Page
Fix display of long integers and decimals. Fixes #2039. Fixes #2119. Fixes #2154 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88cae263b2e35954bc3a5358b85c279d4b891818 Author: Surinder Kumar Modified Files -- .../static/js/slickg

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2205 - Indeterminate state for [null] values in boolean type cell doesn't show up

2017-02-24 Thread Surinder Kumar
Hi While looking into issue 2199 , I found while performing select query in query tool, the checkbox indeterminate state doesn't show up for [null] value on double click. Please find attached patch and review. Thanks Surinder Kumar RM2205.patch Descr

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Expanded columns under table are in the wrong order

2017-02-24 Thread Dave Page
Thanks, patch applied! On Fri, Feb 24, 2017 at 11:53 AM, Surinder Kumar wrote: > Hi, > > The sorting for the object types 'column' and 'catalog_object_column' is not > required as their columns need to display as per their order of creation. > For other nodes sorting will work. > > Please find at

[pgadmin-hackers] pgAdmin 4 commit: Ensure we never sort columns on the treeview. Fixes #

2017-02-24 Thread Dave Page
Ensure we never sort columns on the treeview. Fixes #2185 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0f2aab001c24bcbbc96bd0d1df00989d0e36012 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/templates/browser/js/br

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix #2198 - Cannot create function/procedure with arguments

2017-02-24 Thread Dave Page
Thanks, patch applied. On Fri, Feb 24, 2017 at 11:45 AM, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of RM #2198 - Can not create > function/procedure with arguments. > > Do review it and let me know for any comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmi

[pgadmin-hackers] pgAdmin 4 commit: Fix function arguments when generating create SQL. Fi

2017-02-24 Thread Dave Page
Fix function arguments when generating create SQL. Fixes #2198 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b961b2d92983a3bebbf613c1d8cc2cc512934409 Author: Harshal Dhumal Modified Files -- .../schemas/functions/templates/functi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed

2017-02-24 Thread Surinder Kumar
Hi Dave, Please find updated patch. *Changes:* 1) Add typecaster for numeric and double precision. 2) As numeric data is typecasted into string type, we need not to do parseInt value in javascript. 3) Remove redundant code for registering new types. On Mon, Jan 9, 2017 at 9:11 AM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2

2017-02-24 Thread Dave Page
Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2089 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ba9b7db4367b519339b5ab4504b58623f912cfe Author: Khushboo Vashi Modified Files -- .../databases/schemas/functions/__init__.py

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-24 Thread Dave Page
Thanks, committed! On Fri, Feb 24, 2017 at 6:48 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Feb 15, 2017 at 8:57 PM, Dave Page > wrote: >> >> Hi >> >> On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi >> wrote: >>> >>> Hi, >>> >>>

[pgadmin-hackers] [pgAdmin4][Patch]: Expanded columns under table are in the wrong order

2017-02-24 Thread Surinder Kumar
Hi, The sorting for the object types 'column' and 'catalog_object_column' is not required as their columns need to display as per their order of creation. For other nodes sorting will work. Please find attached patch and review. Thanks, Surinder Kumar RM_2185.patch Description: Binary data --

[pgadmin-hackers] [pgAdmin4][Patch]: Fix #2198 - Cannot create function/procedure with arguments

2017-02-24 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM #2198 - Can not create function/procedure with arguments. Do review it and let me know for any comments. Thanks, Neel Patel RM_2198.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) T

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

2017-02-24 Thread Dave Page
Hi On Thu, Feb 23, 2017 at 10:34 AM, Harshal Dhumal wrote: > Hi, > > Please find updated patch for unicode issue on python 2.7 > > I have tested with below scenarios for all nodes (except database and > Login/Group Role as these are stored in shared catalogs as for now we are > not considering en

Re: [pgadmin-hackers] pgAdmin4 mirror issues [pgAdmin4]

2017-02-24 Thread Dave Page
Thanks, all applied. On Thu, Feb 23, 2017 at 12:00 PM, Murtuza Zabuawala wrote: > RM created, > > https://redmine.postgresql.org/issues/2200 > https://redmine.postgresql.org/issues/2201 > https://redmine.postgresql.org/issues/2202 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www

[pgadmin-hackers] pgAdmin 4 commit: Fix casting issue with dependents queries.

2017-02-24 Thread Dave Page
Fix casting issue with dependents queries. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c09b57a1a368259ffbfa51226f6a9c92a921118 Author: Harshal Dhumal Modified Files -- .../server_groups/servers/templates/depends/sql/default/de

[pgadmin-hackers] pgAdmin 4 commit: Fix renaming of check constraints when the table name

2017-02-24 Thread Dave Page
Fix renaming of check constraints when the table name is changed at the same time. Fixes #2201 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=685b1ea12fd9ce7abb0bfcfb9e851d561a330760 Author: Harshal Dhumal Modified Files -- .../t

[pgadmin-hackers] pgAdmin 4 commit: Properly handle event trigger functions in different

2017-02-24 Thread Dave Page
Properly handle event trigger functions in different schemas. Fixes #2200 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5e33fe4e95e57269e4f27a08d29a50282f20d219 Author: Harshal Dhumal Modified Files -- .../templates/event_trigger