Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi, Please find updated patch for encoding issue. Apart from encoding issue I have also fixed issue of wrong data was show in query editor for string types and array string types for databases with encoding other than utf-8. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://

[pgadmin-hackers][patch] Syntax Highlighting Color Change RM #2215

Hi Hackers, Here is a small css change to make the syntax highlighting more visible color-wise. https://redmine.postgresql.org/issues/2215 > As a query writer I want to be able to see the syntax highlighted colors > even if I am colorblind so that I can easily make sense of the code I am > writi

Re: [pgadmin-hackers] Feature test issues

The team here at Pivotal is doing TDD already. Running so many configurations sounds like it belongs in a CI not in a TDD cycle. I want to make sure we are making the most effective technical investment that we can. My thought process is generally: * Are we feeling pain from this right now? (is it

Re: [pgadmin-hackers] Feature test issues

On Sun, Feb 26, 2017 at 8:39 AM, Dave Page wrote: > > On the plus side, test runs are now green across the board with > feature tests enabled, except for Python 2.6 :-) I say that, however... - I've now seen the same error with Python 3.6 as with 2.6, yet whilst it's consistent on 2.6, it's inte

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Hi On Mon, Feb 27, 2017 at 10:25 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to reduce the size of query result set by converting it into 2D > array result set. > RM#2036 > RM#2038 > > Additionally, > 1) I had to change some logic in Debugger module to handle 2D array result > set from asyn

[pgadmin-hackers] pgAdmin 4 commit: Consistent dialogue configuration

Consistent dialogue configuration Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5dc2326e9da424ccd642661495f1c16b635e5c86 Modified Files -- web/pgadmin/about/templates/about/about.js | 8 +++- 1 file changed, 7 insertions(+), 1

Re: [pgadmin-hackers] PATCH: Javascript addons/modules specific to pgAdmin 4

Thanks, applied. On Mon, Feb 27, 2017 at 11:53 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave, > > We've added few add-ons for CodeMirror, and slickgrid to be used by > pgAdmin 4. > Moved them back to 'static/js' directory from 'vendor' directory. > > -- > > Thanks & Regards,

[pgadmin-hackers] pgAdmin 4 commit: Move pgadmin plugins for codemirror back out of the v

Move pgadmin plugins for codemirror back out of the vendor area. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3638d633308439defbf8fba0592ac028aef8a30f Modified Files -- .../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 83 ++

[pgadmin-hackers] pgAdmin 4 commit: Fix CSS path. Fixes #2213

Fix CSS path. Fixes #2213 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=206b9255c5c4875dd48d058170db17e3ba36a13a Modified Files -- web/pgadmin/browser/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[pgadmin-hackers] PATCH: Javascript addons/modules specific to pgAdmin 4

Hi Dave, We've added few add-ons for CodeMirror, and slickgrid to be used by pgAdmin 4. Moved them back to 'static/js' directory from 'vendor' directory. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

Hi On Fri, Feb 24, 2017 at 7:14 PM, Atira Odhner wrote: > Hi hackers, > > We made some changes to start to make the javascript testable: > > - Move clipboard copying into its own file so we can test the > interaction with it when we start adding column selection > - Create a transla

[pgadmin-hackers] pgAdmin 4 commit: Simplify runtime startup polling, and increase retrie

Simplify runtime startup polling, and increase retries to 30. Ensure the splash screen is hidden before showing errors. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a7a82b4e968e28b83414d858efda8856201a40b Modified Files -- runt

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

++ Forgot to add one more :-) Also fix button inconstancy issue with pgAdmin4 About dialog (changes included in RM_2036.patch file). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 3:55 PM, Murtuza Zabuawala < murt

[pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Hi, PFA patch to reduce the size of query result set by converting it into 2D array result set. RM#2036 RM#2038 Additionally, 1) I had to change some logic in Debugger module to handle 2D array result set from async query (changes included in patch). 2) While testing I also found one issue wher

Re: [pgadmin-hackers] Feature test issues

On Mon, Feb 27, 2017 at 4:02 AM, Atira Odhner wrote: > Cool, we already have a task about proper teardown and a couple other things > in our backlog. we'll probably get to it in the next day or so. I'll take a > look at the other stuff. Thanks. > Also, regarding speed, even without the app start