[pgadmin-hackers][patch] Shows titles for disabled buttons on hover

2017-03-03 Thread Sarah McAlear
Hi Hackers, This patch enables hovering over disabled buttons to see their functionality. Thanks, Joao and Sarah 0001-Ensure-title-is-displayed-in-disabled-buttons.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers][discussion] Javascript package management (Yarn?)

2017-03-03 Thread Atira Odhner
> > - Whilst it cuts down on the bloat caused by unnecessary files in the > source tree, it does nothing to prevent the problem in the packages we > distribute to users (installers, app bundles, RPMs etc) which are the > primary concern in this are (I can live with bloat in the source tree, > but m

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Atira Odhner
Hey Dave, We're not able to reproduce that issue over here. Any chance you could debug it? Thanks, Tira On Fri, Mar 3, 2017 at 10:20 AM, Dave Page wrote: > On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote: > > Hi > > > > On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira > > wrote

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Dave Page
On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote: > Hi > > On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira > wrote: >> Hi, >> We adjusted the patches to correct the issues that you mentioned >> >> Improves screenshots and reduces test flakiness > > Hmm, was that the 0.5 second sleep

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-03 Thread Dave Page
Hi On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira wrote: > Hi, > We adjusted the patches to correct the issues that you mentioned > > Improves screenshots and reduces test flakiness Hmm, was that the 0.5 second sleep? I hate doing that, but sometimes it's the only way that doesn'

[pgadmin-hackers] [PATCH][pgAdmin4] To fix the issue in server-group deletion

2017-03-03 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in ServerGroup node, where servers associated to server group were not deleted when user deletes server-group. RM#2212 Also fixed the gif file url in file manager(changes included in the patch). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.co

Re: [pgadmin-hackers][discussion] Javascript package management (Yarn?)

2017-03-03 Thread Dave Page
Hi On Thu, Mar 2, 2017 at 6:11 PM, Atira Odhner wrote: > Hi Hackers, > > We've had some discussion on another thread in the past couple weeks about > pulling in npm to manage our javascript dependencies. > > I wanted to pull this discussion back up to the top level and hopefully get > some more i

[pgadmin-hackers] [PATCH][pgAdmin4] To show indeterminate state for [null] value for boolean

2017-03-03 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where it was not showing indeterminate state for [null] value for boolean when we enter value in new row. RM#2153 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2153.patch Description: Binary data

Re: [pgadmin-hackers] Feature test issues

2017-03-03 Thread Dave Page
On Thu, Mar 2, 2017 at 2:36 PM, Atira Odhner wrote: > Just to clarify the change we made in this regard --- we use the 'reset > layout' link in the header between tests, but it essentially still does a > page load and doesn't save us time. If we were to do an actual page load we > would run into i

[pgadmin-hackers] [pgAdmin4][patch]: RM #1796 - Added 'Run now' option to run pgAgent Job

2017-03-03 Thread Neel Patel
Hi, Please find attached patch file to fix for RM #1796 - Added "Run now" option to run the pgAgent job. Do review it and let me know for comments. Thanks, Neel Patel RM_1796.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chan