[pgadmin-hackers] Three minor changes + GER

2017-03-06 Thread Jonas Thelemann
Hey pgAdmin-hackers, I want to suggest three minor changes attached to this mail: 1. "couldnot" - while working with .po-files I found most strings contain "could not [...]" while some contain "couldn't [...]" for the sake of simplicity I adapted all short forms to the most used one. 2. "e

[pgadmin-hackers] pgAdmin 4 commit: Bump version prior to release.

2017-03-06 Thread Dave Page
Bump version prior to release. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=063177155e04e8cca6dc5582679394aca4be6567 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 file

Re: [pgadmin-hackers] [pgadmin-support] How to clean off all python stuff

2017-03-06 Thread Neel Patel
looping pgadmin-hackers... As you are running desktop application but it's not finding python path and required modules. You need to export PYTHONPATH to where it installed all the required packages needed by application. Thanks, Neel Patel On Mon, Mar 6, 2017 at 5:30 PM, marcelo wrote: > Hi N

Re: [pgadmin-hackers] [pgadmin-support] How to clean off all python stuff

2017-03-06 Thread Dave Page
On Mon, Mar 6, 2017 at 11:42 AM, Neel Patel wrote: > Hi, > > Always loop pgadmin-hackers while replying email thread. > > Can you please share the errors while running application ? > > Thanks, > Neel Patel > > On Mon, Mar 6, 2017 at 2:06 PM, marcelo wrote: >> >> Hi >> >> Of course I read the REA

Re: [pgadmin-hackers] [pgadmin-support] How to clean off all python stuff

2017-03-06 Thread Neel Patel
Hi, Always loop pgadmin-hackers while replying email thread. Can you please share the errors while running application ? Thanks, Neel Patel On Mon, Mar 6, 2017 at 2:06 PM, marcelo wrote: > Hi > > Of course I read the README, and followed it until these indications > (pint 6) > > (pgadmin4) $

Re: [pgadmin-hackers][patch] Shows titles for disabled buttons on hover

2017-03-06 Thread Dave Page
Hi On Fri, Mar 3, 2017 at 9:19 PM, Sarah McAlear wrote: > Hi Hackers, > > This patch enables hovering over disabled buttons to see their > functionality. This seems to work for the button bar in the query tool, but not for other buttons such as those on dialogues. Can you update to fix the probl

Re: [pgadmin-hackers] [PATCH][pgAdmin4] To fix the issue in server-group deletion

2017-03-06 Thread Dave Page
Thanks, applied. On Fri, Mar 3, 2017 at 1:14 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in ServerGroup node, where servers associated to > server group were not deleted when user deletes server-group. > RM#2212 > > Also fixed the gif file url in file manager(changes include

[pgadmin-hackers] pgAdmin 4 commit: Fix the path to the busy indicator for the treeview w

2017-03-06 Thread Dave Page
Fix the path to the busy indicator for the treeview which changed when the aciTree module was moved. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d6a3753eec52f2628aae1320c1b2876d535250c Author: Murtuza Zabuawala Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Ensure servers are deleted when their parent group is

2017-03-06 Thread Dave Page
Ensure servers are deleted when their parent group is deleted. Fixes #2212 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da186ea77b68a696c82b9c29dd109db4e12aeaba Author: Murtuza Zabuawala Modified Files -- web/pgadmin/model/__ini

Re: [pgadmin-hackers] [PATCH][pgAdmin4] To show indeterminate state for [null] value for boolean

2017-03-06 Thread Dave Page
Thanks, applied (note that it fixes #2218, not #2153). On Fri, Mar 3, 2017 at 10:32 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue where it was not showing indeterminate > state for [null] value for boolean when we enter value in new row. > RM#2153 > > -- > Regards, > Mur

[pgadmin-hackers] pgAdmin 4 commit: Show the correct indeterminate state when editing new

2017-03-06 Thread Dave Page
Show the correct indeterminate state when editing new boolean values. Fixes #2218 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af499c0c9ad0919971ba270ad24c8ec74cd843de Author: Murtuza Zabuawala Modified Files -- web/pgadmin/sta

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1796 - Added 'Run now' option to run pgAgent Job

2017-03-06 Thread Dave Page
Thanks, patch applied. On Fri, Mar 3, 2017 at 9:25 AM, Neel Patel wrote: > Hi, > > Please find attached patch file to fix for RM #1796 - Added "Run now" option > to run the pgAgent job. > > Do review it and let me know for comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmin-hackers mai

[pgadmin-hackers] pgAdmin 4 commit: Add missing "Run Now" option for pgAdmin jobs. Fixes

2017-03-06 Thread Dave Page
Add missing "Run Now" option for pgAdmin jobs. Fixes #1796 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=278c64c3619d77038bf207420fb16c02e0c80436 Author: Neel Patel Modified Files -- .../server_groups/servers/pgagent/__init__.py

Re: [pgadmin-hackers][discussion] Javascript package management (Yarn?)

2017-03-06 Thread Dave Page
Hi On Fri, Mar 3, 2017 at 8:36 PM, Atira Odhner wrote: >> - Whilst it cuts down on the bloat caused by unnecessary files in the >> source tree, it does nothing to prevent the problem in the packages we >> distribute to users (installers, app bundles, RPMs etc) which are the >> primary concern in

Re: [pgadmin-hackers] Pip Setup Typo Fix & Question

2017-03-06 Thread Dave Page
On Sat, Mar 4, 2017 at 10:24 PM, Jonas Thelemann wrote: > Ok, "py2.py3" makes sense because it's for both python versions. Right - I figured out how to make a universal wheel a week or so back. > But why is a v1.1 still (re)build? Are you sure it's not a left-over build (or partial build in the