Re: [pgadmin-hackers] pgAdmin 4 commit: Remove \n in translation that was causing a syntax er

2017-03-14 Thread Jonas Thelemann
For me that was a problem with my german .po file which is not in the git yet, but I'll test it soon and tell you the result. Am 14.03.2017 um 10:09 schrieb Dave Page: Hi On Mon, Mar 13, 2017 at 2:25 PM, Jonas Thelemann wrote: By the way: I found a workaround for the error(s) in PoEdit and

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

2017-03-14 Thread Atira Odhner
Dave, try doing the yarn install and karma run from the web directory. karma cli expects karma to be under node_modules where it is run from. (which is where yarn will install it if you use yarn from the web directory). Karma also needs to be run from the directory where karma.conf is. I've also r

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

2017-03-14 Thread Atira Odhner
accidentally removed the group from this thread. adding them back. On Mon, Mar 13, 2017 at 7:08 AM, Dave Page wrote: > On Fri, Mar 10, 2017 at 4:53 PM, Atira Odhner wrote: > > We moved package.json, karma.conf, and node_modules under web. We'll > take a > > This doesn't work for me: > > ===

[pgadmin-hackers] pgAdmin 4 commit: Fix previous partial commit

2017-03-14 Thread Dave Page
Fix previous partial commit Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff9d6cd3d541d7f24af908eea61dde19d0e8b4fc Author: Murtuza Zabuawala Modified Files -- .../static/vendor/bootstrap/bootstrap-theme.css| 476 -- .../vendo

Re: [pgadmin-hackers] [PATCH][pgAdmin4] Move Bootstrap fonts to 'vendor/fonts' folder

2017-03-14 Thread Dave Page
Thanks, applied (though, I removed npm.js again). On Mon, Mar 13, 2017 at 12:19 PM, Murtuza Zabuawala wrote: > Hi, > > Please find updated patch to move Bootstrap files in proper directory > structure. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.

[pgadmin-hackers] pgAdmin 4 commit: Move Bootstrap files into the distribution format.

2017-03-14 Thread Dave Page
Move Bootstrap files into the distribution format. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc4c5571225375e8c8ae59fc31339b63dd6a79ea Author: Murtuza Zabuawala Modified Files -- .../vendor/bootstrap/css/bootstrap-theme.css

Re: [pgadmin-hackers] pgAdmin 4 commit: Remove \n in translation that was causing a syntax er

2017-03-14 Thread Dave Page
Hi On Mon, Mar 13, 2017 at 2:25 PM, Jonas Thelemann wrote: > By the way: I found a workaround for the error(s) in PoEdit and in the > compiling process of the .po files: The problem was [one of the] "obsolete > messages" starting with "#~" at the bottom of the .po file. I removed them > all and n