On Thu, Mar 23, 2017 at 8:23 PM, Dave Page wrote:
> On Thu, Mar 23, 2017 at 1:51 PM, Atira Odhner wrote:
> >
> > We will use jquery to make ajax calls that fetch the history data, but
> > actually rendering that data and managing the data once it has been
> fetched
> > will be handled with React
Thanks Dave.
1) String extraction no longer picks up strings in JS files. I guess
> we may need a custom extractor for babel?
Yeah, that's a good point. I didn't think about that. I'll put that in my
team's backlog coming up.
Here's a patch for the docs.
On Thu, Mar 23, 2017 at 8:37 AM, Dave
Hello Hackers,
We found out a issue using Python 3 related to importing modules that we
corrected in the patch that is now attached.
Also we would like to know the status of this.
Thanks
Joao & Sarah
On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear wrote:
> Hi!
>
> We realized that this change
Hi Hackers,
While doing the DDL patch we found out that the code was not working
properly when errors happened during SQL execution:
One example of this can be found in the file:
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
The function '*_formatter*' that retu
On Thu, Mar 23, 2017 at 1:51 PM, Atira Odhner wrote:
>
> We will use jquery to make ajax calls that fetch the history data, but
> actually rendering that data and managing the data once it has been fetched
> will be handled with React.
>
> Backbone is not as powerful as React, and does not provide
Hi again,
After having some conversations on our team, we've had some new thoughts
about when/where to start bringing in React:
We're working on the tree state being re-opened when the user re-opens the
app. We were originally planning to do this change within the existing
framework, but were hav
Hi Hackers,
Sorry for not being more careful about the creation of patches and the
Python 2 vs Python 3 issue.
Thanks
Joao & Sarah
On Thu, Mar 23, 2017 at 8:00 AM, Dave Page wrote:
> Thanks, committed. Note that this patch also touched
> copy_selected_columns_feature_test.py so I dropped that
Yeah, just checked ...Running all now :)
Thanks!
On Thu, Mar 23, 2017 at 7:31 PM, Dave Page wrote:
> That should also be fixed now.
>
> On Thu, Mar 23, 2017 at 12:45 PM, Navnath Gadakh
> wrote:
> > Thanks, It's running now for python2 but failing for python3. Its syntax
> > error 'tuple parame
That should also be fixed now.
On Thu, Mar 23, 2017 at 12:45 PM, Navnath Gadakh
wrote:
> Thanks, It's running now for python2 but failing for python3. Its syntax
> error 'tuple parameter unpacking not supported in python3'
> In filter function.
>
> Traceback (most recent call last)
>
> File "r
>
> Why anything new? Adding any library needs to be fully justified, and
> adding one this large, that gives similar capabilities to one we
> largely already have is going to require a significant amount of
> convincing before it would be added.
Of course. That's why we're starting this conversa
Fix Python 3 compatibility.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d205550b53e28c1d0262a70ba4e333a580ed402b
Modified Files
--
.../schemas/tables/templates/table/sql/tests/test_tables_acl.py | 4 ++--
1 file changed, 2
Thanks, It's running now for python2 but failing for python3. Its syntax
error '*tuple parameter unpacking not supported in python3'*
In filter function.
*Traceback (most recent call last)*
* File "runtests.py", line 284, in *
*test_module_list = get_test_modules(args)*
* File "runtests
Hi Tira,
I've been spending spare minutes starting to move the JS translations
to use your new mechanism with an aim to minimising the Jinja
rendering. Unfortunately, I found a couple of issues; can you look
into them please?
1) String extraction no longer picks up strings in JS files. I guess
we
Client side translation.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8748ee20cbd31d0d804eeca04ecf4ddbe0a35a24
Modified Files
--
.../templates/preferences/preferences.js | 23 +++---
.../settings/template
Update again please. I fixed it a couple of minutes later (I missed a file).
On Thu, Mar 23, 2017 at 12:23 PM, Navnath Gadakh
wrote:
> Hi Dave,
>
>I just checked with latest code, test-suite execution failing.
> Showing import errors for test_utils.
> I didn't find test_utils.py under pyt
Hi Dave,
I just checked with latest code, test-suite execution failing.
Showing import errors for *test_utils.*
I didn't find *test_utils.py* under *python_test_utils/*
*Traceback (most recent call last):*
* File "runtests.py", line 45, in *
*from regression import test_setup*
* F
Add file missed from the previous commit.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59a6a08e8ab805da8ed21580001f64926a255738
Modified Files
--
web/regression/python_test_utils/test_utils.py | 455 +
1 fi
Thanks, committed. Note that this patch also touched
copy_selected_columns_feature_test.py so I dropped that hunk.
On Wed, Mar 22, 2017 at 10:01 PM, Atira Odhner wrote:
> Hi Hackers,
>
> Since we have more than one type of test suite now, it makes sense to do a
> little organizing in the regressi
Re-organised the regression directory now we have multiple test suites: move
test_utils.py into python_test_utils/
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10920404e146bc4b87100b65fc41ed29ab65e2cd
Author: Atira Odhner
Modified Files
--
Thanks, patches applied.
Note that 0003 had one hunk rejected that I simply ignored as it was
for web/pgadmin/feature_tests/copy_selected_columns_feature_test.py
which doesn't currently exist in the community repo (the patch for
column selection was rejected as it didn't work consistently and
pred
Replace the template selection feature test with one that tests table DDL
generation (which also covers template selection).
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe9bc379c7d03c9dee632fb7c1a2ac2eef315371
Author: Atira Odhner
Modifie
Support generation of DDL for tables in Greenplum DB. Fixes #2261
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=77007996ed716d96d99ab94ef6ab92ae0467c020
Author: Atira Odhner
Modified Files
--
.../schemas/tables/templates/column/_
Move foreign key templates into a default directory.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ba0b25290ff0f16a49f21e9bf94d8951737c8cb
Author: Atira Odhner
Modified Files
--
.../servers/databases/schemas/tables/__init__.py
Thanks, applied.
On Thu, Mar 23, 2017 at 9:04 AM, Harshal Dhumal
wrote:
> Hi,
>
> PFA minor patch for RM2283.
>
> Issue: When setting default selection of multiple values we need to check if
> select2 cell is in multiselect mode. We need to check this as javascript
> assumes string as array of ch
Select2Cell: Check if cell is in multiselect mode before setting default
selection of multiple values. Fixes #2283
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=720aefbe6fa6b69841506e487f30363e7996aaa2
Author: Harshal Dhumal
Modified Files
Hi
On Wed, Mar 22, 2017 at 7:09 PM, Atira Odhner wrote:
> Hi Hackers,
>
> We want to give you a heads up on some of the changes we are planning and
> get your input on the implementation plan.
>
> The Redmine issue is here: https://redmine.postgresql.org/issues/2282
>
> Over the past month we hav
Hi,
PFA minor patch for RM2283.
Issue: When setting default selection of multiple values we need to check
if select2 cell is in multiselect mode. We need to check this as javascript
assumes string as array of chars and tries to set individual char as
selected option in cell.
RM2283.patch
Descri
27 matches
Mail list logo
