Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-20 Thread Murtuza Zabuawala
Hi Dave, Please test the patch with query provided by user, SELECT ARRAY[48994717597666517,48968053424532376,76561198004879311,76561198078757065,76561198086825618]::text as good, ARRAY[48994717597666520,48968053424532376,76561198004879311,76561198078757065,76561198086825618] as bad I was doing

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-20 Thread Ashesh Vashi
Hi Joao & Oliver, On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > @Ashesh thanks for the feedback > > Here is the reviewed patch with the suggestions of Ashesh. > > Disclaimer: We added a new patch file with the changes >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

2017-04-20 Thread Khushboo Vashi
Hi, Please find the attached updated patch. I have tested this patch on Ubuntu (Chrome & Firefox) and Mac (Chrome). Thanks, Khushboo On Tue, Apr 18, 2017 at 7:25 PM, Dave Page wrote: > Unfortunately I had to revert this, as I found it was preventing > treeview nodes from

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-20 Thread Joao Pedro De Almeida Pereira
Hello Hackers, @Ashesh thanks for the feedback Here is the reviewed patch with the suggestions of Ashesh. Disclaimer: We added a new patch file with the changes Thanks Joao & Oliver On Thu, Apr 20, 2017 at 10:56 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Apr 20, 2017

[pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

2017-04-20 Thread Joao Pedro De Almeida Pereira
Hi Hackers, With the update to version 58 of chrome the version of the chrome driver of Selenium need to be updated to version 2.29. This patch does that change. Note: If you had previously installed the old driver you need to uninstall and install again it. $ pip uninstall

[pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

2017-04-20 Thread Josh Berkus
pgAdmin team, Devrim: If I install the pgadmin4-v1-web package from Yum, it's a bit unclear on what actual configuration needs to be done after that. Things I know need to be done: * running setup.py * copying the httpd/conf.d/pgadmin4-web.conf.example file to a .conf file Things I don't know

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-20 Thread Dave Page
Hi On Thu, Apr 20, 2017 at 7:39 PM, Shirley Wang wrote: > Hi! > > On Thu, Apr 20, 2017 at 4:18 AM Dave Page wrote: > >> Hi >> >> On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang wrote: >> >>> Hello Hackers, >>> >>> We've started to work on

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-20 Thread Shirley Wang
Hi! On Thu, Apr 20, 2017 at 4:18 AM Dave Page wrote: > Hi > > On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang wrote: > >> Hello Hackers, >> >> We've started to work on creating a style guide for pgAdmin4. >> >> Our goals with the style guide are to: >> - have

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-20 Thread Dave Page
On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili wrote: > Hello Hackers, > > We found that having the column header extend all the way across the query > output frame made it seem like there were more columns. This was confusing > to some users. > > We made a change to

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-20 Thread Ashesh Vashi
On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Ashesh, > > Did you had time to review this patch? > Yes - I did. Please my review comments: Everytime I start pgAdmin 4, I am getting now the following message: "pgAdmin 4 - Application

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-20 Thread Joao Pedro De Almeida Pereira
Hello Ashesh, Did you had time to review this patch? Thanks Joao & Oliver On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear wrote: > Great, thank you so much! > > On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, Apr 12,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-20 Thread Murtuza Zabuawala
That is strange. I tested on PG9.6 and it was working properly, What is the your PG version? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 20, 2017 at 7:06 PM, Dave Page wrote: > > > On Fri, Apr 14,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-20 Thread Dave Page
On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, >> >> PFA minor patch to fix the the issue with bigint[] array values as JS >> truncates long numbers from array object. >> RM#2272 >> > Hi As far as I can see, this doesn't work as expected.

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-20 Thread Dave Page
Hi On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang wrote: > Hello Hackers, > > We've started to work on creating a style guide for pgAdmin4. > > Our goals with the style guide are to: > - have a single source of truth for visual design and workflows > - make it easier when