Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-24 Thread Akshay Joshi
Thanks patch applied. On Mon, Apr 24, 2017 at 4:40 PM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Fri, Apr 21, 2017 at 6:35 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please test the patch with query provided by user, >> >> SELECT ARRAY[48994717

[pgadmin-hackers] pgAdmin 4 commit: Fix handling of bigint[] type. Fixes #2272

2017-04-24 Thread Akshay Joshi
Fix handling of bigint[] type. Fixes #2272 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38c8a4fb607373358b49bfe656d2c0290c05020c Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++--

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

2017-04-24 Thread Akshay Joshi
Thanks patch applied. On Mon, Apr 24, 2017 at 4:40 PM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> Please find the patch to fix the issue while using ANALYZE option in IE. >> >> *Is

[pgadmin-hackers] pgAdmin 4 commit: startsWith() function of java script is not supported

2017-04-24 Thread Akshay Joshi
startsWith() function of java script is not supported in IE, instead use startsWith() function of underscore string. Fixes #2347 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=928c0d3de8eac88d0ef8f6272951d12dbfe636f7 Author: Murtuza Zabuawala

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

2017-04-24 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where we were not correctly providing default parameters to respective argument(s). RM#2350 Affected node, 1) Functions 2) Trigger Function 3) Procedures (EPAS) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compan

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-24 Thread Dave Page
Thanks - patch applied! On Mon, Apr 24, 2017 at 2:43 PM, Sarah McAlear wrote: > Oh, good catch! Here's a new patch with all the lines in place. > > Thanks, > Joao & Sarah > > On Thu, Apr 20, 2017 at 12:05 PM, Dave Page wrote: > >> >> >> On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili < >> g

[pgadmin-hackers] pgAdmin 4 commit: Only display the header row in SlickGrid where column

2017-04-24 Thread Dave Page
Only display the header row in SlickGrid where columns actually exist. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f718e1f49c95460b828c397ce36c1e2ea37a0031 Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/to

Re: [pgadmin-hackers] [patch] Query Output Header Width

2017-04-24 Thread Sarah McAlear
Oh, good catch! Here's a new patch with all the lines in place. Thanks, Joao & Sarah On Thu, Apr 20, 2017 at 12:05 PM, Dave Page wrote: > > > On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili < > ggelashv...@pivotal.io> wrote: > >> Hello Hackers, >> >> We found that having the column header e

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-04-24 Thread Sarah McAlear
Awesome, thank you for adding that back in! On Sun, Apr 23, 2017 at 11:17 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> >> We review the patch, just noticed

Re: [GENERAL] [pgadmin-hackers] file permission on ssl key

2017-04-24 Thread Adrian Klaver
On 04/23/2017 07:42 PM, Ashesh Vashi wrote: Hi Jeroen, This is pgAdmin hackers list. Please send mail to pgsql-gene...@postgresql.org mailing list for your postgresql related queries. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Postgr

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility

2017-04-24 Thread Dave Page
Thanks - looks good, so committed. On Fri, Apr 21, 2017 at 1:02 PM, Akshay Joshi wrote: > Hi All > > Please find the patch to support PostgreSQL 10 compatibility, though it > was not completed as SCRAM authentication support is still remaining to > change the password. > > Patch contains followi

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214 (missed some f

2017-04-24 Thread Dave Page
Initial support for PG 10.0, per #2214 (missed some files) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a449be784e8fa6ee719aa97bcb8b5e514fc7150e Author: Akshay Joshi Modified Files -- .../templates/sequence/sql/10.0_plus/get_de

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214

2017-04-24 Thread Dave Page
Initial support for PG 10.0, per #2214 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59834fba310722b0c45bdcb3bfc9eb0a8ac4d9aa Author: Akshay Joshi Modified Files -- .../templates/sequence/sql/default/update.sql | 10 +++---

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

2017-04-24 Thread Dave Page
Thanks - applied. I'll keep an eye on Jenkins :-) On Fri, Apr 21, 2017 at 7:58 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We recreated the patch and should work now. > > The problem looks like an issue with pip. I just opened an issue in their > git

[pgadmin-hackers] pgAdmin 4 commit: Update test requirements for the latest rev of Chrome

2017-04-24 Thread Dave Page
Update test requirements for the latest rev of Chrome. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3eb92f7ea3abf3c6cb21d6f1dc391a300095026c Author: Joao Pedro De Almeida Pereira Modified Files -- web/regression/requirements.tx

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-04-24 Thread Dave Page
Ashesh, can you review/commit this please? Thanks. On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where node rename is not working properly > after 7dd9efd8 >

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-04-24 Thread Dave Page
Ashesh, can you review/commit this please? On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We found out that when you are connected to a GreenPlum database and try > to get Dependents and Dependencies of an object the applica

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

2017-04-24 Thread Dave Page
Akshay, can you review/commit this please? On Fri, Apr 21, 2017 at 6:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please test the patch with query provided by user, > > SELECT ARRAY[48994717597666517,48968053424532376,76561198004879311, > 76561198078757065,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

2017-04-24 Thread Dave Page
Akshay, can you review/commit this please? On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find the patch to fix the issue while using ANALYZE option in IE. > > *Issue:* > We were using .startsWith() function to check the sql if it

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Table column edit breaks when using column level permissions

2017-04-24 Thread Dave Page
Akshay, can you review/commit this please? On Fri, Apr 14, 2017 at 12:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in table node where it breaks column edit when > user provides column level permissions. > RM#2335 > > -- > Regards, > M

[pgadmin-hackers] pgAdmin 4 commit: Added dependency on Flask-Migrate added by previous c

2017-04-24 Thread Ashesh Vashi
Added dependency on Flask-Migrate added by previous commit: 6283ef7f5e4379d5e2202ca2919b9ea76caf57c7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=139a10e8f9b483ede6e6578f451119bd698e1bca Modified Files -- requirements.txt | 1 +

Re: [pgadmin-hackers] QT dependances of the web version?

2017-04-24 Thread Dave Page
On Fri, Apr 21, 2017 at 11:41 PM, Josh Berkus wrote: > Dave, all: > > Does the web version of pgadmin4 rely on QT somehow? > > The reason I ask is that, when you install pgadmin4 on a server, > installing the required QT modules drags in all of Xorg/Wayland, which > is around 250MB of packages wh

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

2017-04-24 Thread Dave Page
On Fri, Apr 21, 2017 at 10:40 PM, Josh Berkus wrote: > On 04/21/2017 02:14 PM, Josh Berkus wrote: > > On 04/21/2017 01:57 AM, Devrim Gündüz wrote: > >> On RHEL 7 / Fedora 25: > >> > >> * systemctl enable pgadmin4-v1.service; systemctl start > pgadmin4-v1.service > >> * cp /etc/httpd/conf.d/pgadmi

Re: [pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

2017-04-24 Thread Dave Page
On Fri, Apr 21, 2017 at 6:45 PM, Josh Berkus wrote: > Devrim, > > > * cp /etc/httpd/conf.d/pgadmin4-v1.conf.sample > /etc/httpd/conf.d/pgadmin4- > > v1.conf > > One more question: the sample .conf doesn't have the > threads-and-1-process configuration recommended in the pgadmin docs. Is > there