Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-04-25 Thread Ashesh Vashi
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> We found out that when you are connected to a GreenPlum database and tr

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-04-25 Thread Ashesh Vashi
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > Ashesh, can you review/commit this please? Thanks. > > On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue where node rename is not working >> properly after 7dd9efd8 >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Khushboo Vashi
Hi Joao & Sarah, Thanks for reviewing the patch. On Tue, Apr 25, 2017 at 8:34 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > > We reviewed the this patch and have some suggestions: > > *Python:* > ​ > The functionality for adding the "can_prettify" i

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Dave Page
On Tue, Apr 25, 2017 at 4:04 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > > We reviewed the this patch and have some suggestions: > > *Python:* > ​ > The functionality for adding the "can_prettify" is repeated in multiple > places. Maybe this could b

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

2017-04-25 Thread Josh Berkus
On 04/24/2017 01:23 AM, Dave Page wrote: > There isn't an easy fix for this; on a default Fedora or CentOS system, > the only directory the apache user has read/write to is /tmp, as far as > I know. > > Ideas? > > > This is covered in the docs: > https://www.pgadmin.org/docs4/1.x

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Joao Pedro De Almeida Pereira
Hello Khushboo, We reviewed the this patch and have some suggestions: *Python:* ​ The functionality for adding the "can_prettify" is repeated in multiple places. Maybe this could be extracted into a function. *Javascript:* ​ - The class Backgrid.SizeFormatter doesn't seem to have any tests.

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-04-25 Thread Dave Page
On Tue, Apr 25, 2017 at 2:47 PM, Shirley Wang wrote: > >> >> I recommend documenting the green for switches (#5cb85c), which would >> change notifiers from this: >> >> [image: Notifiers.png] >> >> to this: >> [image: Screen Shot 2017-04-20 at 5.28.55 PM.png] >> > > > Wouldn't it be better if it m

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

2017-04-25 Thread Akshay Joshi
Thanks patch applied. On Tue, Apr 25, 2017 at 5:25 PM, Dave Page wrote: > Akshay, please review/commit this. > > Thanks. > > On Tue, Apr 25, 2017 at 5:59 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue where we were not correctly providing default >> par

[pgadmin-hackers] pgAdmin 4 commit: Fixed handling of default parameters ordering in func

2017-04-25 Thread Akshay Joshi
Fixed handling of default parameters ordering in functions. Fixes #2350 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6790bfd0c07bb0701471f392e5d76bbe89ecc513 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/sch

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Dave Page
Ashesh, can you review/commit this please? Thanks. On Tue, Apr 25, 2017 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Fixed RM #2315 : Sorting by size is broken. > > Removed the pg_size_pretty function from query for the collection and > introduced the client si

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

2017-04-25 Thread Dave Page
Akshay, please review/commit this. Thanks. On Tue, Apr 25, 2017 at 5:59 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where we were not correctly providing default > parameters to respective argument(s). > RM#2350 > > Affected node, > 1)

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-04-25 Thread Dave Page
Hi On Tue, Apr 25, 2017 at 8:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > To implement feature #2137 we'll > need to use server cursor. However server cursor has some > limitation. > For eg. > 1. It cannot execute BEGI

Re: [pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Dave Page
On Tue, Apr 25, 2017 at 12:32 PM, Mateusz Korszun < mateusz.kors...@meltwater.com> wrote: > I am using this docker image -> https://hub.docker.com/r/meedan/pgadmin. > I do not configure anything apart from PGADMIN_USER & PGADMIN_PASSWORD. > Oh, OK. You'll need to contact the author of the contain

Re: [pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Mateusz Korszun
I am using this docker image -> https://hub.docker.com/r/meedan/pgadmin. I do not configure anything apart from PGADMIN_USER & PGADMIN_PASSWORD. On Tue, Apr 25, 2017 at 12:27 PM, Dave Page wrote: > > > On Tue, Apr 25, 2017 at 10:48 AM, Mateusz Korszun < > mateusz.kors...@meltwater.com> wrote: >

Re: [pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Dave Page
On Tue, Apr 25, 2017 at 10:48 AM, Mateusz Korszun < mateusz.kors...@meltwater.com> wrote: > Hi, > > I have pgAdmin4 running as a web server and accessible only via HTTPS. The > problem is that pgAdmin4 on redirects ignores original scheme and always > redirects to HTTP. Is it possible to change it

[pgadmin-hackers] HTTPS ignored on redirect

2017-04-25 Thread Mateusz Korszun
Hi, I have pgAdmin4 running as a web server and accessible only via HTTPS. The problem is that pgAdmin4 on redirects ignores original scheme and always redirects to HTTP. Is it possible to change it? BR -- *Mateusz Korszun* Software Engineer, Meltwater Berlin Office: +49 (0)30 293 692 0 mateusz

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-25 Thread Khushboo Vashi
Hi, Fixed RM #2315 : Sorting by size is broken. Removed the pg_size_pretty function from query for the collection and introduced the client side function to convert size into human readable format. So, the sorting issue is fixed as the algorithm will get the actual value of size instead of format

[pgadmin-hackers] Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-04-25 Thread Harshal Dhumal
Hi Dave, To implement feature #2137 we'll need to use server cursor. However server cursor has some limitation. For eg. 1. It cannot execute BEGIN; query (basically user cannot start new database transaction) 2. In case if Auto commit is true then we tr

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Table column edit breaks when using column level permissions

2017-04-25 Thread Akshay Joshi
Thanks patch applied. On Mon, Apr 24, 2017 at 4:40 PM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Fri, Apr 14, 2017 at 12:09 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue in table node where it breaks column edit when >> user

[pgadmin-hackers] pgAdmin 4 commit: Fixed handling of nested privileges. Fixes #2335

2017-04-25 Thread Akshay Joshi
Fixed handling of nested privileges. Fixes #2335 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ce1f216caaec414def266cc69d90961b8c0a131 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/static/js/priv