[pgadmin-hackers][Patch] Rename feature test server

2017-04-27 Thread Sarah McAlear
Hi Hackers! We realized that the feature tests and unit tests were using the same server, which was causing some flakiness when running the tests. This patch renames the server for the feature tests. Thanks! Joao & Sarah 0001-Change-the-name-of-the-Server-created-for-Feature-te.patch Descriptio

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Dave Page
Thanks Joao. Murtuza, can you review this please? On Thu, Apr 27, 2017 at 4:49 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We found that the latest version of SlickGrid fixes the scrollbar issue. > We have upgraded it to the latest version in our ven

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Robert Eckhardt
> > The issues we consistently face: >> >>- The huge (often thousands sometimes tens of thousands) number of >>partitions makes rendering all of the partitions painfully slow and >>frequently not useful. >> >> Perhaps, though I doubt that number would be common in Postgres. The > proble

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
On Thu, Apr 27, 2017 at 3:18 PM, Robert Eckhardt wrote: > > > On Thu, Apr 27, 2017 at 7:01 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> As per discussion I have changed the logic of showing partitioned table >> in browser tree. Attached is the screenshot. >> Let m

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
On Thu, Apr 27, 2017 at 12:01 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > As per discussion I have changed the logic of showing partitioned table in > browser tree. Attached is the screenshot. > Let me know your thoughts. > That's pretty much what I had in mind, yes. Th

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-04-27 Thread Joao Pedro De Almeida Pereira
Thanks for reviewing, Ashesh. We have updated the patch. The headers are all consistent and we removed the __init__.py files in directories containing only .sql. Thanks! Joao & Matt On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello As

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Robert Eckhardt
On Thu, Apr 27, 2017 at 7:01 AM, Akshay Joshi wrote: > Hi Dave > > As per discussion I have changed the logic of showing partitioned table in > browser tree. Attached is the screenshot. > Let me know your thoughts. > Greenplum has had declarative partitioning for quite some time, I haven't spent

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-27 Thread Sarah McAlear
Hi Kushboo! We understand your point, but we believe that relying on 2 independent functions to deliver the same formatting can become a problem if the PG function changes. Our suggestion is to use a single function in our javascript code to do this formatting. If the community believes we can li

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Murtuza Zabuawala
No, we didn't. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 4:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Thanks for the explanation. Based on what you said it

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Joao Pedro De Almeida Pereira
Hello Murtuza, Thanks for the explanation. Based on what you said it looks like a bug in the library, have you guys considered sending a PR to it? Thanks On Thu, Apr 27, 2017, 2:46 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > +++ > Reference: > https://www.postgresql.org/m

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-04-27 Thread Dave Page
On Wed, Apr 26, 2017 at 6:36 PM, Shirley Wang wrote: > Hello! > > On Wed, Apr 26, 2017 at 4:26 AM Dave Page wrote: > >> Hi >> >> [moving to the pgadmin-hackers mailing list as this a pgAdmin feature] >> >> On Wed, Apr 26, 2017 at 8:20 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >