Hi Harshal!
We applied your patch and ran the Javascript tests and realized there are 6
tests failing. After that we replicate the failures by hand and found the
following issues:
- Clicking in the checkboxes of the rows does not select the row anymore.
- When copying and pasting (any) data, we r
On 05/08/2017 03:57 AM, Devrim Gündüz wrote:
>
> Hi Josh,
>
> Sorry for the late response, I have 10K unread emails as of now:
>
> On Tue, 2017-04-25 at 08:24 -0700, Josh Berkus wrote:
>
>> I know how to fix my personal install (and container image). But I want
>> to fix the RPM package so tha
Hi!
This patch has the tests moved to the test directories of the parent.
Thanks,
Joao & Sarah
On Mon, May 8, 2017 at 7:28 AM, Dave Page wrote:
> Hi
>
> On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> I have reviewed the code and have f
Hi
Because they're too unreliable. That's why I was pushing you guys to work
on the React treeview implementation a couple of weeks ago in our call.
On Mon, May 8, 2017 at 3:46 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Hackers,
>
> We were looking through t
Hello Hackers,
We were looking through the CI configuration and we did not understand why
the feature tests are not running. What is the reason for excluding them?
Thanks
Joao & Sarah
Hi Dave,
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, May 8, 2017 at 4:49 PM, Dave Page wrote:
> Hi
>
> This is fantastic! The speedup in the query tool is phenomenal with large
> result sets. For 96K row
Fix various issues in CSV file download feature:
1) To handle non-ascii filenames which we set from table name. Fixes #2314
2) To handle non-ascii query data. Fixes #2253
3) To dump JSON type columns properly in csv. Fixes #2360
Branch
--
master
Details
---
https://git.postgresql.org/g
Thanks, patch applied.
On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> Please find the patch to fix the issues in CSV file download feature,
>
> 1) To handle non-ascii filenames which we set from table name
> RM#2314
>
> 2) To handle non-as
Hi,
Please find the patch to fix the issues in CSV file download feature,
1) To handle non-ascii filenames which we set from table name
RM#2314
2) To handle non-ascii query data
RM#2353
3) To dump JSON type columns properly in csv
RM#2360
Please review.
--
Regards,
Murtuza Zabuawala
Enterpris
Sure. I am verifying on OS X with latest commit ID.
On Mon, May 8, 2017 at 4:38 PM, Dave Page wrote:
> Thanks - applied. Note that I couldn't reliably reproduce this issue, but
> it seems to fix it, and the code looks sane. Fahar, please spend 20 minutes
> to see if you have better luck fully ve
Thanks - applied. Note that I couldn't reliably reproduce this issue, but
it seems to fix it, and the code looks sane. Fahar, please spend 20 minutes
to see if you have better luck fully verifying that I did.
Thanks!
On Mon, May 8, 2017 at 12:01 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.co
Only reconnect to databases that were previously connected. Fixes #2292
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a80f760933812d9747891af8711fe66f38f3cd78
Author: Harshal Dhumal
Modified Files
--
web/pgadmin/utils/driver/psy
Hi
On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi wrote:
> Hi All
>
> I have reviewed the code and have following questions:
>
>- Why do we have empty __init__.py file in sql and templates/
>folder. In this patch we have couple of occurrences one of them is web/
>
> pgadmin/browser/se
Hi All
I have reviewed the code and have following questions:
- Why do we have empty __init__.py file in sql and templates/
folder. In this patch we have couple of occurrences one of them is web/
pgadmin/browser/server_groups/servers/databases/schemas/table/templates/trigger
and web
Hi
This is fantastic! The speedup in the query tool is phenomenal with large
result sets. For 96K rows, I'm now seeing 1 second until I can browse the
data, vs. 13 in v1.4 (and 22 secs in pgAdmin 3)!! Awesome work Harshal :-)
Questions/comments:
- Can we put the row number in the left-hand colum
On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> On Mon, May 8, 2017 at 3:51 PM, Dave Page wrote:
>
>> Hi
>>
>> On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Mon, May 8, 201
On Mon, May 8, 2017 at 11:57 AM, Devrim Gündüz wrote:
>
> Hi Josh,
>
> Sorry for the late response, I have 10K unread emails as of now:
>
> On Tue, 2017-04-25 at 08:24 -0700, Josh Berkus wrote:
>
> > I know how to fix my personal install (and container image). But I want
> > to fix the RPM packa
Hi,
Pls find patch for RM2292
Changes: While restoring connections after app restart only establish
connection if that
connection was connected previously.
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git
Hi Josh,
Sorry for the late response, I have 10K unread emails as of now:
On Tue, 2017-04-25 at 08:24 -0700, Josh Berkus wrote:
> I know how to fix my personal install (and container image). But I want
> to fix the RPM package so that it's fixed for most users. Right now,
> install from RPM i
Hi
On Mon, May 8, 2017 at 3:51 PM, Dave Page wrote:
> Hi
>
> On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
>>> s
Thanks - patch applied.
On Mon, May 8, 2017 at 8:08 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, May 5, 2017 at 9:00 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>>
Fix sorting of sizes on the statistics views by sorting raw values and
prettifying on the client side. Includes Jasmine tests for the prettyfying
function. Fixes #2315
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94b7fc483a3b70cb1e168396f3
Hi
On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote:
>
>> Hi
>>
>> On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> The supp
Hi Dave,
On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote:
> Hi
>
> On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> The support to handle [null] and [default] values is added for following
>> formatters:
>> - JsonFormatter
>> - Num
Hi
On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> The support to handle [null] and [default] values is added for following
> formatters:
> - JsonFormatter
> - NumbersFormatter
> - CheckmarkFormatter
> - TextFormatter
>
> Previously whe
Akshay, could you review this please?
Thanks.
On Fri, May 5, 2017 at 11:53 AM, Neel Patel
wrote:
> Hi,
>
> Please find attached patch file with the fix of RM #2328 - [Runtime]:
> Unable to launch query tool and debugger in new browser tab.
>
> I have used Qt 5.8 with webkit mentioned in below U
Please hold on on this patch, I am also working on same type of issue.
I think my patch would cover RM#2253 & RM#2360
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, May 8, 2017 at 2:30 PM, Harshal Dhumal <
harshal.dhu...@enterpris
Hi,
Pls find attached patch for csv download issue when data contains non ASCII
characters. And also when table name contains non ASCII characters
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadm
On Mon, May 8, 2017 at 1:46 PM, Dave Page wrote:
> Akshay, as Ashesh is unavailable today, can you please review/commit this
> ASAP?
>
Sure.
>
> Thanks.
>
> On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote:
>
>> Can you get this polished off on Monday please Ashesh?
>>
>> On Thu, May 4, 201
Hello,
Hope i got the right list.
Here a small issue written in UserStory format.
Me as a user don't want to have the PostgreSQL installer to install the
VisualStudio Redistributable if it is already installed so I have my beloved
database on my hard drive in a shorter time.
This story is for
That seems better - committed, thanks!
On Fri, May 5, 2017 at 11:35 AM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find the revised patch with some code changes related OS
> module used in feature tests for starting and stoping the app. There are
> so
Windows compatibility fixes for the test suite.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c32bf7780e718d66ef0c70af53519dac02224e1e
Author: Navnath Gadakh
Modified Files
--
.../utils/tests/test_versioned_template_loader.py |
Akshay, as Ashesh is unavailable today, can you please review/commit this
ASAP?
Thanks.
On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote:
> Can you get this polished off on Monday please Ashesh?
>
> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt
> wrote:
>
>> All,
>>
>> This change in the xss
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, May 5, 2017 at 9:00 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Khushboo,
>
> We looked at your updated patch:
> - the tests look good!
> - there's a small comment header change needed in size
34 matches
Mail list logo
