Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

We were only able to apply the patch on 1f903ba2 (were seeing patch does not apply due to sqleditor.js conflicts) The javascript tests passed, but we were unable to copy rows or columns or cells when running the application. Could you run feature tests? Now that more functionality is being added t

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hello Akshay, You can find attached a new version of the patch that changes the test in question. This new version instead of requiring a creation of a new Role now does the following: 1 - Creates a new Role 2 - Creates a table with that Role 3 - Checks for dependencies Thanks Joao & George On T

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

Hi On Fri, May 12, 2017 at 3:20 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached patch and review. > Thanks, committed. > > Also, I found an issue which > logged and will work on it. > Yes, I also saw

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #105

See Changes: [Dave Page] Track disabled rows properly in the edit grid. -- [...truncated 245.95 KB...] runTest (pgadmin.browser.server_groups.servers.databases.s

[pgadmin-hackers] pgAdmin 4 commit: Track disabled rows properly in the edit grid.

Track disabled rows properly in the edit grid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e7efc0cf8709ed3e1c0e4fc17a29707a79b1bbc Author: Surinder Kumar Modified Files -- .../sqleditor/templates/sqleditor/js/sqleditor.js |

Re: [pgadmin-hackers] javascript and css minification process

> > It's not yet. Those are utility scripts that I was eventually intending to > call from appropriate make targets during package build. Before we get > there though, we need code changes to ensure that we load minified code vs. > debug code at the appropriate times. I haven't done much with it in

Re: [pgadmin-hackers] javascript and css minification process

Hi On Fri, May 12, 2017 at 3:29 PM, George Gelashvili wrote: > Hello > > We're looking at the js and css minimization python code to investigate > minification as part of the pgadmin artifact build process. > > We're wondering why minimise.py is currently only manually invokable, via > the minim

[pgadmin-hackers] javascript and css minification process

Hello We're looking at the js and css minimization python code to investigate minification as part of the pgadmin artifact build process. We're wondering why minimise.py is currently only manually invokable, via the minimise make step. Also it seems like currently, minimise.py's dependencies (rc

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

Hi Dave, Please find attached patch and review. Also, I found an issue which logged and will work on it. On Fri, May 12, 2017 at 5:19 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Fri, May 12, 2017 at 5:00 PM, Dave Page wrote: >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Ashesh, Please find updated patch as discussed. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > As discussed please find

Re: [pgadmin-hackers] backports.csv

Hi Dave, I am not sure on this. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 12, 2017 at 5:32 PM, Dave Page wrote: > Hi Murtuza, > > Your recent addition of backports.csv to the pgAdmin requirements.txt > seems to be caus

[pgadmin-hackers] backports.csv

Hi Murtuza, Your recent addition of backports.csv to the pgAdmin requirements.txt seems to be causing an interesting problem. Whilst it works fine in a regular Python environment, in the cut-down environment used by the desktop runtime it fails because there is no backports/__init__.py file. This

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

On Fri, May 12, 2017 at 5:00 PM, Dave Page wrote: > > > On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Below code snippet from above commit assumes that we have to disable last >> row after saving. >> >> @@ -2320,6 >>

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Below code snippet from above commit assumes that we have to disable last > row after saving. > > @@ -2320,6 >

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

Hi, Below code snippet from above commit assumes that we have to disable last row after saving. @@ -2320,6 +2340,10

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

Thanks, applied. On Fri, May 12, 2017 at 11:59 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch with changes as per comments given by Joao. > > @Joao, > Thank you for reviewing the patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: h

[pgadmin-hackers] pgAdmin 4 commit: Hide menu options for creating objects, if the object

Hide menu options for creating objects, if the object type is set to hidden. Includes Jasmine tests. Fixes #2225 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aea0d933903b3eb469e41a00f3d6c556f5bbcb57 Author: Murtuza Zabuawala Modified File

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

Hi, Please find updated patch with changes as per comments given by Joao. @Joao, Thank you for reviewing the patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 11, 2017 at 8:19 PM, Joao Pedro De Almeida Pereira < jdealmei

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #103

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Fri, May 12, 2017 at 3:41 PM, Dave Page wrote: > Hi, > > Couple of comments: > > - Can we improve the speed of this test? Perhaps by adding multiple rows > to the table at once, then checking the result after a single save/refresh? > We need to keep the feature tests as fast as possi

[pgadmin-hackers] pgAdmin 4 commit: Minor colour tweaks for highlighted rows in the data

Minor colour tweaks for highlighted rows in the data editor. These are likely to be changed again when we overhaul and standardise the colouring, but at least now they're using colours from the style guide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #104

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Updated psycopg2 version for PostgreSQL 10 compatibil

Updated psycopg2 version for PostgreSQL 10 compatibility. Fixes #2377 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f903ba23104a42458585564aa53243d871cfc3d Modified Files -- requirements.txt | 2 +- 1 file changed, 1 insertion(+)

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi, Couple of comments: - Can we improve the speed of this test? Perhaps by adding multiple rows to the table at once, then checking the result after a single save/refresh? We need to keep the feature tests as fast as possible to ensure they remain practical to run. - I get the following failure

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #102

See Changes: [Dave Page] Properly handle non-ASCII column names in CSV. Fixes #2314 [Dave Page] Improve handling of nulls and default values in the data editor. Fixes -

[pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

Improve handling of nulls and default values in the data editor. Fixes #2257 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f9628ed436de53b1ab1a06b123755a86a8f2288 Author: Surinder Kumar Modified Files -- .../tables/templates/co

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Sure. I am reviewing it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, May 12, 2017 at 3:09 PM, Dave Page wrote: > Ashesh, can you ge

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Ashesh, can you get this in today please? Thanks. On Fri, May 12, 2017 at 7:07 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > As discussed please find updated patch removing hardcoded check for server > & server-group node. > > -- > Regards, > Murtuza Zabuawa

[pgadmin-hackers] pgAdmin 4 commit: Properly handle non-ASCII column names in CSV. Fixes

Properly handle non-ASCII column names in CSV. Fixes #2314 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05787fdba98d7c7e614a521f6aa0cf4ebe519d29 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__in

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issues with CSV file download

Thanks - patch applied. On Thu, May 11, 2017 at 3:21 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find patch to handle non-ascii column names in CSV for Pyhton2. > > Thanks to Harshal for pointing out the issue. > > > -- > Regards, > Murtuza Zabuawala >