Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-25 Thread Ashesh Vashi
On Wed, May 17, 2017 at 8:35 PM, Dave Page wrote: > > > On Wed, May 17, 2017 at 11:41 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Joao, >> >> Yes, this patch is related to browser tree issue, In this patch we have >> fixed some issues with 'onUpdateTreeNode' function to handle some co

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-05-25 Thread Surinder Kumar
On Fri, May 26, 2017 at 3:02 AM, Dave Page wrote: > On Tue, May 23, 2017 at 4:21 PM, Dave Page wrote: > > > > I'm actually thinking that maybe it would be easier to start with the > > CSS files > > Which i did yesterday. However, it soon became obvious that that isn't > so easy either, as th

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #121

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #242

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #119

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-25 Thread Joao Pedro De Almeida Pereira
Hello Surinder, We are having issues running the tests, this is the error that we are getting: File "/Users/pivotal/workspace/pgadmin4/web/regression/python_test_utils/test_utils.py", line 196, in create_table_with_query pg_cursor.execute(query) ProgrammingError: role "postgres" does not e

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #120

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #122

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-05-25 Thread Dave Page
On Tue, May 23, 2017 at 4:21 PM, Dave Page wrote: > > I'm actually thinking that maybe it would be easier to start with the > CSS files Which i did yesterday. However, it soon became obvious that that isn't so easy either, as the CSS files contain url references which need to be adjusted, whi

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #129

2017-05-25 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix typo in freshly added check.

2017-05-25 Thread Dave Page
Fix typo in freshly added check. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f097cd016b305ca997a9a32c27b2586486fad61 Modified Files -- web/pgadmin/browser/server_groups/servers/tablespaces/__init__.py | 2 +- 1 file changed, 1

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #118

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 262.96 KB...] Get materialized view under sche

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #121

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 263.10 KB...] Get materialized view under sche

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #119

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 262.93 KB...] Get materialized view under sche

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #240

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 265.94 KB...] Get materialized view under sche

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #119

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 262.91 KB...] Get materialized view under sche

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-25 Thread Dave Page
Hi The tests failed on both PG 9.4 and 9.6 for me :-( == ERROR: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest) Validate Insert, Update operations in View data with given test data

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #128

2017-05-25 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add numerous missing checks to ensure objects really exist when we think -- [...truncated 262.98 KB...] Get materialized view under sche

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] To fix error in SQL panel

2017-05-25 Thread Dave Page
Thanks applied. On Thu, May 25, 2017 at 6:20 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue which due to python side validations, at many > places it was assumed that we will always get a row from query result. > RM#2427 > > Note: Almost all the database level nodes are affecte

[pgadmin-hackers] pgAdmin 4 commit: Add numerous missing checks to ensure objects really

2017-05-25 Thread Dave Page
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9da157cc77b493bda9623a3a4b775bcfec322ab Author: Murtuza Zabuawala Modified Files -- we

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-25 Thread Dave Page
Hi What are the sleeps in pgadmin_page.py for? Can we get rid of them? On Thu, May 25, 2017 at 6:06 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Thu, May 11, 2017 at 2:41 PM, Dave Page wrote: >> >> Hi >> >> On Thu, May 11, 2017 at 6:3

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-25 Thread Surinder Kumar
Hi Please find attached patch for Feature test cases. The approach is to create a single table 'defaults' with columns of various types(number, text, json and boolean) and write test cases for these cell types with different input values. Following are the test cases covered: 1) Add a new row,

[pgadmin-hackers] [pgAdmin4] [PATCH] To fix error in SQL panel

2017-05-25 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue which due to python side validations, at many places it was assumed that we will always get a row from query result. RM#2427 *Note:* Almost all the database level nodes are affected by this patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

2017-05-25 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Thu, May 11, 2017 at 2:41 PM, Dave Page wrote: > Hi > > On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> As we have been facing many issues with different data-type display