Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi On Sat, May 27, 2017 at 4:03 PM, Surinder Kumar wrote: > Hi Dave > > Please find update Feature test cases patch. > > On Sun, May 28, 2017 at 12:40 AM, Dave Page wrote: >> >> Thanks - I committed the code changes, as they seem to work very well. >> The regression tests are failing for me thou

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave Please find update Feature test cases patch. On Sun, May 28, 2017 at 12:40 AM, Dave Page wrote: > Thanks - I committed the code changes, as they seem to work very well. > The regression tests are failing for me though :-(. Can you take > another look please? Note that I'm running under

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Thanks - I committed the code changes, as they seem to work very well. The regression tests are failing for me though :-(. Can you take another look please? Note that I'm running under Python 2.7 on Mal == ERROR: runTest (pgadmin

[pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

Cleanup handling of default/null values when data editting. FIxes #2400 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f26953504a963d2c2223c51f9da29db4d48594b Author: Surinder Kumar Modified Files -- .../static/js/slickgrid/slic

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Sat, May 27, 2017 at 9:02 AM, Surinder Kumar wrote: > Hi Dave, > On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: >> >> Hi >> >> OK, so we're getting somewhere now :-). Here's what I found: >> >> - The grid looks and feels great now. Selection works nicely, and >> copying rows seems to work w

[pgadmin-hackers] pgAdmin 4 commit: Increase feature test timeouts.

Increase feature test timeouts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10caae4dc699511a03461814ee94b5fb310a7675 Author: George Gelashvili Modified Files -- web/regression/feature_utils/pgadmin_page.py | 11 +++ 1 f

Re: [pgadmin-hackers] feature test timeouts

Thanks, patch applied. On Fri, May 26, 2017 at 6:26 PM, George Gelashvili wrote: > Hello Hackers, > > We are running tests including feature tests in Circle CI, and have been > seeing some flakiness due to what we believe are insufficient wait-for > timeouts. > > This shouldn't increase the overa

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave Please find updated Feature test case and review. This patch is dependent on RM_2400v2.patch On Fri, May 26, 2017 at 8:45 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao, > > On May 26, 2017 8:33 PM, "Joao Pedro De Almeida Pereira" < > jdealmeidapere...@pivotal.io

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave, On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: > Hi > > OK, so we're getting somewhere now :-). Here's what I found: > > - The grid looks and feels great now. Selection works nicely, and > copying rows seems to work well. > > - Patch 5 doesn't apply - but only to slick.grid.js. I manu