Re: [pgadmin-hackers] feature test timeouts

2017-05-28 Thread Murtuza Zabuawala
Hi Dave, With latest pull, PG data-type test fails on my system, == ERROR: runTest (pgadmin.feature_tests.pg_datatype_validation_test. PGDataypeFeatureTest) Test checks for PG data-types output ---

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-28 Thread Surinder Kumar
Hi Dave, The grid was being re-rendered after add new row and copy/paste to add a blank row in the end of grid, but in case of copy/paste batch operation it should run once, so that code is moved out of addNewRow(...) and put into a function grid.addBlankRow() and called separately for copy/paste

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-28 Thread Dave Page
Sorry guys - can you please remove the Grunt part of this until we've decided whether or not we want to use it at all? (see the thread discussing optimisation with Surinder). For now, let's just drop the required packages into the vendor directory. I'm happy to have that populated by yarn to avoid

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-05-28 Thread Dave Page
On Fri, May 26, 2017 at 12:01 AM, Surinder Kumar wrote: > On Fri, May 26, 2017 at 3:02 AM, Dave Page wrote: >> >> On Tue, May 23, 2017 at 4:21 PM, Dave Page wrote: >> > >> > I'm actually thinking that maybe it would be easier to start with the >> > CSS files >> >> Which i did yesterday. Howe

Re: [pgadmin-hackers] Autoformatting

2017-05-28 Thread Dave Page
On Sun, May 28, 2017 at 11:54 AM, Robert Eckhardt wrote: > > > On Tue, May 9, 2017 at 4:26 AM, Dave Page wrote: >> >> >> Anyhoo, The standard we try to use in pgAdmin at the moment is slightly >> different from the example you've given. To add it into the mix... >> >> /* Keywords Upper, 4 space i

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-28 Thread Dave Page
On Sun, May 28, 2017 at 1:25 PM, Harshal Dhumal wrote: > Hi, > > This commit has some performance issues with row paste functionality. > For 2K copied rows with 3 columns (2 integer and one null column) it took > near about 10 seconds to complete paste operation. And entire application > becomes u

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-28 Thread Harshal Dhumal
Hi, This commit has some performance issues with row paste functionality. For 2K copied rows with 3 columns (2 integer and one null column) it took near about 10 seconds to complete paste operation. And entire application becomes unresponsive for those 10 seconds. This is mainly because for each

Re: [pgadmin-hackers] Autoformatting

2017-05-28 Thread Robert Eckhardt
On Tue, May 9, 2017 at 4:26 AM, Dave Page wrote: > > Anyhoo, The standard we try to use in pgAdmin at the moment is slightly > different from the example you've given. To add it into the mix... > > /* Keywords Upper, 4 space indent, commas after, AND/OR after, > * no spaces after ( or before ),