[pgadmin-hackers] [pgAdmin4][PATCH] To enable dialog help option for Language and Foreign table node

Hi, PFA minor patch to enable dialog help option for Language and Foreign table node. RM#2116 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/languages/templates/languages/j

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Joao On Wed, May 31, 2017 at 1:19 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello > > We have rebased the patches against master again, which includes > Surinder's fix for RM2400 . > These patches should now apply aga

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Wed, May 31, 2017 at 12:01 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > The motivation is simple - we want a solution that works for the whole >> app, can handle debug vs. release execution, pluggable modules, and >> installations in read-only directories. > > With

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

> > The motivation is simple - we want a solution that works for the whole > app, can handle debug vs. release execution, pluggable modules, and > installations in read-only directories. With the current configuration of Grunt, all the requirements you mention are available. The tasks on Grunt sho

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

Hi, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 9:13 PM, Dave Page wrote: > On Mon, May 29, 2017 at 10:31 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA attach patch to ad

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #136

See Changes: [Dave Page] Avoid re-rendering the edit grid for every row that is pasted. -- [...truncated 254.53 KB...] runTest (pgadmin.browser.server_groups.ser

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

On Mon, May 29, 2017 at 10:31 AM, Murtuza Zabuawala wrote: > Hi, > > PFA attach patch to add property into trigger node to display if trigger is > enabled or disabled in Properties panel and also in dialog. > RM#2386 The switch is added, but I cannot toggle it from the dialogue. Can you fix that

Re: [pgadmin-hackers] [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps

Hi On Mon, May 29, 2017 at 8:52 AM, Surinder Kumar wrote: > Hi > > Issue: > > If modules are loaded without any node dependency(i.e: on page load), the > function 'create_menu' is called implicitly to generate menu items. > > But when the modules are loaded when its dependent node expands, the >

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

Thanks, applied. On Mon, May 29, 2017 at 7:08 AM, Surinder Kumar wrote: > Hi Dave, > > The grid was being re-rendered after add new row and copy/paste to add a > blank row in the end of grid, but in case of copy/paste batch operation it > should run once, so that code is moved out of addNewRow(..

[pgadmin-hackers] pgAdmin 4 commit: Avoid re-rendering the edit grid for every row that i

Avoid re-rendering the edit grid for every row that is pasted. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=456096092d7fac8cc592003d930e06ea86eaa23c Author: Surinder Kumar Modified Files -- .../sqleditor/templates/sqleditor/js/

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

I've applied the patch from Neel for this in commit:6e24cb038a0498cf87219104368dfcea40630440 and put a test build at https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe. Please test! Thanks Neel! On Wed, May 24, 2017 at 6:53 PM, Dave Page wrote: > Good catch - thanks Neel. I don't have my

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Tue, May 30, 2017 at 2:47 PM, Matthew Kleiman wrote: > Hi Dave, > > We are currently using the Grunt taskrunner to run the following tasks: > > lint the javascript code > start javascript tests > invoke webpack to transpile and bundle js and jsx files > minify javascript > > In order to rem

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, We are currently using the Grunt taskrunner to run the following tasks: - lint the javascript code - start javascript tests - invoke webpack to transpile and bundle js and jsx files - minify javascript In order to remove Grunt from the application, we will need some other to

[pgadmin-hackers] pgAdmin 4 commit: Ensure the runtime works correctly if a Windows user

Ensure the runtime works correctly if a Windows user has a proxy server enabled. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e24cb038a0498cf87219104368dfcea40630440 Author: Neel Patel Modified Files -- runtime/pgAdmin4.cpp |

[pgadmin-hackers] [pgAdmin4][Patch] To display proper SQL for Procedure node

Hi, PFA patch to fix to display procedure options like IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED in SQL (Reverse Engineered). RM#2280 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_grou

Re: [pgadmin-hackers] feature test timeouts

Hi OK. Do you know why? What's it waiting for? It was working for me (I always run tests multiple times before committing them, to try to ensure they're reliable). On Mon, May 29, 2017 at 7:23 AM, Murtuza Zabuawala wrote: > Hi Dave, > > With latest pull, PG data-type test fails on my system, > >

Re: [pgadmin-hackers] Issue about pgadmin4

On Mon, May 29, 2017 at 9:14 AM, Archit PCE2/CE/14/011 < 2014pceevncsarc...@poornima.org> wrote: > sir, > There is an issue in pgadmin4 which I am download from your > site.currently, I am downloaded this on my windows 8.1 64 bit you have to > look at the screenshot which is attached to this

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 12:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore this patch as I forgo

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please ignore this patch as I forgot to include few changes. I'll send updated one. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 29, 2017 at 3:18 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.co