Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-31 Thread Matthew Kleiman
Hey Surinder, Is it possible to run the task listed above by configuring them in > "scripts" in package.json file and running concurrently ? That would be cleaner than what we proposed. We could use the yarn run feature to do just what you are suggesti

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-05-31 Thread Shirley Wang
On Wed, May 31, 2017 at 11:55 AM Dave Page wrote: > On Wed, May 31, 2017 at 2:27 PM, Shirley Wang wrote: > >> >>> When you say "icon" here, are you talking about the combo box arrow, or >>> icons on the items themselves? The latter are often useful if you have >>> items of different types in the

[pgadmin-hackers] Style guide live website - looking for feedback

2017-05-31 Thread Shirley Wang
Hi all, We've started compiling some of the agreed upon styles into a site that is accessible for all developers. Link to the site: http://pgadmin4-styleguide.cfapps.io/index.html As of now, we have colors, type, and alerts documented. Other styles will be added and where the style guide lives w

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #127

2017-05-31 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix permissions on some files. -- [...truncated 254.48 KB...] runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.tes

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #137

2017-05-31 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-05-31 Thread Dave Page
On Wed, May 31, 2017 at 2:27 PM, Shirley Wang wrote: > >> When you say "icon" here, are you talking about the combo box arrow, or >> icons on the items themselves? The latter are often useful if you have >> items of different types in the same list. >> >> I think we should have the combo box arro

[pgadmin-hackers] pgAdmin 4 commit: Fix permissions on some files.

2017-05-31 Thread Dave Page
Fix permissions on some files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b23a7912ac5e363af9c142efea2f63ced398d3f Modified Files -- docs/en_US/images/query_execute_section.png | Bin docs/en_US/images/query_output_explain.png

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in index or exclusion contrarians node

2017-05-31 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in index or exclusion contrarians node where it was throwing "can't execute an empty query" error due to incorrect validation logic for edit mode. RM#2113 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2425 : Can't delete rows when using composite primary key

2017-05-31 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #2425 : Can't delete rows when using composite primary key. The grid selection checking for Primary key does not honour the composite key which has been fixed. Thanks, Khushboo diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin4 and boolean columns

2017-05-31 Thread Dave Page
Yeah, this problem annoyed me last week. It seems the checkbox value doesn't cycle consistently; it should always go false -> true -> null -> ..., but I think what it was doing was current value -> false -> true -> null or similar, so it could take 3 clicks to get to null. (the ordering above may

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin4 and boolean columns

2017-05-31 Thread Surinder Kumar
Adding pgadmin-hackers On Wed, May 31, 2017 at 2:43 PM, Nigel Tucker wrote: > Hi Surindar – nice to talk! > > > > Yep – I’m running 1.5 at present – the issue RM2218 sounds similar but > isn’t actually the same – my issue was related to the number of times you > have to select the Boolean cell t