[pgadmin-hackers] [pgAdmin4][PATCH] To fix the spacing issue in SQL for Event trigger

2017-06-01 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue of extra spacing in generated SQL in Event trigger. RM#1229 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/event_triggers/__init__.py

Re: [pgadmin-hackers] Process for Creating Translations

2017-06-01 Thread Dave Page
Hi On Thu, Jun 1, 2017 at 4:40 PM, Shruti B Iyer wrote: > Hi Hackers, > > In the patches we sent recently, we added text to the User Interface. We > know that calling getText translates it but currently we don't have > translations for any of the new text. > > Is there a process for getting these

[pgadmin-hackers] Process for Creating Translations

2017-06-01 Thread Shruti B Iyer
Hi Hackers, In the patches we sent recently, we added text to the User Interface. We know that calling getText translates it but currently we don't have translations for any of the new text. Is there a process for getting these text translated to other languages? Thanks, Shruti & Joao

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-01 Thread Robert Eckhardt
Awesome, thanks. -- Rob On Thu, Jun 1, 2017 at 11:13 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Robert, > > On Jun 1, 2017 8:22 PM, "Robert Eckhardt" wrote: > > > > Surindar, > > > > Have you sent this patch and I'm missing it or is it still in flight for > you? > I have

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-01 Thread Surinder Kumar
Hi Robert, On Jun 1, 2017 8:22 PM, "Robert Eckhardt" wrote: > > Surindar, > > Have you sent this patch and I'm missing it or is it still in flight for you? I have found the solution, will test that patch and hopefully by tomorrow I will send. > > -- Rob > > On Wed, May 31, 2017 at 1:02 AM, Surind

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-01 Thread Dave Page
On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman wrote: > Hi Hackers! > > We noticed that there have been quite a few Redmine issues that ended up > being related to the same function in sqleditor.js. We were wondering if > it might be a good idea to extract this function and test it. This would >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-01 Thread Robert Eckhardt
Surindar, Have you sent this patch and I'm missing it or is it still in flight for you? -- Rob On Wed, May 31, 2017 at 1:02 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao > > On Wed, May 31, 2017 at 1:19 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io>

[pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-01 Thread Matthew Kleiman
Hi Hackers! We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-01 Thread Murtuza Zabuawala
On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > > On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Please include Type node and Foreign Table node in your fix :-) >> >> I don't think Type node req

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of issue descriptions.

2017-06-01 Thread Dave Page
Fix a couple of issue descriptions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12fa023c6d63c9e065708d8af2a27cedb9257456 Modified Files -- docs/en_US/release_notes_1_2.rst | 2 +- docs/en_US/release_notes_1_3.rst | 2 +- 2 files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-01 Thread Khushboo Vashi
Hi, On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Khushboo, > > Please include Type node and Foreign Table node in your fix :-) > > I don't think Type node requires this change. Foreign table changes added in the attached updated patch. > -

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #128

2017-06-01 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add documented release notes.

2017-06-01 Thread Dave Page
Add documented release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54760ef3bb42d027db103e6fee71859e3dbec377 Author: Karen Blatchley Modified Files -- docs/en_US/index.rst | 1 + docs/en_US/release_notes.rst

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-01 Thread Murtuza Zabuawala
Hi Khushboo, Please include Type node and Foreign Table node in your fix :-) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find t

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-01 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #2324 : PostGIS datatypes not showing up properly on SQL tab. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py