Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: > Hi > > With this patch applied, it uses the field names instead of the labels > in error messages - e.g. > > 'dirty_rate_limit' must be numeric > > instead of: > > 'Dirty Rate Limit (KB)' must be numeric. > Fixed. Please find attached update

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer wrote: > Hi Surinder, > > On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt > wrote: > >> On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi Matthew, >>> >>> Couple of review comments: >>> 1) Click

[pgadmin-hackers] [PATCH] extract function from sqleditor

Hello Hackers! Re. https://www.postgresql.org/message-id/CAFS4TJb- 7VTQQrnOi0g6MaoxMfEK9LzCds2yG%2BByS-mLHwydQA%40mail.gmail.com We extracted the function bound to onSelectedRangesChanged from sqleditor! - we read through the existing implementation and wrapped it in `web/regression/javascript/s

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Surinder, On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt wrote: > On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Matthew, >> >> Couple of review comments: >> 1) Clicking on a new added row(after save) results in console error - >> screenshot

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Matthew, > > Couple of review comments: > 1) Clicking on a new added row(after save) results in console error - > screenshot attached. > We'll check this out as soon as we can. > 2) If i drag to select

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi Surinder! We reviewed this patch. The changes look good and we especially like that you have extracted out the new utility functions and the epicRandomString function too. This patch will likely affect the Query Results patch that is currently under review

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

I guess what I didn't say is YES. What Akshay and Ashesh are building is going to absolutely be fundamental to any workflows being defined in these interviews. -- Rob On Mon, Jun 5, 2017 at 12:17 PM, Robert Eckhardt wrote: > On Mon, Jun 5, 2017 at 11:45 AM, Dave Page wrote: > >> >> >> The form

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Mon, Jun 5, 2017 at 11:45 AM, Dave Page wrote: > > > The former is what I was bleating about when I said we needed to expose > partitions to the user. The latter isn't relevant - declarative > partitioning in Postgres doesn't use inheritance. > The former is certainly the most interesting. W

[pgadmin-hackers] pgAdmin 4 commit: Display and allow toggling of trigger enable/disable

Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e98ded06c2c80968522db1c731e941a5b8d5f32 Modified Files -- .../templates/trigger/sq

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

Thanks, applied. On Tue, May 30, 2017 at 5:20 PM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch for the same. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, May 30, 2017 at 9:13 PM, Dave Page wrote: >> >> O

Re: [pgadmin-hackers] [pgAdmin4][Patch] To display proper SQL for Procedure node

Thanks, patch applied. On Tue, May 30, 2017 at 10:13 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix to display procedure options like IMMUTABLE STRICT SECURITY > DEFINER PARALLEL RESTRICTED in SQL (Reverse Engineered). > RM#2280 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http:

[pgadmin-hackers] pgAdmin 4 commit: Handle procedure flags (IMMUTABLE STRICT SECURITY DEF

Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f150f3f4ec395e62db3f51accb601539863b5f1 Author: Murtuza Zabuawala Modifie

Re: [pgadmin-hackers] [pgAdmin4][Patch] Make Statistics view consistent

Thanks, applied. On Mon, May 29, 2017 at 12:38 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where we were not displaying correct statistics > data for collection nodes. > RM#2357 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterpris

[pgadmin-hackers] pgAdmin 4 commit: Cache statistics more reliably. Fixes #2357

Cache statistics more reliably. Fixes #2357 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4d86d24e6e664075d85461d816504c9d322f648 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/statistics/static/js/statistics.js |

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi With this patch applied, it uses the field names instead of the labels in error messages - e.g. 'dirty_rate_limit' must be numeric instead of: 'Dirty Rate Limit (KB)' must be numeric. Thanks. On Tue, May 30, 2017 at 8:28 AM, Harshal Dhumal wrote: > Hi, > > Please find updated patch. > > -

[pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi Hackers Attached are two patches for styling improvements. 1-add-style-guide.patch contains the initial css from the style guide. As we make further style changes, this file will be updated. 2-change-grays.patch changes the gray color elements in the app to the ones in the new style guide. Tha

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

Hi On Mon, Jun 5, 2017 at 4:34 PM, Shirley Wang wrote: > Hi! > > Here's a summary of the interviews thus far: > > DBAs tend to create a partition strategy based on their experience and > some alignment on their end users goals (analysts, report writers, and app > developers). Once that partition

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

Hi! Here's a summary of the interviews thus far: DBAs tend to create a partition strategy based on their experience and some alignment on their end users goals (analysts, report writers, and app developers). Once that partition strategy is created, they are usually forced to iterate on that strat

Re: [pgadmin-hackers] Style guide live website - looking for feedback

On Wed, May 31, 2017 at 7:39 PM, Shirley Wang wrote: > Hi all, > > We've started compiling some of the agreed upon styles into a site that is > accessible for all developers. > > Link to the site: http://pgadmin4-styleguide.cfapps.io/index.html > > As of now, we have colors, type, and alerts docum

[pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Staged changes are missed in previous patch, so please ignore. Please find attached updated patch. On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > This patch contains two fixes: > > 1) In Query/tool or Edit grid, the width of table column header i

[pgadmin-hackers] [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi This patch contains two fixes: 1) In Query/tool or Edit grid, the width of table column header is fixed depending on the column type(int, boolean, char etc.) due to which the column name or type appears cut from right and doesn't looks good from user point of view. The main concern was to disp

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Synonym node EPAS9.2

Hi, PFA patch to fix the issue in Synonym node for EPAS9.2+ where Packages are not displaying as a target objects. RM#1813 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/s

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2381 - "Create Script" for view assigns incorrect schema to trigger functions in "public" schema.

Hi, Please find the attached patch to fix RM 2381: "Create Script" for view assigns incorrect schema to trigger functions in "public" schema. Fixed the trigger function schema name in the view SQL tab. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/vie

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hi Dave, Please find attached patch for minifying CSS files and optimize images using Webpack. *Steps to run:* 1) After applying patch, go to web directory and run npm install on terminal to install packages which are used to parse/minify CSS files. 2) Run npm run build which creates dist folde

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

On Fri, Jun 2, 2017 at 3:40 PM, Matthew Kleiman wrote: > We are working on this now. Should I open a bug or a feature in redmine to > track this work publicly or just keep it in our backlog only? I don't think it needs an RM - users aren't likely to care about it. -- Dave Page Blog: http://pgsn

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Fri, Jun 2, 2017 at 9:01 AM, Akshay Joshi wrote: > Hi All > > Following are the further implementation updates to support Declarative > Partitioning: > >- Show all the existing partitions of the parent table in Partitions >tab (Refer Existing_Partitions.png) >- Ability to create N

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi, Fixed PostGIS datatype on SQL tab for Table, column, Foreign Table and Type node. Please find the attached updated patch. Thanks, Khushboo On Thu, Jun 1, 2017 at 6:36 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi < >

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in procedure debugging in EPAS

Hi, PFA patch to fix the issue where debugger module is not throwing proper error for unsupported argument mode type in procedure. RM#1466 @Neel, Can you please do quick review of this patch? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compan