[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #283

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard module. -- [...truncated 272.94 KB...] ===

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #165

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard module. -- [...truncated 270.86 KB...] assert response.status_code

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #159

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard module. -- [...truncated 270.38 KB...] ===

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the Gra

2017-06-12 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the Grant-Wizard module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0243d886c3cd01d8ca4d2941edf063c39affd1e6 Modified Files -- web/pgadmin/tools/grant_wizard/__init__.py |

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #164

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the module - bgprocess [Ashesh Vashi] Using client-side 'url_for' implementation in the backup module. [Ashesh Vashi] Using cl

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Khushboo Vashi
Hi, On Mon, Jun 12, 2017 at 5:27 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch to reset the zoom level in the desktop > > runtime. > > > > Added the new shortcut CTRL + 0 to reset the zoom level. > > The cod

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #158

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the module - bgprocess [Ashesh Vashi] Using client-side 'url_for' implementation in the backup module. [Ashesh Vashi] Using cl

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #282

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the module - bgprocess [Ashesh Vashi] Using client-side 'url_for' implementation in the backup module. [Ashesh Vashi] Using cl

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the bac

2017-06-12 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the backup module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a46f7b1eb7246f34f05b1bf2a2429c2cff7ea9e Modified Files -- web/pgadmin/tools/backup/__init__.py| 15 ++

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the res

2017-06-12 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the restore module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9a387822047f862b01fb62e879b071b1e3c3c00 Modified Files -- web/pgadmin/tools/restore/__init__.py |

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mod

2017-06-12 Thread Ashesh Vashi
Using client-side 'url_for' implementation in the module - bgprocess (background-processes). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a7c9d5ca1e0d92c113b093aa5cf2c2a34092b59 Modified Files -- web/pgadmin/misc/bgprocess/__in

[pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-12 Thread Surinder Kumar
Hi Changes: 1) When Query tool is opened, right now - panel title is displayed as "Query - 1 ", instead it should display Query - [db_name] on [server_name] as in pgAdmin3. 2) When Edit grid is opened for table, the panel title should display Edit Data - [server_name] - [db_name] - [table_name]

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Khushboo Vashi
Hi, On Mon, Jun 12, 2017 at 8:24 PM, Dave Page wrote: > Hi Khushboo, > > Looks like this patch broke the regressions tests :-(. Can you take a look > ASAP please? > > please find the attached fix. However I didn't get any error while running regression tests. > Thanks! > > 2017-06-12 10:04:11,9

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira
Hello Hackers, We sent the wrong patch. Attached is the correct one. Sorry Shruti & Joao On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We were trying to run the feature tests against GreenPlum and one of the > tests was f

[pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira
Hi Hackers, We were trying to run the feature tests against GreenPlum and one of the tests was failing (CheckForViewDataTest). In this test, we are creating a table using COLLATE, and the COLLATE command is only available starting in version 9.1 of Postgres, per the documentation. We decided to sk

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Shruti B Iyer
Hi Dave, We regenerated the patch to add new tasks to package.json to compile react code for development and to not minimize it. This should fix the error you captured in the screenshot. The new task to lint and bundle everything for development is: yarn run bundle:dev The new task only bundle e

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #157

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #153

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Shirley Wang
> > >> >> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > The current font-family applied to slick-grid is >> 'Verdana,Arial,sans-serif'. >> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif >> but >> > the font size and spacing between text is red

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #163

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #159

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #160

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #281

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call. --

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Dave Page
Thanks, applied. On Mon, Jun 12, 2017 at 4:43 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a minor patch that wraps with gettext() the "Select/Deselect > All" text in the top left corner of the query results grid. > > Thanks, > Matt and Shruti > > > -- > Sent via pgadmin-hackers mailing

[pgadmin-hackers] pgAdmin 4 commit: Bring React into the tree, and add linting and bundli

2017-06-12 Thread Dave Page
Bring React into the tree, and add linting and bundling framework for the JS etc. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659eb1c1e821e2ea414dc00d22022b8a2d7c91f7 Author: Shruti B Iyer Modified Files -- .gitignore

[pgadmin-hackers] pgAdmin 4 commit: Add a missing translation call.

2017-06-12 Thread Dave Page
Add a missing translation call. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1acad85db4b9bf8a201cd8b6d90c703322a0073 Author: Shruti B Iyer Modified Files -- web/pgadmin/static/js/selection/grid_selector.js | 5 +++-- 1 file cha

[pgadmin-hackers] pgAdmin 4 commit: Add linting support, and, well, lint.

2017-06-12 Thread Dave Page
Add linting support, and, well, lint. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4f8b9e77204a62ecdbf99caf296b6ac39b0f5e Author: Shruti B Iyer Modified Files -- web/.eslintrc.js | 45 ++

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
To add to that; running the JS tests gives: ERROR in ./regression/javascript/history/query_history_entry_spec.jsx Module not found: Error: Can't resolve 'jasmine-enzyme' in '/Users/dpage/git/pgadmin4/web/regression/javascript/history' @ ./regression/javascript/history/query_history_entry_spec.jsx

[pgadmin-hackers] PACKAGERS BEWARE: Build changes required

2017-06-12 Thread Dave Page
I've just committed a couple of patches that change the requirements for building pgAdmin for packages: - You will need node.js and yarn to be installed for building - During the build process, do something like this: cd $PGADMIN_SRC/web yarn install yarn run bundle This will create web/node_mo

[pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Shruti B Iyer
Hi Hackers! Attached is a minor patch that wraps with gettext() the "Select/Deselect All" text in the top left corner of the query results grid. Thanks, Matt and Shruti query_results_gettext.diff Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Thanks, applied. On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > I confirm this is updated patch. >>

[pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save

2017-06-12 Thread Dave Page
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af43ccfc07bd1f919015b79ce9c9e7e06d92cf6a Author: Surinder Kumar Modified Files -- .../template

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
Hi Khushboo, Looks like this patch broke the regressions tests :-(. Can you take a look ASAP please? Thanks! 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 - Traceback (most recent call last): File "/Users

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar
Hi Dave, Please find updated patch. On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar > wrote: > > Hi > > > > I confirm this is updated patch. > > Thanks. Something else seems to have changed that I can't spot. Only > should be ignored

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
Hi Shruti On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer wrote: > > Hello Dave, > > Thanks for making those fixes and sharing them with us. We tried applying > the patch and it looks like there are some missing file changes from your > patch that were present in ours, like the Make.bat file chang

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Robert Eckhardt
Shirley and I are in SF this week so we will be even more async that usual. -- Rob On Mon, Jun 12, 2017 at 7:33 AM, Dave Page wrote: > Adding Shirley... > > Hi > > On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > wrote: > > Hi > > > > The current font-family applied to slick-grid is > 'Verdan

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page
Adding Shirley... Hi On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar wrote: > Hi > > The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but > the font size and spacing between text is reduced. so to

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Hi On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar wrote: > Hi > > I confirm this is updated patch. Thanks. Something else seems to have changed that I can't spot. Only should be ignored if a child control has focus - Escape and F1 should continue to work. I tried moving the: if (panel && pane

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Shruti B Iyer
Hello Dave, Thanks for making those fixes and sharing them with us. We tried applying the patch and it looks like there are some missing file changes from your patch that were present in ours, like the Make.bat file changes. But we will add them when we send you the new patches. While trying to g

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Dave Page
Thanks applied. On Mon, Jun 12, 2017 at 1:46 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Role Membership control, In edit mode > user was unable to toggle grant admin privileges to membership roles. > RM#2086 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: htt

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Surinder Kumar
Hi The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but the font size and spacing between text is reduced. so to match style I used "Verdana". Also, as per my knowledge, the Helvetica font will work

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #155

2017-06-12 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #150

2017-06-12 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar
Hi I confirm this is updated patch. PFA patch. On Mon, Jun 12, 2017 at 6:20 PM, Dave Page wrote: > Hi > > Is that the correct patch? Hitting in a comment text area is > still causing the dialogue to close.​ > Thanks. > > On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar > wrote: > > Hi > > >

[pgadmin-hackers] pgAdmin 4 commit: Allow editing of the WITH ADMIN option of role member

2017-06-12 Thread Dave Page
Allow editing of the WITH ADMIN option of role membership. Fixes #2086 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec5bc23dfdb41da1b5ccd4ab2ab2e6244d8b5ebd Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #156

2017-06-12 Thread pgAdmin 4 Jenkins
See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Hi Is that the correct patch? Hitting in a comment text area is still causing the dialogue to close. Thanks. On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar wrote: > Hi > > Please find rebased patch > > Thanks > > On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: >> >> Could you rebase this

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in Role Membership control, In edit mode user was unable to toggle grant admin privileges to membership roles. RM#2086 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/s

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page
Hi Can you update this so that the CSS all follows the standards in the WIP styleguide please? I see that the current patch is using the wrong font for example. http://pgadmin4-styleguide.cfapps.io/ Thanks! On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1) Calcul

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #154

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus [Dave Page] Properly handle trigger functions with parameters. Fixes #2043 [Dave Page] Refresh the SQL editor v

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #149

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus [Dave Page] Properly handle tri

[pgadmin-hackers] pgAdmin 4 commit: Refresh the SQL editor view on resize to ensure the c

2017-06-12 Thread Dave Page
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3743c6e86ed74b8ae6f4776f27e1555c4ee64e89 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Dave Page
Thanks, patch applied! On Mon, Jun 12, 2017 at 11:48 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where SQL Panel in query tool displays truncated > sql on resize. > RM#2078 > > Steps to re-produce the issue: > 1) Create table provided by user from RM. > 2) Right click on new

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Dave Page
Thanks, patch applied. On Mon, Jun 12, 2017 at 10:54 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Table node where it was not displaying > reversed engineered sql for Trigger(s) properly, if trigger function > associated with that trigger has parameters. > RM#2043 > > -- >

[pgadmin-hackers] pgAdmin 4 commit: Properly handle trigger functions with parameters. Fi

2017-06-12 Thread Dave Page
Properly handle trigger functions with parameters. Fixes #2043 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c435d488853b7b52f33b8d01fe98b5938e6fd835 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/tabl

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #155

2017-06-12 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Dave Page
Hi On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to reset the zoom level in the desktop > runtime. > > Added the new shortcut CTRL + 0 to reset the zoom level. The code looks good, however I don't think resetting to the startup value is really wh

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar
Hi Please find rebased patch Thanks On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar > wrote: > > Ignore previous patch as it doesn't contains new changes. > > Please find attached patch. > > > >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

2017-06-12 Thread Dave Page
Thanks Atul, patch applied. On Fri, Jun 9, 2017 at 1:34 PM, Atul Sharma wrote: > Hi Dave, > > I have made the template search code to work for 10_plus directory name. > Please review the attached patch > > Regards, > Atul. > > > > On Thu, Jun 8, 2017 at 7:55 PM, Dave Page wrote: >> >> Hi Atul, >

[pgadmin-hackers] pgAdmin 4 commit: Fix error on the stats tab with PG10. Also, rename th

2017-06-12 Thread Dave Page
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49cd578816ab45166556fcd46096671130939cc3 Author: Atul Sharm

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Could you rebase this please? Thanks. On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar wrote: > Ignore previous patch as it doesn't contains new changes. > Please find attached patch. > > > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar > wrote: >> >> Hi >> >> PFA patch and review. >> >> >> On F

[pgadmin-hackers] pgAdmin 4 commit: Fix the PostGIS Datatypes in SQL tab, Create / Update

2017-06-12 Thread Dave Page
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324 Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pg

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
Thanks, applied. On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for > Table, Column, Foreign Table and Type node. > > Regarding the r

[pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Surinder Kumar
Hi Changes: 1) Calculate text editor position properly when the size of the grid exceeds the size of the window. 2) Assign NumberEditor to cell types('oid', 'xid', 'real'). 3) Remove inline styles from rendered editors and move its styles to CSS file. Please find attached patch and review. Th

[pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where SQL Panel in query tool displays truncated sql on resize. RM#2078 Steps to re-produce the issue: 1) Create table provided by user from RM. 2) Right click on newly created table 3) Select 'Script' -> 'CREATE Script' 4) Drag the splitter down side to maximise SQ

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Table node where it was not displaying reversed engineered sql for Trigger(s) properly, if trigger function associated with that trigger has parameters. RM#2043 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

[pgadmin-hackers] pgAdmin 4 commit: Stop ignoring yarn.lock, per discussion with Pivotal

2017-06-12 Thread Dave Page
Stop ignoring yarn.lock, per discussion with Pivotal team. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59da69087cd32ea9e4996f87bae62c8c31dc632b Author: George Gelashvili Modified Files -- .gitignore| 1 - web/yarn.lock | 0

[pgadmin-hackers] pgAdmin 4 commit: Implementation of the client side 'url_for(...)' func

2017-06-12 Thread Ashesh Vashi
Implementation of the client side 'url_for(...)' function. Created a url_for function module to be used by different javascript modules to use the same functionality of flask at client side. A python module can expose the list of endpoints, used by its javascripts, by overriding the 'get_exposed_