Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, Please find attached patch where I have added timeout of 2 seconds before selecting object menu in connect to server function. Note: Apply this patch on top of previous patch for on demand loading feature. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.ent

[pgadmin-hackers] pgAdmin 4 commit: Using client-side implementation of 'url_for' in the

Using client-side implementation of 'url_for' in the settings module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=900ccebb50bdc448da5adad55fb513815b0a7b82 Modified Files -- web/pgadmin/settings/__init__.py | 3

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

On 05/11/2017 12:54 AM, Devrim Gündüz wrote: > > Hi, > > On Wed, 2017-05-10 at 10:02 -0700, Josh Berkus wrote: >> So to make this work, pgadmin-v1-web needs to be a completely separate >> package, no? > > I don't think so, we can define Requires: part separately. > > Give me some time please, l

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Sounds good, thanks. On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal wrote: > Hi > > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: >> >> Hi >> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal >> wrote: >> > Hi Dave, >> > >> > Please find attached updated patch. >> > >> > On Thu, Jun 15, 2

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: > Hi > > On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal > wrote: > > Hi Dave, > > > > Please find attached updated patch. > > > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Jun 14, 2017 at 11:36 PM, Har

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal wrote: > Hi Dave, > > Please find attached updated patch. > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: >> >> Hi >> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal >> wrote: >>> >>> Hi Dave, >>> >>> Please find rebased patch for RM2

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #171

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the use

Using client-side 'url_for' implementation in the user management module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c140b3f58980b6f1bba01e4ed8b7006fbd74af4 Modified Files -- web/pgadmin/tools/user_management/__init__.py

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #170

See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the maintenance module. -- [...truncated 262.27 KB...] runTest (pgadmin.browser.server

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the imp

Using client-side 'url_for' implementation in the import/export module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e65b605912194808a2530cc644367137240d1003 Modified Files -- web/pgadmin/tools/import_export/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mai

Using client-side 'url_for' implementation in the maintenance module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07580b844466e55c825178ce0385c82c57dff149 Modified Files -- web/pgadmin/tools/maintenance/__init__.py | 1

Re: [pgadmin-hackers][patch] History Detail Pane

Hi We use Qt 5.8 at the moment, with the updated QtWebKit TP5 release from https://github.com/annulen/webkit/releases. The issue occurs on Windows and Mac, and probably Linux as well. Test builds can be found here: https://developer.pgadmin.org/~dpage/debug/ On Thu, Jun 15, 2017 at 2:33 PM, Sara

[pgadmin-hackers] pgAdmin 4 commit: Fix Yarn tasks for Windows

Fix Yarn tasks for Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d45dee686056663795c0dbea5a310d8950df2e4 Modified Files -- Make-MinGW.bat | 4 ++-- Make.bat

Re: [pgadmin-hackers] Minor typo in web/config.py

Thanks, patch applied. On Thu, Jun 15, 2017 at 12:24 PM, Johan Van de Wauw wrote: > There is a minor typo in the web/config.py > > patch attached > > Kind Regards, > Johan > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > h

[pgadmin-hackers] pgAdmin 4 commit: Fix a typo in the config file

Fix a typo in the config file Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=827aa72e99364cf78f57d7ac1a906f644c961e5e Author: Johan Van de Wauw Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Dave! Just to verify, which version of QT are you using? The Readme calls for 5.5 at the newest. Could you send us the compiled version of the app? Are you only seeing this on Windows? Thanks, Sarah & Shruti & João On Wed, Jun 14, 2017 at 3:46 PM, Sarah McAlear wrote: > Sounds good! We're l

[pgadmin-hackers] Minor typo in web/config.py

There is a minor typo in the web/config.py patch attached Kind Regards, Johan From 3a47cd643789f7d09bed36f35091fc3b309498b4 Mon Sep 17 00:00:00 2001 From: Johan Van de Wauw Date: Tue, 13 Jun 2017 08:44:31 +0200 Subject: [PATCH] Fix typo --- web/config.py | 2 +- 1 file changed, 1 insertion(+),

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

Hi, Please find the attached patch to fix #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH. While running the feature tests, the separate process of the app does not honour the config settings which are in runtests.py file. Fix: As per Dave, no need to set TESTING_MODE in config

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

On Thu, Jun 15, 2017 at 4:51 PM, Dave Page wrote: > Thanks, applied. > > When you get some spare time (after the webpacking work that I believe > you're doing), could you please add a feature test (or modify a suitable > existing one) to ensure the various script options work as they should? > ​I

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Thanks, applied. When you get some spare time (after the webpacking work that I believe you're doing), could you please add a feature test (or modify a suitable existing one) to ensure the various script options work as they should? Thanks again! On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar

[pgadmin-hackers] pgAdmin 4 commit: Fix script options which were inadvertently broken in

Fix script options which were inadvertently broken in the query tool tab naming patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a87585665049fb67ca9d51fd949b3bd7d25b077 Author: Surinder Kumar Modified Files -- web/pgadmin/

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Hi Dave, Please find attached patch. It should work. In previous patch I was unaware that i added untracked file to tracked. On Thu, Jun 15, 2017 at 4:10 PM, Dave Page wrote: > Hi > > Was this patch generated against a WIP branch? I get: > > (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloa

[pgadmin-hackers] pgAdmin 4 commit: Add double precision[] tests to the query tool.

Add double precision[] tests to the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d70c3003d3fdadfbcfff4f677f25a9f3f35471cd Author: Murtuza Zabuawala Modified Files -- .../feature_tests/pg_datatype_validation_test.py

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

Thanks, applied. On Thu, Jun 15, 2017 at 11:47 AM, Murtuza Zabuawala wrote: > HI Dave, > > Please find the patch for the added feature test for handling of RM#1928 > datatype issue, other misc changes are for PEP-8. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

HI Dave, Please find the patch for the added feature test for handling of RM#1928 datatype issue, other misc changes are for PEP-8. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 7:21 PM, Dave Page wrote: > Thank

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

Thanks, applied. On Thu, Jun 15, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Grant wizard, In IE browser grant wizard > do not close if user tries to close it by clicking Cancel button or Close > button. > RM#2142 > > -- > Regards, > Murtuza Zabuawala >

[pgadmin-hackers] pgAdmin 4 commit: Fix canceling of Grant Wizard on Windows. Fixes #2142

Fix canceling of Grant Wizard on Windows. Fixes #2142 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8376d33d775ddb79ecedae93f9d969d8955693f5 Author: Murtuza Zabuawala Modified Files -- .../tools/grant_wizard/templates/grant_wiza

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

Hi Was this patch generated against a WIP branch? I get: (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_query_tool.patch error: web/pgadmin/static/js/setup_connection.js: No such file or directory On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < surinder.ku...@enterprise

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Fri, Jun 9, 2017 at 9:03 AM, Dave Page wrote: > On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear wrote: >>> Thanks. When I run the tests my browser opens in some default size >>> that's always consistent, but doesn't match my normal Chrome sessions, >>> or the 1024x1024 default set in app_starter

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

Hi, PFA minor patch to fix the issue in Grant wizard, In IE browser grant wizard do not close if user tries to close it by clicking Cancel button or Close button. RM#2142 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pg