Re: [pgadmin-hackers][patch] Column selection on SQLEditor

allow the user to copy again, in case they > use the clipboard for something else and then need to refresh it with > the data. Of course, it should still be disabled when there is nothing > selected that can be copied. > > Any chance this can be fixed before Monday? I would like to

[pgadmin-hackers][patch] Style updates

Hi Hackers, Matt and Sarah sat with our designer Shirley this week to do a couple of updates to the styles of the app. In particular, they changed the styles of the main tabs and the colors of the sql editor. Attached is a patch and a screenshot of the updated tabs and colors. ​ Tira & Matt 0

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

Also, as a heads up, I will be rolling off the project after this week. :( Tira On Tue, Apr 4, 2017 at 4:33 AM, Dave Page wrote: > Can you send me a squashed version as a single patch please? > > On Mon, Apr 3, 2017 at 8:32 PM, Atira Odhner wrote: > > Oops, there was a test issu

Re: [pgadmin-hackers] Feature test regression failures

> On Mon, Mar 27, 2017 at 12:05 PM, Atira Odhner wrote: > >> A change as large as moving to React will be for v2.x, not v1.x, so we > >> cannot really wait unless we want to write off the feature tests as > >> unusable for the forseeable future. > > > > >

Re: [pgadmin-hackers] Feature test regression failures

finitely be doing minification and bundling code into a single file. Tira & Matt On Mon, Mar 27, 2017 at 11:52 AM, Dave Page wrote: > On Mon, Mar 27, 2017 at 11:47 AM, Atira Odhner wrote: > >> > >> Tira's various patches all seem to be flakey :-(: > > &

Re: [pgadmin-hackers] Feature test regression failures

we still need to get the feature tests > working reliably ASAP (Murtuza is working on some more at the moment). > Ashesh, please replace the 1 char variable names with something more > meaningful as a first step. > > Would it help to get the two of you on a call to try to figure t

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed Ascending/Descending order in backgrid

Hi Khushboo, Matt and I took a look at your patch and noticed that there is code duplication between the lines you added and the preceding block of code. Instead of repeating the code in the else block, why not just remove the if condition? Also, the BigNumber casting in the previous block seems

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

When we were working on the DDL story, we found that some methods were returning the internal_server_error json, but the code that called those methods was not expecting that type of object. So, instead of returning that json to the user, the code would try to treat the json as a different type of

Re: [pgadmin-hackers] Re-vamping the history tab

Sounds good. We are going to start by working on the tree. On Fri, Mar 24, 2017 at 2:46 AM, Ashesh Vashi wrote: > On Thu, Mar 23, 2017 at 8:23 PM, Dave Page wrote: > >> On Thu, Mar 23, 2017 at 1:51 PM, Atira Odhner wrote: >> > >> > We will use jquery to make aja

Re: [pgadmin-hackers] Javascript translations

Thanks Dave. 1) String extraction no longer picks up strings in JS files. I guess > we may need a custom extractor for babel? Yeah, that's a good point. I didn't think about that. I'll put that in my team's backlog coming up. Here's a patch for the docs. On Thu, Mar 23, 2017 at 8:37 AM, Dave

Re: [pgadmin-hackers] Re-vamping the history tab

George On Thu, Mar 23, 2017 at 9:51 AM, Atira Odhner wrote: > Why anything new? Adding any library needs to be fully justified, and >> adding one this large, that gives similar capabilities to one we >> largely already have is going to require a significant amount of >> con

Re: [pgadmin-hackers] Re-vamping the history tab

the right level. Tira & George On Thu, Mar 23, 2017, 5:17 AM Dave Page wrote: > Hi > > On Wed, Mar 22, 2017 at 7:09 PM, Atira Odhner wrote: > > Hi Hackers, > > > > We want to give you a heads up on some of the changes we are planning and > > get your in

[pgadmin-hackers][patch] Show DDL for Greenplum Tables RM #2261

Hi Hackers, We have a fix for RM 2261: > As a user of pgAdmin I want to be able to look at the DDL of an existing > table, copy and paste it into a SQL editor then modify it to create a new > table. > *GIVEN* I have a table selected in the catalog browser > *WHEN* I select the SQL tab > *THEN*

[pgadmin-hackers] Re-vamping the history tab

Hi Hackers, We want to give you a heads up on some of the changes we are planning and get your input on the implementation plan. The Redmine issue is here: https://redmine.postgresql.org/issues/2282 Over the past month we have been doing many user interviews and one of the major asks is that the

Re: [pgadmin-hackers] Feature test regression failures

Hi Ashesh, > First - let me try to explain the problem with the failure in the >>> feature test. >>> We do not load all the javascript libraries, when starting the pgAdmin 4 >>> (i.e. the loading the browser/index.html). >>> But - load them only when first tree-item of certain type is added. >>>

Re: [pgadmin-hackers] Feature test regression failures

is being updated. Tira & Joao On Wed, Mar 22, 2017 at 2:20 AM, Ashesh Vashi wrote: > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in

Re: [pgadmin-hackers] Feature test regression failures

Here is a new patchset that instead hides the spinner when the acitree has been initialized. On average, the spinner seems to disappear about 2 seconds sooner, and I haven't seen flakiness with these changes yet. Tira & Joao On Mon, Mar 20, 2017 at 4:17 PM, Atira Odhner wrote: > No

Re: [pgadmin-hackers] Feature test regression failures

Note that this patch makes the problem of the tree not having loaded worse, because it only waits for js modules to load rather than arbitrarily waiting 900ms. On Mon, Mar 20, 2017 at 3:17 PM, Atira Odhner wrote: > Hi Ashesh, > > *Regarding your second patch:* > > It looks l

Re: [pgadmin-hackers] Feature test regression failures

Hi Ashesh, *Regarding your second patch:* It looks like your second patch addresses module loading. This is an improvement over the previous hard timeout, but won’t do anything for the tree issues. The module loading code can also be simplified; we’ve attached a patchset that is tidier, tests the

Re: [pgadmin-hackers] Patch submissions

before you feel the issues are addressed. I'm just suggesting that the patches should not be merged together. Tira On Mon, Mar 20, 2017 at 7:12 AM, Dave Page wrote: > Hi > > On Sat, Mar 18, 2017 at 4:03 PM, Atira Odhner wrote: > >> > >> Patch 4 fixed quotes in sql

Re: [pgadmin-hackers] Patch submissions

m in order to alleviate some of this process burden from you. Is there a process I can follow beyond replying to a patch email? Thanks, Tira On Fri, Mar 17, 2017 at 5:23 AM, Dave Page wrote: > Hi > > On Thu, Mar 16, 2017 at 5:58 PM, Atira Odhner wrote: > > Hi Dave, > > >

[pgadmin-hackers][patch] Fix an issue with the tree expansion

Stop using global variable, per thread about feature test regression failures Tira 0001-Stop-using-a-global-variable-for-the-tree-node-when-.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [pgadmin-hackers] Feature test regression failures

wrote: > > > On Mar 16, 2017 22:32, "Atira Odhner" wrote: > > I have seen this issue as well. > > Ashesh, this issue is related to the loading of the tree node data, not > loading of code, correct? > > Theoritically - Each node may contain code to represent th

[pgadmin-hackers][patch] Fix SQL tab for postgres 9.1 tables (RM #2260)

Hi Hackers, It looks like the sql tab was broken for postgres 9.1 because there was an error in the template. We found this when we started trying to fix it for Greenplum. We don't have an instance of Postgres 9.1, so we haven't tested this out, but this patch is at least going in the right direc

Re: [pgadmin-hackers] Patch submissions

Hi Dave, I'm wondering what pain you are feeling around having multiple patches. >From my perspective it is much easier to deal with smaller commits as it gives us a quicker way to understand each change if we want to look back at history. I agree that each patch should work standalone (tests sho

Re: [pgadmin-hackers] Feature test regression failures

I have seen this issue as well. Ashesh, this issue is related to the loading of the tree node data, not loading of code, correct? Each time the user expands a node triggers an ajax request to fetch the child nodes. There are probably some performance tradeoffs to loading that tree up front. But,

[pgadmin-hackers][patch] ensure screenshots directory exists

Originally we had a .keep file in the screenshots directory. This patch dynamically creates the screenshots directory. Tira 0001-ensure-the-screenshots-directory-exists.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to y

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

Awesome! Thanks! :D On Wed, Mar 15, 2017 at 1:16 PM, Dave Page wrote: > That go it! Thanks, patch applied. > > On Wed, Mar 15, 2017 at 2:46 PM, Atira Odhner wrote: > >> Oops, somehow we ended up with package.json in the wrong directory! It >> should be under web. Here

Re: [pgadmin-hackers] pgAdmin 4 commit: Create screenshots when feature tests fail.

Hey Dave, looks like we missed the .keep file in the screenshots directory when applying this patch. It's making screenshots fail to be captured when the directory doesn't exist (e.g. in CI). On Thu, Mar 9, 2017 at 10:34 AM, Dave Page wrote: > Create screenshots when feature tests fail. > > Br

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

Oops, somehow we ended up with package.json in the wrong directory! It should be under web. Here is a patch to fix it. I also updated the readme yarn/karma instructions. Tira On Wed, Mar 15, 2017 at 9:18 AM, Atira Odhner wrote: > you could also try installing it with yarn. > > On We

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

Hmm. I'm not sure why you can't install karma-cli. Are you able to run the tests using raw karma? (probably `web/node_modules/karma/bin/karma start` ) On Wed, Mar 15, 2017, 8:56 AM Dave Page wrote: > Hi > > On Tue, Mar 14, 2017 at 8:16 PM, Atira Odhner wrote: > >

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

you could also try installing it with yarn. On Wed, Mar 15, 2017, 9:16 AM Atira Odhner wrote: > Hmm. I'm not sure why you can't install karma-cli. Are you able to run the > tests using raw karma? (probably `web/node_modules/karma/bin/karma start` ) > > On Wed, Mar 15, 2

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

also re-attached the same patches since they were lost from the shared thread. Tira On Tue, Mar 14, 2017 at 4:11 PM, Atira Odhner wrote: > accidentally removed the group from this thread. adding them back. > > On Mon, Mar 13, 2017 at 7:08 AM, Dave Page wrote: > >> On Fri,

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

accidentally removed the group from this thread. adding them back. On Mon, Mar 13, 2017 at 7:08 AM, Dave Page wrote: > On Fri, Mar 10, 2017 at 4:53 PM, Atira Odhner wrote: > > We moved package.json, karma.conf, and node_modules under web. We'll > take a > > T

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

works in this case? Thanks, Tira On Fri, Mar 10, 2017 at 5:30 AM, Dave Page wrote: > Hi > > On Thu, Mar 9, 2017 at 9:56 PM, Atira Odhner wrote: > > Hi Dave, > > > > We've split these changes up into separate patches, added docs, pulled > > jasm

Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine

ity out of sqleditor.js and used this translate functionality. The resulting file is now testable javascript. Tira & George On Mon, Feb 27, 2017 at 6:28 AM, Dave Page wrote: > Hi > > On Fri, Feb 24, 2017 at 7:14 PM, Atira Odhner wrote: > > Hi hackers, > > > >

Re: [pgadmin-hackers][discussion] Javascript package management (Yarn?)

a On Fri, Mar 3, 2017 at 6:34 AM, Dave Page wrote: > Hi > > On Thu, Mar 2, 2017 at 6:11 PM, Atira Odhner wrote: > > Hi Hackers, > > > > We've had some discussion on another thread in the past couple weeks > about > > pulling in npm to manage our javascript

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

Hey Dave, We're not able to reproduce that issue over here. Any chance you could debug it? Thanks, Tira On Fri, Mar 3, 2017 at 10:20 AM, Dave Page wrote: > On Fri, Mar 3, 2017 at 1:57 PM, Dave Page wrote: > > Hi > > > > On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira > > wrote

[pgadmin-hackers][discussion] Javascript package management (Yarn?)

Hi Hackers, We've had some discussion on another thread in the past couple weeks about pulling in npm to manage

Re: [pgadmin-hackers] Feature test issues

on popup. If we were to manually reset the layout I think it would be very difficult to account for all the various scenarios and ensure a reasonable separation between tests. Tira On Tue, Feb 28, 2017 at 11:59 AM, Dave Page wrote: > On Tue, Feb 28, 2017 at 4:50 PM, Atira Odhner wrote: >

[pgadmin-hackers][patch] Make feature test app teardown more reliable, and tests faster

Hi Hackers, We made the following improvements to the test suite: Make feature test app teardown more reliable, and tests faster - don't spin up app and chromedriver between each test - catching signals also tears down the app - do layout reset between tests, but assume that tests wi

[pgadmin-hackers][patch] Use TEST_SQLITE_PATH for tests

Hi Hackers, Here is a change to ensure that the sqlite test instance is used for all the tests. This should help tests clean up server connections properly and prevent interference with running the app. Credit to Dave for pointing this issue out. Tira & Joao 0001-Use-TEST_SQLITE_PATH-for-tests

Re: [pgadmin-hackers] Feature test issues

ules if we did, thus preventing pgAdmin 4 from ever > shipping in EPEL or Canonical's package repos). Okay, I think that makes sense. Thanks for the explanation. Tira On Tue, Feb 28, 2017 at 5:17 AM, Dave Page wrote: > On Mon, Feb 27, 2017 at 7:51 PM, Atira Odhner wrote: > > The te

[pgadmin-hackers][patch] Syntax Highlighting Color Change RM #2215

Hi Hackers, Here is a small css change to make the syntax highlighting more visible color-wise. https://redmine.postgresql.org/issues/2215 > As a query writer I want to be able to see the syntax highlighted colors > even if I am colorblind so that I can easily make sense of the code I am > writi

Re: [pgadmin-hackers] Feature test issues

4:02 AM, Atira Odhner wrote: > > Cool, we already have a task about proper teardown and a couple other > things > > in our backlog. we'll probably get to it in the next day or so. I'll > take a > > look at the other stuff. > > Thanks. > > > Also, r

Re: [pgadmin-hackers] Feature test issues

Cool, we already have a task about proper teardown and a couple other things in our backlog. we'll probably get to it in the next day or so. I'll take a look at the other stuff. Also, regarding speed, even without the app startup time, end to end tests are always going to be relatively slow. We de

Re: [pgadmin-hackers] SlickGrid

> > The difference with PIP is that a) the packages can be specific to the > version of Python in use The javascript is going to run in the end-user's browser regardless of what is installed on the machine where the app is packaged. Varying what versions of the libraries are in use in that way fo

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

o the user can reference the image to the failure. > > The reason the last two items are important is that I've now got a > test server running the test suite with every supported version of > Python, for every supported database (well, almost, pending a couple > of fixes). I have sepa

Re: [pgadmin-hackers][patch] Fixes QT build when not signing

Thanks! On Thu, Feb 16, 2017, 6:26 AM Dave Page wrote: > Thanks - patch applied with minor tweaks to make it fail much earlier > if framework.conf isn't present, and to update to current versions of > Python/Qt. > > On Tue, Feb 14, 2017 at 3:18 PM, Atira Odhner wrote: >

Re: [pgadmin-hackers] SlickGrid

Hi Dave, > we never rely on the availability of third party sites, > especially not commercial ones. npm is commercial and pip is supported by a noncommercial foundation, but npm is still open source. If you are concerned about relying on a 3rd party commercial site, perhaps we could use npm t

Re: [pgadmin-hackers][patch] Fixes QT build when not signing

Sure, sounds good. We accidentally had a stray chmod hanging out, which we removed. We also made it exit if the framework.conf is missing. We opted in that direction over the auto-using framework.conf.in because we feel like it is likely that developers will need to set these values to get the buil

Re: [pgadmin-hackers] Feature Suggestions

Great! Thanks Dave. We're having a look to see what seems feasible implementation-wise. Tira On Tue, Feb 14, 2017 at 4:33 AM, Dave Page wrote: > Hi > > On Mon, Feb 13, 2017 at 6:55 PM, Raffi Holzer wrote: > > Hi everyone, > > > > For those who don't know, Pivotal Labs is working with Greenplum

Re: [pgadmin-hackers][patch] change --pkg behavior

It looks like there was some test setup logic that happened in test_utils.py that was node-name specific. We've removed that logic and re-enabled cleaning up the test databases. Tira & George On Thu, Feb 9, 2017 at 7:16 AM, Dave Page wrote: > Hi > > On Wed, Feb 8, 2017 at 9:3

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Here's the updated patch On Thu, Feb 9, 2017 at 8:52 AM, Atira Odhner wrote: > Good point! I guess I was asleep at the wheel on this one. I didn't notice > it was a library. > > On Thu, Feb 9, 2017, 4:37 AM Dave Page wrote: > >> Hi >> >> On Thu

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

! We'll try sending patchsets from now on and hopefully that resolves some of the issues we were seeing. Tira & George On Thu, Feb 9, 2017 at 9:28 AM, Dave Page wrote: > Hi > > On Thu, Feb 9, 2017 at 2:20 PM, Atira Odhner wrote: > > Certainly. We did mention the dependency

Re: [pgadmin-hackers][patch] We can see tables in Greenplum!

Great! Here is an updated patch set. -Tira & George On Thu, Feb 9, 2017 at 12:33 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > Regarding test output, > > > *Comment Style-1:* If we comment like > > """Test Case is used for... """ > > *Result:* > > runTest (pgad

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

te when one patch is > dependent on another. It's hard to keep track when you're this > productive! > > Thanks. > > On Thu, Feb 9, 2017 at 1:15 PM, Atira Odhner wrote: > > create_table is the change we pulled into the other patch which would > need > > to

Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Good point! I guess I was asleep at the wheel on this one. I didn't notice it was a library. On Thu, Feb 9, 2017, 4:37 AM Dave Page wrote: > Hi > > On Thu, Feb 9, 2017 at 7:26 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > It's not a good idea to directly change in main Library, Lets say if > n

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

ession/utils/pgadmin_page.py", > line 86, in wait_for_element > return self._wait_for("element to exist", element_if_it_exists) > File "/Users/dpage/git/pgadmin4/web/regression/utils/pgadmin_page.py", > line 120, in _wait_for > raise RuntimeError(

[pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

Hello Hackers We have made syntax highlighting more visible! -Tira & George commit 44207d83b0e28e1a2c474a35284ea21f7f4a197e Author: George Gelashvili and Tira Odhner Date: Wed Feb 8 17:51:00 2017 -0500 [PATCH] embolden syntax highlighting [RM2163] diff --git a/web/pgadmin/static/css/code

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

the --exclude flag changes out to a separate patch. On our side we are still dealing with these as 20 separate commits. What is the best way for us to send you these patches? Do you prefer having them all squashed down to a single patch or to have smaller patches? On Mon, Feb 6, 2017 at 9:54 AM, A

Re: [pgadmin-hackers][patch] change --pkg behavior

Here is the additional patch to exclude one or more packages. On Tue, Feb 7, 2017 at 6:02 PM, George Gelashvili wrote: > Hello Hackers, > > To chase down a set of tests that were failing together, we wanted to run > deeper trees of tests. We changed the behavior of the --pkg argument to > runtes

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

and give other devs a chance to use and iterate on this work. Thanks, Tira & George On Mon, Feb 6, 2017 at 5:32 AM, Dave Page wrote: > Hi > > On Fri, Feb 3, 2017 at 9:56 PM, Atira Odhner wrote: > > Hi Dave, > > > > Here is a new patch which includes the foll

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

could be related to viewport size > as you > >> suggested, but the first error just looks like a problem with the test > not > >> being able to spin up its own server. > > > > That was on a second run of the tests, yes. I just did a careful > > cleanup of left-

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Here's the patch with one more fix -- cleaning up the connections that get created in pgAdmin. On Mon, Jan 30, 2017 at 2:28 PM, George Gelashvili wrote: > so, it sounds like you're saying our accaptable_test_db is unacceptable :-P > > here's a patch that takes an "--exclude" flag (see README) a

Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum

Whoops we accidentally left in hardcoded db config we used for running tests from our IDE. Here's a fixed patch. On Mon, Jan 30, 2017 at 6:45 AM, Dave Page wrote: > Hi > > On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili > wrote: > > This bypasses checking if the DB is in recovery for versio

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

Awesome. Thanks folks! On Mon, Jan 30, 2017 at 6:35 AM, Fahar Abbas wrote: > Sure Dave. > > On Mon, Jan 30, 2017 at 4:33 PM, Dave Page wrote: > >> Thanks Murtuza. Fixed and committed. George; I stuck with the original >> filename for the loader - I couldn't come up with anything better. >> >> F

Re: [pgadmin-hackers] inconsistent sql template path resolving

Nevermind, I think I figured it out. Some templates are resolved on 9.5_plus etc. On Mon, Jan 23, 2017 at 3:31 PM, Atira Odhner wrote: > Hello fellow pgadmin hackers, > > I was taking a look at some version-checking code and I noticed some > inconsistencies in how we are picking w

[pgadmin-hackers] inconsistent sql template path resolving

Hello fellow pgadmin hackers, I was taking a look at some version-checking code and I noticed some inconsistencies in how we are picking what sql file to run: ver = self.manager.version if ver >= 90200: self.template_path = 'exclusion_constraint/sql/9.2_plus' elif ver >= 90100: self.templ

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Thanks for your feedback, Dave! We can put the tests under the regression directory. I think that makes sense. I'm not picturing these tests being module specific, but we may want to enable running it as a separate suite of tests. Thanks for the callout about the port and title. We'll make sure t