Re: [pgadmin-hackers] [PATCH] Document that a patch should be submitted to the list as an attachment

> > > /Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:16: > trailing whitespace. > > as well as the rationale for any important design decisions. > > error: patch failed: docs/en_US/submitting_patches.rst:30 > > error: docs/en_US/submitting_p

Re: [pgadmin-hackers] [PATCH] Document that a patch should be submitted to the list as an attachment

On 11/10/16 15:34, Dave Page wrote: > Hi > > On Monday, October 10, 2016, Chris Mayo <mailto:aklh...@gmail.com>> wrote: > > Signed-off-by: Chris Mayo > > --- > docs/en_US/submitting_patches.rst | 8 > 1 file changed, 4 insertions(+),

Re: [pgadmin-hackers] Running pgadmin4 as desktop application

> Ok, this worked on CentOS 7 box, but not on Fedora 24, which has QT5 and > Python > 3. Can you help me to debug this? The content of the file in Fedora 24 is: > > $ cat /etc/pgAdmin\ Development\ Team/pgAdmin\ 4.conf > [General] > ApplicationPath=../../../..//usr/lib/python3.5/site-packages/pg

[pgadmin-hackers] [PATCH] Document that a patch should be submitted to the list as an attachment

Signed-off-by: Chris Mayo --- docs/en_US/submitting_patches.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_patches.rst index c077551..4ac878d 100644 --- a/docs/en_US/submitting_patches.rst +++ b/docs/en_US

[pgadmin-hackers] [PATCH 2/2] Improve references to the mailing list in docs

Just let Sphinx discover the email address; displays better in browser and pgAdmin4 runtime. Signed-off-by: Chris Mayo --- docs/en_US/contributions.rst | 2 +- docs/en_US/submitting_patches.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/en_US

[pgadmin-hackers] [PATCH 1/2] Fix link to code_review in submitting_patches.rst

Signed-off-by: Chris Mayo --- docs/en_US/submitting_patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_patches.rst index b4bbebe..9f8ab42 100644 --- a/docs/en_US/submitting_patches.rst +++ b/docs/en_US