Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-04-18 Thread Dave Page
Thanks, patch applied. On Fri, Apr 14, 2017 at 4:20 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Sat, Apr 1, 2017 at 12:12 PM, Dave Page wrote: >> >> Hi >> >> >> On Friday

[pgadmin-hackers] pgAdmin 4 commit: Ensure database driver names and description strings

2017-04-18 Thread Dave Page
Ensure database driver names and description strings can be translated. Fixes #2190 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a3007b7335d73cb2042cf4b2d3939b69ae4bcaac Author: Khushboo Vashi Modified Files -- web/pgadmin/bro

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-18 Thread Dave Page
e the styling of this patch as part of that work. > > Best, > George and Matt > > > > > > > On Mon, Apr 10, 2017 at 11:13 AM, Dave Page wrote: >> >> Hi >> >> On Mon, Apr 10, 2017 at 4:01 PM, Matthew Kleiman >> wrote: >> > Hi Dave, >

[pgadmin-hackers] pgAdmin 4 commit: Allow column or row selection in the query tool. Fixe

2017-04-18 Thread Dave Page
Allow column or row selection in the query tool. Fixes #2216 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d663d553c55fbb5cdbe172d5c8780b777815de00 Author: Matthew Kleiman Modified Files -- docs/en_US/images/query_output_data.pn

[pgadmin-hackers] pgAdmin website commit: Correct link to downloads, per Devrim.

2017-04-18 Thread Dave Page
Correct link to downloads, per Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=10f2959b2442f1896b458d916e9c58b268d673ce Modified Files -- download/index.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

Re: [pgadmin-hackers] 1.4 sphinx error on RHEL 6

2017-04-18 Thread Dave Page
ards, > -- > Devrim Gündüz > EnterpriseDB: http://www.enterprisedb.com > PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer > Twitter: @DevrimGunduz , @DevrimGunduzTR -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterpr

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-18 Thread Dave Page
more or > less flat. Yes - the last point above for example; the info bar has been made gray so it a) flattens the look and b) stops it standing out. I would argue that absolutely needs to be a prominent colour; maybe not the blue it currently is, but certainly something that makes it clearly visible

[pgadmin-hackers] pgAdmin website commit: Bump available version

2017-04-13 Thread Dave Page
Bump available version Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=13e6624154124e9fd41a15b4e8796a77e6c05cf9 Modified Files -- versions.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hacke

[pgadmin-hackers] pgAdmin website commit: Correct pgAgent URL

2017-04-13 Thread Dave Page
Correct pgAgent URL Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=839a90070963221e4cf7ae5cfdd91de2ae5b06f5 Modified Files -- download/pgagent.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hacke

[pgadmin-hackers] pgAdmin website commit: Release 1.4. Restructure FTP site at the same t

2017-04-13 Thread Dave Page
Release 1.4. Restructure FTP site at the same time to get rid of legacy paths that make little sense now. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=92be1b882a4f2f55ef183fe5474d2eeb9b413613 Modified Files -- download/macos.

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_4 has been created.

2017-04-13 Thread Dave Page
Tag REL-1_4 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_4 Log Message --- Tag 1.4 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-

Re: [pgadmin-hackers] Thoughts on allowing PGAdmin4 config file override

2017-04-13 Thread Dave Page
ntended for packagers): https://www.pgadmin.org/docs4/1.x/server_deployment.html#configuration -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (p

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-12 Thread Dave Page
ing on a table in the browser to "view >> ... >> > data/rows" outputs an editable table) >> >> When we first released pgAdmin 4 we forgot to right-justify numbers. >> Users complained. Lots. They need to stay right justified. >> >> >> R

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Thanks, applied. On Wed, Apr 12, 2017 at 1:52 PM, Surinder Kumar wrote: > Hi Dave, > > Please find rebased patch. > > On Wed, Apr 12, 2017 at 5:44 PM, Dave Page wrote: >> >> Can you rebase this please? >> >> On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kuma

[pgadmin-hackers] pgAdmin 4 commit: Remove some unused events.

2017-04-12 Thread Dave Page
Remove some unused events. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bbc05051cc852e558ebcdf5a83644b97f09a82a Author: Surinder Kumar Modified Files -- .../server_groups/servers/templates/servers/servers.js | 13 +

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
;> On Wed, Apr 12, 2017 at 5:50 PM, Murtuza Zabuawala >> wrote: >>> >>> Hi Dave, >>> >>> PFA rebased patch. >>> >>> Thanks, >>> Murtuza >>> >>> On Wed, Apr 12, 2017 at 5:45 PM, Dave Page wrote: >>>> &g

[pgadmin-hackers] pgAdmin 4 commit: Update inode info when refreshing treeview nodes. Fix

2017-04-12 Thread Dave Page
Update inode info when refreshing treeview nodes. Fixes #2336 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=019c1302cb863094eb3494391580a77dd02ad4dd Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/templates/browse

[pgadmin-hackers] pgAdmin 4 commit: Align labels with switches properly.

2017-04-12 Thread Dave Page
Align labels with switches properly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbee76eac88cbeab47d245087be2abdb38ffcd08 Author: Akshay Joshi Modified Files -- web/pgadmin/static/css/pgadmin.css | 1 + 1 file changed, 1 inserti

Re: [pgadmin-hackers] [pgAdmin4][Patch] Align Switch control with the text

2017-04-12 Thread Dave Page
hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
erprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-12 Thread Dave Page
Can you rebase this please? On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar wrote: > Hi Dave, > > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page wrote: >> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar >> wrote: >> > Hi >> >

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:22 PM, Navnath Gadakh wrote: > Hi Dave, > > Please find the revised patch. > > On Mon, Apr 10, 2017 at 1:43 PM, Dave Page > wrote: >> >> Hi >> >> On Fri, Apr 7, 2017 at 8:01 PM, Na

[pgadmin-hackers] pgAdmin 4 commit: Include passed test results in the JSON output from t

2017-04-12 Thread Dave Page
Include passed test results in the JSON output from the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62716c4193c4434b002682126b634b29d70d1870 Author: Navnath Gadakh Modified Files -- .../sql/tests/test_foreign_

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-12 Thread Dave Page
Thanks, patch applied. On Mon, Apr 10, 2017 at 2:16 PM, Murtuza Zabuawala wrote: > Sure, https://redmine.postgresql.org/issues/2331 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Apr 10,

[pgadmin-hackers] pgAdmin 4 commit: Fix binary search algorithm so new treeview nodes are

2017-04-12 Thread Dave Page
Fix binary search algorithm so new treeview nodes are added in the correct position. Fixes #2331 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd9efd811c7845d9dc985b66f8d33497f2f4bfa Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

2017-04-11 Thread Dave Page
why clear it? > Also, on server disconnect, an unused event 'server-disconnected' is being > triggered. > instead it should trigger ''pgadmin:server:disconnect'event. Please submit that as a separate cleanup patch. Thanks. -- Dave Page Blog: ht

[pgadmin-hackers] Candidate builds for 1.4

2017-04-10 Thread Dave Page
$SUBJECT can be found here: https://developer.pgadmin.org/~dpage/ Please yelp ASAP if there are any serious packaging problems. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Adjust windows resources so they work consistently.

2017-04-10 Thread Dave Page
Adjust windows resources so they work consistently. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c435154aca919ee6ff37cd12fc4fb1c9e663be2 Modified Files -- runtime/pgAdmin4.pro | 11 --- 1 file changed, 4 insertions(+), 7

[pgadmin-hackers] pgAdmin 4 commit: Fix application icon in mingw builds.

2017-04-10 Thread Dave Page
Fix application icon in mingw builds. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=665ec460521e875bfd0a6782d616a79a293ab7b7 Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent vi

[pgadmin-hackers] pgAdmin 4 commit: Bump version numbers for release.

2017-04-10 Thread Dave Page
Bump version numbers for release. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdf292964ba708bfc4fe0d2d80f7e72048e765f0 Modified Files -- runtime/Info.plist | 4 ++-- web/config.py | 4 ++-- 2 files changed, 4 insertions(+), 4

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-10 Thread Dave Page
esh for helping me. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
king fine > > until not FindNext(FindRec); > > > > > > > On Mon, Apr 10, 2017 at 3:01 PM, Dave Page wrote: > >> Attached. >> >> On Mon, Apr 10, 2017 at 10:26 AM, Paresh More < >> paresh.m...@enterprisedb.com> wrote: >> >>> Hell

[pgadmin-hackers] pgAdmin 4 commit: Ensure the web/ directory is cleared before upgrading

2017-04-10 Thread Dave Page
Ensure the web/ directory is cleared before upgrading Windows installations. Fixes #2187 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b86fa15dbce58df7be87035ae8cac6cd3f4ee98a Author: Paresh More Modified Files -- pkg/win32/inst

[pgadmin-hackers] pgAdmin 4 commit: Recover properly if a database is renamed externally.

2017-04-10 Thread Dave Page
Recover properly if a database is renamed externally. Fixes #2077 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=024b97479dde8ce231532a5f79fb6600cbea0923 Author: RAJASEKAR G Modified Files -- web/pgadmin/browser/server_groups/serv

[pgadmin-hackers] pgAdmin 4 commit: Fix a regression framework issue with Python 2.6.

2017-04-10 Thread Dave Page
Fix a regression framework issue with Python 2.6. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e81478e3fa4d73793179861fe3ffc0e4958569 Author: Navnath Gadakh Modified Files -- web/regression/python_test_utils/test_utils.py | 32

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-10 Thread Dave Page
ressing this button won't do anything unless >> rows have been copied to the clipboard, this might prove confusing to users. >> I am going to look at disabling this button until rows are in the clipboard. >> I will let you know if I have anything for you by the end of today. &g

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
Attached. On Mon, Apr 10, 2017 at 10:26 AM, Paresh More wrote: > Hello Dave, > > Can you please send me C:\Users\dpage\Documents\pg > admin4\pkg\win32\installer.iss file > > On Mon, Apr 10, 2017 at 2:30 PM, Dave Page wrote: > >> Hi >> >> On Su

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
s installer... using INNO tool Error on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9: Semicolon (';') expected. Compile aborted. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Ensure menus are updated after disconnecting a server

2017-04-10 Thread Dave Page
Ensure menus are updated after disconnecting a server. Fixes #2281 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f3a57d82d2f7f31e105e0dbb36200108273759 Author: RAJASEKAR G Modified Files -- web/pgadmin/browser/server_groups/ser

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-10 Thread Dave Page
ave > also added missing scenario names to some test cases. > The passed test results are shown as null. They should either be removed (because they'll all be "Passed" or similar anyway), or set to "Passed" or "Pass". Thanks. -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: [pgadmin-hackers][patch] Style updates

2017-04-07 Thread Dave Page
Hi On Fri, Apr 7, 2017 at 4:08 PM, Shirley Wang wrote: > Hello > > On Fri, Apr 7, 2017 at 6:04 AM Dave Page wrote: > >> Hi >> >> This introduces a number of display issues for me: >> >> - There are now gaps between the tabs and their content panels.

[pgadmin-hackers] pgAdmin 4 commit: Adding a delay clearly didn't fix the feature tests :

2017-04-07 Thread Dave Page
Adding a delay clearly didn't fix the feature tests :-( Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2c4cb1606713befb897e4ed0e3341a314e4e9b4 Modified Files -- ci/run_python_tests.sh | 2 +- web/regression/fe

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-07 Thread Dave Page
k at it > today. We'll let you know at the end of the day where we're at with this > fix. Thanks - and sorry to hear your moving onto other things :-( -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postg

[pgadmin-hackers] pgAdmin 4 commit: Attempt to better catch errors in the CI tests.

2017-04-07 Thread Dave Page
Attempt to better catch errors in the CI tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a431937b500f261403dff1c9ca5acdd0c8fa36d6 Modified Files -- ci/build_docs.sh| 4 ++-- ci/build_pip_wheel.sh | 4 ++-- ci/build_

[pgadmin-hackers] pgAdmin 4 commit: Add a 0.5 second delay to treeview node expansion in

2017-04-07 Thread Dave Page
Add a 0.5 second delay to treeview node expansion in the feature tests, to try to (temporarily) allow for script loading time. Tentatively enable the feature tests in CI to see if it works. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a01c

[pgadmin-hackers] pgAdmin 4 commit: Include an example of running just the feature tests.

2017-04-07 Thread Dave Page
Include an example of running just the feature tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de80545400c901e36dcd236c7ecfd4e615ce1192 Modified Files -- web/regression/README | 3 +++ 1 file changed, 3 insertions(+) -- Sen

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

2017-04-07 Thread Dave Page
mp; Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >> On Fri, Ap

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-07 Thread Dave Page
will be rolling off the project after this week. :( >> >> Tira >> >> On Tue, Apr 4, 2017 at 4:33 AM, Dave Page wrote: >>> >>> Can you send me a squashed version as a single patch please? >>> >>> On Mon, Apr 3, 2017 at 8:32 PM, Atira Odh

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-04-07 Thread Dave Page
that may not actually be possible without saving the row (defaults may not be constant, they could be expressions). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mail

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-04-07 Thread Dave Page
l] marker (despite having a null value, which I confirmed in pgAdmin 3). I'm sure there are other combinations of issues here. Please fix and thoroughly re-test to ensure behaviour is consistent - and to avoid future issues, please add some appropriate feature tests to check nulls, def

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

2017-04-07 Thread Dave Page
-- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Oops, syntax error.

2017-04-06 Thread Dave Page
Oops, syntax error. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d55b8394cfd6c33d67f00395b16b0b3490bc873a Modified Files -- web/karma.conf.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Swap entries in karma.conf so test-main.js is matched

2017-04-06 Thread Dave Page
Swap entries in karma.conf so test-main.js is matched first, per suggestion from Atira to fix the failing Jasmine tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcc122f29015983cca0f29ae074ec4951be8006b Modified Files -- web

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Dave Page
to "view ... > data/rows" outputs an editable table) When we first released pgAdmin 4 we forgot to right-justify numbers. Users complained. Lots. They need to stay right justified. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterpri

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-06 Thread Dave Page
On Thu, Apr 6, 2017 at 3:05 PM, Murtuza Zabuawala wrote: > > > On Thu, Apr 6, 2017 at 1:40 PM, Dave Page wrote: >> >> On Thu, Apr 6, 2017 at 2:27 AM, Jonas Thelemann >> wrote: >> > Thanks for committing! :) >> > >> >>> i18n-trim.diff

[pgadmin-hackers] Jasmine tests failing on CI

2017-04-06 Thread Dave Page
y settings. Do you have any idea what's really going on? I'm loathe to start randomly tweaking settings without understanding the real issue. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Com

[pgadmin-hackers] pgAdmin 4 commit: Fix validation on the table dialogue so the Save butt

2017-04-06 Thread Dave Page
Fix validation on the table dialogue so the Save button isn't enabled if the name is removed and autovac custom settings are enabled. Fixes #2105 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3880bc7eb829e786d50d115e95acb2b2d77d20e8 Author: R

[pgadmin-hackers] pgAdmin 4 commit: Properly handle EXPLAIN queries entered directly by t

2017-04-06 Thread Dave Page
Properly handle EXPLAIN queries entered directly by the user in the query tool. Fixes #2287 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c758920890309e50f47a9427039cf735ddf04d37 Author: RAJASEKAR G Modified Files -- web/pgadmin

[pgadmin-hackers] pgAdmin 4 commit: Update the Polish translation

2017-04-06 Thread Dave Page
Update the Polish translation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ac5bf4f1204db9a14b96af41400b61e2c500158 Author: Begina Felicysym Modified Files -- .../translations/pl/LC_MESSAGES/messages.mo| Bin 101293 -> 11

Re: [pgadmin-hackers] pgAdmin 4 commit: Update translations - polish translation

2017-04-06 Thread Dave Page
Thanks, committed. On Wed, Apr 5, 2017 at 6:17 PM, Begina Felicysym wrote: > Hi, > > I just fixed the polish translation > > > > Cheers > > Begina > > > > Dnia Środa, 5 Kwietnia 2017 15:03 Dave Page napisał(a) > > Update translations > &g

[pgadmin-hackers] pgAdmin 4 commit: Use a more appropriate output file name.

2017-04-06 Thread Dave Page
Use a more appropriate output file name. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a412e3226ff7c51760c16fab3ccf55780d17696b Modified Files -- web/regression/runtests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

[pgadmin-hackers] pgAdmin 4 commit: Write a JSON file when regression tests run, listing

2017-04-06 Thread Dave Page
Write a JSON file when regression tests run, listing results. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd23f714780878f19726ead2c03b98115a08 Author: Navnath Gadakh Modified Files -- .../connect_to_server_feature_test.py

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-06 Thread Dave Page
l result in an extra line break: >>> print("""Hello ... How are you""") I'm beginning to think we have no choice but to ignore PEP8 and not allow strings to wrap except where we want them to. I can't find anything on Google about other al

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-05 Thread Dave Page
Hi! On Sun, Apr 2, 2017 at 4:03 AM, Jonas Thelemann wrote: > Hey pgAdmin-Hackers / Dave Page, > > here are my suggestions and questions regarding the translation of pgAdmin! > > > Patches > > i18n-cannot.diff > > Replaced all occurrences of "can no

[pgadmin-hackers] pgAdmin 4 commit: Un-split some strings for translateability. And so be

2017-04-05 Thread Dave Page
Un-split some strings for translateability. And so begins the battle between gettext and pep8... Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8566a0127b04241c06200f022506199526b6259 Author: Jonas Thelemann Modified Files -- ..

[pgadmin-hackers] pgAdmin 4 commit: Update translations

2017-04-05 Thread Dave Page
Update translations Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d9cfa667986070d5694b5ce0f089b527b0e04a2 Modified Files -- web/pgadmin/messages.pot | 440 .../translations/pl/LC_MESSAGES

[pgadmin-hackers] pgAdmin 4 commit: Add German translation Fixes #2323

2017-04-05 Thread Dave Page
Add German translation Fixes #2323 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e66616b1d89b389b256f83ab79d64c8e02fb6fec Author: Jonas Thelemann Modified Files -- web/config.py |5 +- .../

[pgadmin-hackers] pgAdmin 4 commit: Remove unnecessary quotes.

2017-04-05 Thread Dave Page
Remove unnecessary quotes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea2b3f43bd438640fcccf30b1d7b247b80fab0f7 Author: Jonas Thelemann Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 2 +- 1 file changed, 1 in

[pgadmin-hackers] pgAdmin 4 commit: Unified usage of "definition incomplete".

2017-04-05 Thread Dave Page
Unified usage of "definition incomplete". Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ddfa934357bd838dd502780ca3d51a860b5247b7 Author: Jonas Thelemann Modified Files -- .../server_groups/servers/databases/casts/__init__.py |

[pgadmin-hackers] pgAdmin 4 commit: (De)Capitalized strings to fit the common/usual forma

2017-04-05 Thread Dave Page
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=37120bf19923b1bdc64b8e3e961bc53f330ec0c4 Author: Jonas Thelemann Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Replace all occurrences of "can not" with "cannot".

2017-04-05 Thread Dave Page
Replace all occurrences of "can not" with "cannot". Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=65f21a8cd7008118d75b36872507b2957c041c8c Author: Jonas Thelemann Modified Files -- web/pgadmin/browser/server_groups/servers/__init

[pgadmin-hackers] pgAdmin 4 commit: Avoid an unauthorised error if clicking on the logo i

2017-04-05 Thread Dave Page
Avoid an unauthorised error if clicking on the logo in desktop mode. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=85db82c7f478873f719828f7daca189d8dee45d3 Author: Maxim Zakharov Modified Files -- web/pgadmin/browser/templates/br

[pgadmin-hackers] pgAdmin 4 commit: Add targets to extract/merge and compile messages.

2017-04-05 Thread Dave Page
Add targets to extract/merge and compile messages. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a7cdd78ad7cee6dd23fbb918a55471488ade5e86 Modified Files -- Makefile | 9 + 1 file changed, 9 insertions(+) -- Sent via pgad

[pgadmin-hackers] pgAdmin 4 commit: Add an appbundle-webkit build target to build an appb

2017-04-05 Thread Dave Page
Add an appbundle-webkit build target to build an appbundle, but force the use of QtWebKit. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53c4e2df3ba20e861d2c2061000b0571e3685b20 Modified Files -- Makefile | 3 +++ pkg/mac/

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-04 Thread Dave Page
r than just the name. I suspect >>> that would look better. >> >> >> We're going to work on some styling after this patchset. We're talking >> about removing the checkboxes and creating a more spreadsheet-like >> experience. >> >>&g

[pgadmin-hackers] pgAdmin 4 commit: Ignore some MinGW related build files.

2017-04-03 Thread Dave Page
Ignore some MinGW related build files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee17c7709350a3c957b89f5172b4e88a11e38fcd Modified Files -- runtime/.gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add a script for creating a Windows build using Qt wi

2017-04-03 Thread Dave Page
Add a script for creating a Windows build using Qt with MinGW & QtWebKit Reloaded. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e78865b2d4095ffd5d2e66a599e4d11dc3972c3a Modified Files -- Make-MinGW.bat | 461

[pgadmin-hackers] 1.4 release

2017-04-03 Thread Dave Page
All, Just a quick heads-up; I'm planning to wrap 1.4 next Monday, 10th April for release the following Thursday. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-ha

Re: [pgadmin-hackers] [pgadmin4][patch] Remove (...) from links

2017-04-03 Thread Dave Page
llipses. That is an extremely long-standing convention to denote a menu option that will open a new window/dialog before taking the action, rather than taking the action immediately. See the menus in pretty much any Apple or Microsoft application for examples. -- Dave Page Blog: http://pgsnake.

[pgadmin-hackers] pgAdmin 4 commit: Mingw32 compatibility fixes

2017-04-03 Thread Dave Page
Mingw32 compatibility fixes Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e7cee870a7a2174527e77fe9e6601e18321d8d44 Modified Files -- runtime/pgAdmin4.cpp | 1 + runtime/pgAdmin4.h | 3 +++ 2 files changed, 4 insertions(+) -- Se

Re: [pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-04-03 Thread Dave Page
Thanks, applied. On Friday, March 31, 2017, Harshal Dhumal wrote: > Hi, > > PFA patch for RM2305. > > > Issue: Generic function qtLiteral was not adapting values properly which > contains non ascii characters. > > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.e

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-04-01 Thread Dave Page
No, it's not, but the correct fix was committed a couple of days ago and I totally forgot to ping you. Sorry about that. :-( -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 1 Apr 201

[pgadmin-hackers] pgAdmin 4 commit: Properly handle truncated table names (> NAMEDATALEN)

2017-03-31 Thread Dave Page
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb0bd8acc5d6899ed514159e344928e6453faa63 Author: Aravindraja Thinakaran Modified Files -- .../server_groups/servers/

[pgadmin-hackers] pgAdmin 4 commit: Add the config option ALLOW_SAVE_PASSWORD to allow ad

2017-03-31 Thread Dave Page
Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of passwords. Fixes #2232 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a861f7a914ab5c33cf9e04aae6fa4aa5bf96a53 Author: Akshay Joshi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-03-31 Thread Dave Page
Hi On Friday, March 31, 2017, Khushboo Vashi wrote: > Hi, > > On Mon, Mar 27, 2017 at 9:57 PM, Dave Page > wrote: > >> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi >> > > wrote: >> > Hi Dave, >> > >> > I have fixed the issue and

[pgadmin-hackers] pgAdmin 4 commit: Generic function qtLiteral was not adapting values pr

2017-03-31 Thread Dave Page
Generic function qtLiteral was not adapting values properly when they contain non ascii characters. Fixes #2305 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9acf3404005333daaa9658c4e2c22ad58ad1f99b Author: Harshal Dhumal Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Remove debug code.

2017-03-31 Thread Dave Page
Remove debug code. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ba9269a88a055bd151cbf5929b0d660d2843ef2 Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 3 --- 1 file changed, 3 deletions(-) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Fix error highlighting in the query tool. Fixes #2291

2017-03-31 Thread Dave Page
Fix error highlighting in the query tool. Fixes #2291 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efb077b7f77f6313bb4b67aa3ffb27a65e296330 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/sqleditor/__init__.py

Re: [pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-03-31 Thread Dave Page
gineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

2017-03-31 Thread Dave Page
t; > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

2017-03-31 Thread Dave Page
Thanks, applied. On Friday, March 31, 2017, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM #2291: Error highlighting broken. > > Murtuza / Akshay, > > Can you please review the patch? > > Thanks, > Khushboo > -- Dave Page Blog: ht

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page
On Friday, March 31, 2017, Devrim Gündüz wrote: > > Hi Dave, > > On Fri, 2017-03-31 at 21:03 +0000, Dave Page wrote: > > Update Babel version. > > Uh, this is the version on Fedora 25. > > RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI. > D

[pgadmin-hackers] pgAdmin 4 commit: Add missing semi-colon.

2017-03-31 Thread Dave Page
Add missing semi-colon. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4fd3133717d04dfd5df3cee4162e43be628617a Modified Files -- ci/update_messages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hac

[pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page
Update Babel version. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7fc21e3bb28ef782ccb1d251108b2d079e719fe Modified Files -- requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hacker

[pgadmin-hackers] pgAdmin 4 commit: Add missing bracket

2017-03-31 Thread Dave Page
Add missing bracket Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3e6fe5b642886bf55fe28b4ae5865f2f283bf7f Modified Files -- ci/update_messages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update CI script output for parsing with the Log Pars

2017-03-31 Thread Dave Page
Update CI script output for parsing with the Log Parser plugin in Jenkins Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e50c186df14d57d8d9d4f49138e5557d1e8e3dc Modified Files -- ci/build_docs.sh| 4 +--- ci/build_pip_whee

[pgadmin-hackers] pgAdmin 4 commit: Include translation message catalogs in CI build/test

2017-03-31 Thread Dave Page
Include translation message catalogs in CI build/test runs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a1bb8863a8759263636b0b8aa77ad462f3ce4d4 Modified Files -- ci/ci_runner.sh | 1 + 1 file changed, 1 insertion(+) -- Sent v

[pgadmin-hackers] pgAdmin 4 commit: Make sure each build/test starts in the correct direc

2017-03-31 Thread Dave Page
Make sure each build/test starts in the correct directory. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac1637f281d320ef727c23eef135d332ee6eb8cd Modified Files -- ci/build_docs.sh| 3 ++- ci/build_pip_wheel.sh | 3 ++-

[pgadmin-hackers] pgAdmin 4 commit: Add message catalog builds to CI, and run all tests f

2017-03-31 Thread Dave Page
Add message catalog builds to CI, and run all tests from a runner script to enable test/build addition purely from the source tree. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6fa5f5b3356cb07e84e5b1c263bbff8a59d4daf Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Fix Python 3 compatibility bug

2017-03-30 Thread Dave Page
Fix Python 3 compatibility bug Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=696343196a2d758c8bca581642d4e834d11b6575 Modified Files -- pkg/pip/setup_pip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadm

<    1   2   3   4   5   6   7   8   9   10   >