Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

2017-02-06 Thread Dave Page
ile change, and when I tested it went from failing to display the node properly at all, to displaying it with the incorrect label, so it must have loaded an update. Oh well - it works now, so patch applied. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

[pgadmin-hackers] pgAdmin 4 commit: Fix display of graphical query plans for UPDATE/DELET

2017-02-06 Thread Dave Page
Fix display of graphical query plans for UPDATE/DELETE queries. Fixes #2133 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d8683e13ac9988b99fa345a7ddf40dfa2711ffe Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-02-06 Thread Dave Page
ageable. - I'm a little confused by why the tests cannot be run in server mode. The error says it's because the username/password is unknown - however, both the pgAdmin and database server usernames and passwords are in test_config.json. Thanks! -- Dave Page Blog: http://pgsnake.blogsp

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

2017-02-06 Thread Dave Page
due to typo in imageMapper object. > > Please review. It's a definite improvement, but still isn't quite right - see the attached screenshot for example; the node name should be pem.agent shouldn't it (or 'Delete' or 'Delete from pem.agent')? -- Dave Page Blog: http://pgsnake.blogspot.com T

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-06 Thread Dave Page
terpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> Hi Murtuza, >>> >>> I clearly neg

[pgadmin-hackers] pgAdmin 4 commit: Fix column addition regression test.

2017-02-06 Thread Dave Page
Fix column addition regression test. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ea8a7b211351b57646f7aec108f57623a40bb26 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-05 Thread Dave Page
> set [null] value > for boolean types. > > Please find updated patch and review. > > On Sat, Feb 4, 2017 at 6:47 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> BTW, this may help: https://css-tricks.com/indeterminate-checkboxes/ > > That's actually the soluti

[pgadmin-hackers] pgAdmin 4 commit: Handle NULL booleans in the data editor. Fixes #1790

2017-02-05 Thread Dave Page
Handle NULL booleans in the data editor. Fixes #1790 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4566877188b3e41caa3a2a786a930c98f8d1d40e Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-02-04 Thread Dave Page
;>>>>>>>> -- >>>>>>>>>> Regards, >>>>>>>>>> Murtuza Zabuawala >>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Compa

[pgadmin-hackers] pgAdmin 4 commit: Fix process execution. Fixes #1679. Fixes #2144.

2017-02-04 Thread Dave Page
Fix process execution. Fixes #1679. Fixes #2144. Re-engineer the background process executor, to avoid using sqlite as some builds of components it relies on do not support working in forked children. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-04 Thread Dave Page
anks. On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks - patch applied. > > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Hi, >> >> Please find updates patch for

[pgadmin-hackers] pgAdmin 4 commit: Add some help on data editing.

2017-02-04 Thread Dave Page
Add some help on data editing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=426ee40a714494149fe6e845f7de9a59aa37a4ba Modified Files -- docs/en_US/query_tool.rst | 8 1 file changed, 8 insertions(+) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Remove help text for an option that no longer exists.

2017-02-04 Thread Dave Page
Remove help text for an option that no longer exists. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3cc58cf3de667f2d8e31519598ed6d3e6c13f9d6 Modified Files -- docs/en_US/preferences.rst | 1 - 1 file changed, 1 deletion(-) --

[pgadmin-hackers] pgAdmin 4 commit: Support setting text fields to empty strings or NULL

2017-02-04 Thread Dave Page
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54ba1fbe593a20261eb061ca262aab45b64329de Author: Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-04 Thread Dave Page
BTW, this may help: https://css-tricks.com/indeterminate-checkboxes/ On Sat, Feb 4, 2017 at 1:15 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi, > > This seems to work nicely now for text and int fields etc. but you > haven't handled booleans. They should have a 3 state check

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-04 Thread Dave Page
support for Monday morning my time please? Thanks! On Sat, Feb 4, 2017 at 5:34 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch and review. > > On Fri, Feb 3, 2017 at 2:43 PM, Dave Page <dp...@pgadmin.org> wrote: >&g

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.p...@enterprisedb.com> > wrote: > >> I doubt the order matters, but feel free to change it if it bugs you :-) >> &

Re: [pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-02-03 Thread Dave Page
ot that it's failing to set the root >> directory properly (as you've fixed in the patch), but that it's >> trying to navigate to a previously-saved directory that no longer >> exists - in my case, /Users/dpage/foo. Per the bug report, it should >> travel back up

[pgadmin-hackers] pgAdmin 4 commit: Handle saved directories that no longer exist gracefu

2017-02-03 Thread Dave Page
Handle saved directories that no longer exist gracefully. Fixes #2110 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c17e201a92b03404065fd6518f8d33593d64e7a7 Author: Neel Patel Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Handle sized time/timestamp columns correctly. Fixes

2017-02-03 Thread Dave Page
Handle sized time/timestamp columns correctly. Fixes #2076 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf8c3c41809231e848da2f6b7daf500e1a63e2ff Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-03 Thread Dave Page
t; The Enterprise PostgreSQL Company > > On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >> > Hi Dave, >&

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

2017-02-03 Thread Dave Page
in-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Fri, Feb 3, 2017 at 3:10 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Akshay, I'll leave you to review/commit this. Please ensure that any >> tickets that p

[pgadmin-hackers] pgAdmin 4 commit: Allow direct navigation (i.e. typing of paths) in the

2017-02-03 Thread Dave Page
Allow direct navigation (i.e. typing of paths) in the file manager. Fixes #1911 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ef26a528b6b3045873302036d1a294e58c3ae85 Author: Harshal Dhumal Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-02-03 Thread Dave Page
On Mon, Jan 30, 2017 at 6:20 PM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> Can you rebase this please? >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, Jan 27, 2017 at 11:53 AM, Khus

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-02-03 Thread Dave Page
On Fri, Feb 3, 2017 at 7:28 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jan 30, 2017 at 6:18 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar >> <surinder.k

[pgadmin-hackers] pgAdmin 4 commit: Fix display of zeros in read-only grid editors. Fixes

2017-02-01 Thread Dave Page
Fix display of zeros in read-only grid editors. Fixes #2138 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=687a793383fa2531c8c2a6a9f82213c5779e470a Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Dave Page
licated and joined with an or conditional. Please double check it's OK - it looks fine to me and seems to work as expected with null, zero and one. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent v

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-02-01 Thread Dave Page
reated new connection for offline updates using "conn_id" > parameter instead of did. > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jan 30, 2017 at 8:03 PM,

[pgadmin-hackers] pgAdmin 4 commit: Properly handle setting comments and other options on

2017-02-01 Thread Dave Page
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d442da9ffd7acbc97fc28e8dc95e043fefa1617 Author: Murtuza Zabuawala

Re: [pgadmin-hackers][Patch] Show databases for Greenplum

2017-02-01 Thread Dave Page
t (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Rename the 9.1_plus templates to "default" to more ap

2017-02-01 Thread Dave Page
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d05302ca106e1f07e1372284e00507dc3058fe2 Author: George Gelashvili

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-02-01 Thread Dave Page
l ignored if I try to add a new column through the table or column dialogue. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
... but it was tests that caused it :-p On Tue, Jan 31, 2017 at 3:10 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Jan 31, 2017 at 2:54 PM, George Gelashvili > <ggelashv...@pivotal.io> wrote: >> Hi Dave, >> >> We agree that a random port would be a nice ad

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
ror just looks like a problem with the test not > being able to spin up its own server. That was on a second run of the tests, yes. I just did a careful cleanup of left-over test databases, double-checked my server wasn't running and re-ran the tests - I got the same results. > > Thanks

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-31 Thread Dave Page
it/pgadmin4/web/regression/utils/pgadmin_page.py", line 106, in _wait_for raise RuntimeError("timed out waiting for " + waiting_for_message) RuntimeError: timed out waiting for element to exist -- Thanks. --

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Dave Page
om > The Enterprise PostgreSQL Company > > On Tue, Jan 31, 2017 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Tue, Jan 31, 2017 at 10:36 AM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >> > Hi Dave, >> > >>

[pgadmin-hackers] pgAdmin 4 commit: Another Python 3 fix.

2017-01-31 Thread Dave Page
Another Python 3 fix. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0da8d1fe4c62e03157fcbee7b1f626dbae4f140c Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] pgAdmin4: Minor code change in test-suite (RM #2127)

2017-01-31 Thread Dave Page
in-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Post

[pgadmin-hackers] pgAdmin 4 commit: Disable upgrade checks during regression testing.

2017-01-31 Thread Dave Page
Disable upgrade checks during regression testing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd53e0c527db5a13f6abdaa2cdf18d26e5f42665 Author: Navnath Gadakh Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Dave Page
pgadmin4/web/pgadmin/utils/tests/test_versioned_template_loader.py", > line 50 > except TemplateNotFound, e: > ^ > SyntaxError: invalid syntax > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The

[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the template loader test.

2017-01-31 Thread Dave Page
Python 3 fix for the template loader test. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e5771e164d2f67118948c4a620a1262a47dbdeb Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum

2017-01-30 Thread Dave Page
Thanks - committed! On Mon, Jan 30, 2017 at 4:16 PM, Atira Odhner <aodh...@pivotal.io> wrote: > Whoops we accidentally left in hardcoded db config we used for running tests > from our IDE. > > Here's a fixed patch. > > On Mon, Jan 30, 2017 at 6:45 AM, Dave Page <dp...@p

[pgadmin-hackers] pgAdmin 4 commit: Bypass recovery checks with older servers. This is re

2017-01-30 Thread Dave Page
Bypass recovery checks with older servers. This is required for Greenplum which is based on PG 8.3 at present. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6b67fc66a40d477be06ac743af63c71aeb952fd Author: Atira Odhner

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues

2017-01-30 Thread Dave Page
For the record, the author was Neel, not Murtuza as I put in the commit message. Sorry Neel! On Mon, Jan 30, 2017 at 1:06 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > > On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel <neel.pa...@enterprisedb.com> > wr

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-01-30 Thread Dave Page
kers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Compan

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-30 Thread Dave Page
e comment. Both operations on other databases seem to work OK. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

[pgadmin-hackers] pgAdmin 4 commit: Ensure dialogues cannot be moved under the navbar. Fi

2017-01-30 Thread Dave Page
Ensure dialogues cannot be moved under the navbar. Fixes #2047 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e546208fa4ac91bbe1759e3981522158ee703e Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2047 - Allow user to move panel over the menu bar

2017-01-30 Thread Dave Page
gt; > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake En

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues

2017-01-30 Thread Dave Page
-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolve various trigger issues. Fixes #2015

2017-01-30 Thread Dave Page
Resolve various trigger issues. Fixes #2015 - Allow changing of row/statement flag - When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh. - Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl"

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-01-30 Thread Dave Page
Hi Can you rebase this please? Thanks. On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dp...@pgad

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-30 Thread Dave Page
On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Jan 16, 2017 at 10:01 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Fri, Jan

Re: [pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-01-30 Thread Dave Page
p the tree and navigate to the first directory in the path that does still exist (so in my case, it would go to /Users/dpage). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hacker

Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum

2017-01-30 Thread Dave Page
onnection_factory, async=async) OperationalError: fe_sendauth: no password supplied -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hacke

[pgadmin-hackers] pgAdmin 4 commit: Create a template loader for SQL templates.

2017-01-30 Thread Dave Page
Create a template loader for SQL templates. This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions. Patch by George & Tira at Pivotal. Review by me and Murtuza from

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-30 Thread Dave Page
p://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Fri, Jan 27, 2017 at 9:57 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> Scrub that Khushboo - Murtuza, can you review on Monday please? I'm >>> being told Khushboo is on the

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-30 Thread Dave Page
On Sat, Jan 28, 2017 at 1:00 AM, Jan Alexander Steffens <jan.steff...@gmail.com> wrote: > On Fri, Jan 27, 2017 at 5:56 PM Dave Page <dp...@pgadmin.org> wrote: >> >> On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens >> <jan.steff...@gmail.co

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
On Fri, Jan 27, 2017 at 4:11 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > <ggelashv...@pivotal.io> wrote: >> instead of that patch, please use this no-zombies version that kills the >> started process group inst

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Scrub that Khushboo - Murtuza, can you review on Monday please? I'm being told Khushboo is on the critical path for something else at the moment. On Fri, Jan 27, 2017 at 4:22 PM, Dave Page <dp...@pgadmin.org> wrote: > Very nice indeed! I didn't realise we'd ended up with quit

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
identical between versions. >> >> Cheers, >> George & Tira > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Pag

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
sts (or both, which should be the default). Of course, it should still be possible to just run any single test. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Dave Page
On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens <jan.steff...@gmail.com> wrote: > On Thu, Jan 26, 2017 at 3:58 PM Dave Page <dp...@pgadmin.org> wrote: >> >> In the meantime, I'm thinking something like the attached patch would >> be more appro

[pgadmin-hackers] pgAdmin 4 commit: Request Six>=1.9.0 as the current version is 1.10.0 a

2017-01-27 Thread Dave Page
Request Six>=1.9.0 as the current version is 1.10.0 and it gets pre-installed in every new virtualenv. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42d3121369df49e67a4556c7191466f4fd1014a2 Modified Files -- requirements_py2.txt

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-26 Thread Dave Page
acking. Thanks! > > On Thu, Jan 26, 2017 at 6:14 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Wed, Jan 25, 2017 at 8:02 PM, Raffi Holzer <rhol...@pivotal.io> wrote: >> >>> As a summary of our findings in writing: >>> >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-26 Thread Dave Page
Hi On Wed, Jan 25, 2017 at 2:35 PM, Jan Alexander Steffens <jan.steff...@gmail.com> wrote: > > > On Wed, Jan 25, 2017 at 2:57 PM Dave Page <dp...@pgadmin.org> wrote: >> >> One where the virtualenv is in a path that's not related to the >> location of the run

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-26 Thread Dave Page
main concern is making the right decisions on what to change, and >>> focussing efforts in the areas where we gain most benefit. Of course, >>> the resources to do the work are also critical - the current team >>> already have a good years worth of work in various a

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Dave Page
have a good years worth of work in various additional features and improvements. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgre

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Dave Page
On Wed, Jan 25, 2017 at 1:43 PM, Jan Alexander Steffens <jan.steff...@gmail.com> wrote: > On Wed, Jan 25, 2017 at 12:39 PM Dave Page <dp...@pgadmin.org> wrote: >> >> As far as I can see, this breaks usage in development environments, or >> any configurations where

[pgadmin-hackers] pgAdmin 4 commit: Enable/disable NULLs and ASC/DESC options for index c

2017-01-25 Thread Dave Page
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061. Fixes #1840. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e01cf748eafcb53c4040500c099f2e06fabf8ea8 Author: Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-25 Thread Dave Page
ues. > > Added a flag 'is_sort_nulls_applicable' which is set to true for access > method 'btree'. > If its is true, the values for options 'ASC/DESC' and 'NULLS' are included > in 'create' sql for exclusion and index otherwise not. > > Please find updated patch and review. > >

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-25 Thread Dave Page
conn_id":null,"sid":1},"result":null,"success":0} The payload sent via PUT to http://127.0.0.1:5050/browser/database/obj/1/1/12403 was: {"id":12403,"variables":{"changed":[{"role":"pgweb","name":"by

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-25 Thread Dave Page
erprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Jan 20, 2017 at 6:59 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> FYI, I've reverted this patch for now, as I found it was causing other >> problems. >> >> On Fri, Jan 20, 2017 at 5:40 AM, Murtuza

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Dave Page
where the Python code may be separated from the runtime. Am I missing something? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Dave Page
omment on column names @ ~3:03 and the comment on the bottom left @ ~3:22 (this is a great example of why email is better than a video :-) ). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent vi

[pgadmin-hackers] pgAdmin 4 commit: Update copyright year. Fixes #2109

2017-01-25 Thread Dave Page
Update copyright year. Fixes #2109 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebaf56cc4f30c1c998c9c9dc8a5391f734b9d1b Modified Files -- pkg/win32/Resources/license.rtf | Bin 1262 -> 1262 bytes 1 file changed, 0 insertions(+),

Re: [pgadmin-hackers] [Patch] Fix the Reset Statistic for a table pop up message

2017-01-24 Thread Dave Page
Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

[pgadmin-hackers] pgAdmin 4 commit: Fix Reset Statistics operation for which the popup me

2017-01-24 Thread Dave Page
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29a6f2e1244579bfdc238bd9d026d2f20ea663d6 Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: A little message cleanup.

2017-01-24 Thread Dave Page
A little message cleanup. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801c7688a39ad2ad2f52c3298962552b185476ba Modified Files -- .../server_groups/servers/databases/schemas/tables/__init__.py | 6 +++--- 1 file changed, 3

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-24 Thread Dave Page
egression/test_utils.py:69 error: web/regression/test_utils.py: patch does not apply :-( > On Fri, Jan 20, 2017 at 10:38 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili >> <ggelashv...@pivotal.io> wrote: >> > >&

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
the tests don't wait (though, I tested with 3 servers configured and >> it failed with the same error on the second and third as well, long >> after I clicked OK on the prompt): >> >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/ac

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
n 4 browser?} (Session info: chrome=55.0.2883.95) (Driver info: chromedriver=2.27.440174 (e97a722caafc2d3a8b807ee115bfb307f7d2cfd9),platform=Mac OS X 10.12.1 x86_64) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][Patch] Python 3 compatibility

2017-01-20 Thread Dave Page
t has no attribute 'has_key' > > Please find attached a fix for this. > > - George & Tira > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-ha

[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the regression tests

2017-01-20 Thread Dave Page
Python 3 fix for the regression tests Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d4cffc608c44a5574fbe433ab9fa1f9fbd58ed Author: George Gelashvili Modified Files -- web/regression/test_utils.py | 2 +-

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-20 Thread Dave Page
File >> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", >> line 149, in disconnect_database >> assert db_con.status_code == 200 >> AssertionError >> >> - Tira & George >> >> >&

[pgadmin-hackers] pgAdmin 4 commit: Revert "Handle comments on databases with datallowcon

2017-01-20 Thread Dave Page
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024" This reverts commit e431eb9d8ecc28572b39d26c9effcf66f70f6ae1. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac4178233b8772f964825f8c8e0c95e23feddcc1

Re: [pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]

2017-01-20 Thread Dave Page
r > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- D

[pgadmin-hackers] pgAdmin 4 commit: Properly remove any event listeners added by subnode

2017-01-20 Thread Dave Page
Properly remove any event listeners added by subnode control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=415119d5814054cdce6f16a9545ccd35c91270a7 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-01-20 Thread Dave Page
is specific to the object, or the database default. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2069-Dave.patch Description: Binary data -- Sent via pgadmin-hackers mailing li

[pgadmin-hackers] pgAdmin 4 commit: Fix typo in virtualenvwrapper's name. Fixes #2083

2017-01-18 Thread Dave Page
Fix typo in virtualenvwrapper's name. Fixes #2083 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff199f4582dd1a0506952fb2f65e0bb68d403c96 Modified Files -- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 4:50 PM, Bruno Friedmann <br...@ioda-net.ch> wrote: > On mardi, 17 janvier 2017 09.23:49 h CET Dave Page wrote: >> Hi >> >> On Mon, Jan 16, 2017 at 5:20 PM, Bruno Friedmann <br...@ioda-net.ch> wrote: >> > In packaged world,

[pgadmin-hackers] pgAdmin 4 commit: Fix display of enum GUCs on users/databases etc. Fixe

2017-01-17 Thread Dave Page
Fix display of enum GUCs on users/databases etc. Fixes #2067 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6557433061a471262e05080d16b2c6b34edc5aa2 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: To fix the issue in Variable control (pgAdmin4)

2017-01-17 Thread Dave Page
t in model. > RM#2067 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http

Re: [pgadmin-hackers] PATCH: To display column information properly in Properties Panel (pgAdmin4)

2017-01-17 Thread Dave Page
xt. That's for another day though :-). Thanks - patch applied. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make c

[pgadmin-hackers] pgAdmin 4 commit: Improve display of columns of exclusion contraints an

2017-01-17 Thread Dave Page
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28621999f22805852cd19ad7dca2a72cfb676e7e Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 9:52 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi > On Tue, Jan 17, 2017 at 3:08 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar >>

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
gt; On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <fahar.ab...@enterprisedb.com > > wrote: > >> Please attached the log files output from the terminal and pgAdmin4.log. >> >> Kind Regards, >> >> >> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dp...@pg

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
gt; Please find attached the snapshot. > > Kind Regards, > > On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> &g

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
ns disable for access methods > other than 'btree'. > 3) Add validation for name field. Those bits do though :-) Please fix 1). Thanks! > On Fri, Nov 25, 2016 at 5:16 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar >

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
SUSE security team if they digg in, and also to > suspicious users. I have no idea what that is, and can't find any reference to either the IP or domain in the code. I also cannot reproduce it on my machine. I wonder if it could be Qt Web Engine loading some plugin you have for Chrome or so

<    4   5   6   7   8   9   10   11   12   13   >