[pgadmin-hackers] [PATCH] extract function from sqleditor

Hello Hackers! Re. https://www.postgresql.org/message-id/CAFS4TJb- 7VTQQrnOi0g6MaoxMfEK9LzCds2yG%2BByS-mLHwydQA%40mail.gmail.com We extracted the function bound to onSelectedRangesChanged from sqleditor! - we read through the existing implementation and wrapped it in `web/regression/javascript/s

[pgadmin-hackers] feature test timeouts

Hello Hackers, We are running tests including feature tests in Circle CI, and have been seeing some flakiness due to what we believe are insufficient wait-for timeouts. This shouldn't increase the overall test time, but only allow waiting longer for an element to appear, if needed. We've also sp

Re: [pgadmin-hackers] javascript and css minification process

> > It's not yet. Those are utility scripts that I was eventually intending to > call from appropriate make targets during package build. Before we get > there though, we need code changes to ensure that we load minified code vs. > debug code at the appropriate times. I haven't done much with it in

[pgadmin-hackers] javascript and css minification process

Hello We're looking at the js and css minimization python code to investigate minification as part of the pgadmin artifact build process. We're wondering why minimise.py is currently only manually invokable, via the minimise make step. Also it seems like currently, minimise.py's dependencies (rc

[pgadmin-hackers] [patch] Query Output Header Width

Hello Hackers, We found that having the column header extend all the way across the query output frame made it seem like there were more columns. This was confusing to some users. We made a change to the column header styling so it ends with the rightmost column. Happy Friday! Matt & Shirley & G

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hi, We've updated Murtuza's README change to be more consistent with other instructions - adding a colon and newline. -Matt and George On Fri, Mar 31, 2017 at 10:47 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor add-on patch for README. > > -- > Regards,

Re: [pgadmin-hackers] connection error

nd here's a patch On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili wrote: > Hi Hackers! > > Our tests found a bug with the current version of master, that was > introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262. > It is throwing an error when the

[pgadmin-hackers][patch] Fixes QT build when not signing

Hello Hackers! We were building the QT app locally with QTDIR, PGDIR, PYTHON_HOME, and PYTHON_VERSION set, and by running: make appbundle We were seeing the runtime error: > Could not find QtWebEngineProcess > Abort trap: 6 after a successful python server start. We found that the setup before

Re: [pgadmin-hackers] Communication Channels

Got it. Thanks again for speaking with us earlier! On Thu, Feb 9, 2017 at 12:13 PM, Dave Page wrote: > Hi > > On Thu, Feb 9, 2017 at 5:02 PM, George Gelashvili > wrote: > > Hello Hackers, > > > > We were wondering if there is a pgadmin-hackers IRC or similar se

Re: [pgadmin-hackers] building with Qt runtime question

nts from here? On Fri, Feb 10, 2017 at 8:50 AM, Dave Page wrote: > Hi > > On Thu, Feb 9, 2017 at 11:22 PM, George Gelashvili > wrote: > > Hello Hackers! > > > > We're having trouble building the app with Qt runtime. > > We've tried running m

[pgadmin-hackers] building with Qt runtime question

Hello Hackers! We're having trouble building the app with Qt runtime. We've tried running make appbundle after setting PGDIR, QTDIR, PYTHON_HOME, and PYTHON_VERSION environment variables. We've tried setting PYTHON_HOME to the roots of brew (effectively, system) python as well as the virtualenv we

[pgadmin-hackers] Communication Channels

Hello Hackers, We were wondering if there is a pgadmin-hackers IRC or similar setup for closer-to-realtime communication? Thanks! George

[pgadmin-hackers][patch] We can see tables in Greenplum!

Hello Hackers! We've a fix for displaying table nodes when connected to Greenplum. The salient bit was leaving off tgisinternal from the default template (but leaving the template used for postgres 9.1+ unchanged). We also added a Database helper class in test_utils for setting up and tearing down

[pgadmin-hackers][patch] change --pkg behavior

tests to run. This complements the --exclude behavior we are working on. To run tests for a single node, ".tests" can be appended to the package path (see changes to README) George & Tira commit caa1e3e69fefc6172d54f21d42c13686b858c4f9 Author: George Gelashvili and Tira Odhner Date:

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi Dave, We agree that a random port would be a nice addition. We think having randomized test database names can lead to polluting with lots of extra databases left around in the event that cleanup fails for whatever reason (e.g. a test errors out). We see this happen already with the randomized

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

an 27, 2017 at 4:11 PM, Dave Page wrote: > > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > > wrote: > >> instead of that patch, please use this no-zombies version that kills the > >> started process group instead of pid-only. > > > > Very cool :-). The

[pgadmin-hackers][Patch] Bypass recovery state for Greenplum

This bypasses checking if the DB is in recovery for versions of postgres that don't support pg_is_in_recovery() (anything pre-9.0, such as Greenplum). This patch depends on the "Refactor sql template version picking" patch. diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

e we didn't see anywhere else obvious. On Fri, Jan 27, 2017 at 11:43 AM, Dave Page wrote: > Good point. How about just versioned_loader? > > On Fri, Jan 27, 2017 at 4:40 PM, George Gelashvili > wrote: > > That would work, but the versioned template loader can load anything &

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

That would work, but the versioned template loader can load anything that is a template, as it extends from DispatchingJinjaLoader On Fri, Jan 27, 2017 at 11:39 AM, Dave Page wrote: > sql_loader ? > > On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili > wrote: > > Thanks!

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

t; > can you take a look first thing on Monday please? If you're happy, > > I'll commit and ask Fahar to do some testing. > > > > Thanks! > > > > On Thu, Jan 26, 2017 at 8:48 PM, George Gelashvili > > wrote: > >> As a followup, we created

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

instead of that patch, please use this no-zombies version that kills the started process group instead of pid-only. On Wed, Jan 25, 2017 at 6:31 PM, George Gelashvili wrote: > ah > That diff was generated before the python 3 patch was applied. This should > work against master &

[pgadmin-hackers][Patch] Refactor sql template version picking

Hi Hackers! Since we are preparing to add greenplum support, we made a new template loader to automatically pick the available sql template file that corresponds to the postgres version number. Our next patch will be to remove duplicated sql template files since many of the files are identical be

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

ah That diff was generated before the python 3 patch was applied. This should work against master Cheers, George On Tue, Jan 24, 2017 at 4:43 AM, Dave Page wrote: > On Fri, Jan 20, 2017 at 5:33 PM, George Gelashvili > wrote: > > Thanks for bringing that to our attention! Here&

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Thanks for bringing that to our attention! Here's the latest patch On Fri, Jan 20, 2017 at 10:38 AM, Dave Page wrote: > On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili > wrote: > > > > Here is an updated patch which starts the server up when the test starts > an

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Here's an updated patch which polls to wait for the app to start instead of sleeping for 10 seconds. On Thu, Jan 19, 2017 at 5:07 PM, George Gelashvili wrote: > > Here is an updated patch which starts the server up when the test starts > and uses the values from config.py for s

[pgadmin-hackers][Patch] Python 3 compatibility

Hello We stumbled on the following error when running tests off of master: Traceback (most recent call last): File "web/regression/runtests.py", line 254, in servers_info = test_utils.get_config_data() File "/Users/pivotal/workspace/pgadmin4/web/regression/test_utils.py", line 72, in get

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

ts own pgAdmin yet and > it definitely doesn't fill in username/password if your app is running that > way. That's part of the WIP-ness :-P > > -Tira > > Hi > > On Thu, Jan 12, 2017 at 10:41 PM, George Gelashvili > wrote: > > here's the patch we forgot t

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

Hi Dave and Murtuza, FYI - on our machines, running the DatabasesUpdateTestCase fails with an error after e431eb9d8ecc28572b39d26c9effcf66f70f6ae1: Traceback (most recent call last): File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

here's the patch we forgot to attach. Also, you can see work on our branch at: https://github.com/pivotalsoftware/pgadmin4/tree/pivotal/acceptance-tests On Thu, Jan 12, 2017 at 5:26 PM, George Gelashvili wrote: > Hi there, > > We are working on browser-automation-based accepta

[pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi there, We are working on browser-automation-based acceptance tests that exercise pgAdmin4 the way a user might. The first "connect to database" test works, but at the moment depends on Chrome and chromedriver . We would appreciate feedback

Re: [pgadmin-hackers] Driver Module

t; > On Wed, Jan 11, 2017 at 8:07 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jan 11, 2017 at 10:24 PM, George Gelashvili >> wrote: >> > Hi Dave, >> > >> > Thanks for the pointer. >> > We realized that many of the changes we wou

Re: [pgadmin-hackers] Driver Module

. Any thoughts on this? Thanks, Tira and George On Sun, Jan 8, 2017 at 4:57 AM, Dave Page wrote: > Hi > > On Friday, January 6, 2017, George Gelashvili > wrote: > >> Hi there, >> >> We are working on connecting Greenplum to pgAdmin4. Currently we are >> explo

[pgadmin-hackers] Driver Module

Hi there, We are working on connecting Greenplum to pgAdmin4. Currently we are exploring how modules work in pgAdmin. In an earlier off-thread email it was suggested we look at "the EDB PPAS" as an example of a driver class. We are not entirely clear on what that means. We found: - the BaseDriver