Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, Please find attached patch where I have added timeout of 2 seconds before selecting object menu in connect to server function. Note: Apply this patch on top of previous patch for on demand loading feature. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: > Hi > > On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal > wrote: > > Hi Dave, > > > > Please find attached updated patch. > > > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: > >>

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

-1.11.2.js:3255) at done (jquery-1.11.2.js:9309) at XMLHttpRequest.callback (jquery-1.11.2.js:9713) success @ VM4124 datagrid.js:440 fire @ jquery-1.11.2.js:3143 fireWith @ jquery-1.11.2.js:3255 done @ jquery-1.11.2.js:9309 callback @ jquery-1.11.2.js:9713 -- *Harshal Dhumal* *Sr. Software Engineer

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

com/> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > >> >> Thanks. >> >> On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal >> wrote: >> > Hi, >> > >> > >> >

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Ignore this patch. Rebase and migration of feature tests and jasmine tests required. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 3:56 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Please find attached rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 7, 2017 at 6:59 PM, Dave Page wrote: > Can you rebase this please? I think Ashesh broke it :-p > > On Tue, Ju

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

27; must be numeric. > Fixed. Please find attached updated patch. > > Thanks. > > On Tue, May 30, 2017 at 8:28 AM, Harshal Dhumal > wrote: > > Hi, > > > > Please find updated patch. > > > > -- > > Harshal Dhumal > > Sr. Software Engineer >

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 12:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please ignore this patch as I forgot to include few changes. I'll send updated one. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 29, 2017 at 3:18 PM, Harshal Dhumal < har

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

group. Also I have updated all other nodes which uses Numeric controls -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 19, 2017 at 12:22 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote:

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

] , grid:grid} ) causes grid to re-render (as we listener on onAddNewRow event where we re-render the grid) -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sun, May 28, 2017 at 12:21 AM, Dave Page

[pgadmin-hackers] Update pgAdmin4 version on pgadmin.org from 1.4 to 1.5

Hi Dave, Text 1.4 is not updated to 1.5 on pgadmin.org [image: Inline image 2] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

d that the following change sets look very similiar. Is > there any reason to have this code duplicated? If not this could be a good > time to refactor it. > As said earlier in response of point 2 code duplication is because the way controls are derived. > +++ b/web/pgadmin/stati

[pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please find attached patch for RM2421 Issue fixed: 1. Integer/numeric Validation is not working properly. 2. Wrong CPU rate unit -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi, Here is updated patch to fix issue with node rename. In this patch I have fixed issue which I mentioned earlier in this mail thread. @Murtuza, as you know all other scenarios, can you please test this patch once. Thanks, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

nit__ should be tested. > At this point we don't have any python unit tests that can test sqleditor backend (python code). @Dave should I include python unit test cases in this patch? > > --Joao and George > > > On Fri, May 12, 2017 at 8:32 AM, Harshal Dhumal < > harsha

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi, Issue caused because variable temp_new_rows was access before it was initialised. Attached patch fixes this issue. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 9:28 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Dave, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:43 PM, Dave Page wrote: > So is the last patch considered good? > Except one thing, when user renames server group (not

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Murtuza, Currently nodes are sorted in case sensitive manner it should be case insensitive. See current Server group order is A, Servers, a1, a​2. It should be A, a1, a2, Servers. Similarly check sorting order for server and database nodes -- *Harshal Dhumal* *Sr. Software Engineer

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

ser adds new row (do not save) and then copy past few exiting rows (at this point newly added row no longer remains at last position). And after saving it disable last row which is not the newly added row. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterpri

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear wrote: > Hi Harshal! > > We applied your patch and ran the Javascript tests and realized there are > 6 t

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 8, 2017 at 4:49 PM, Dave Page wrote: > Hi > > This is fantastic! The speedup in the query tool is phenomenal with large > result s

[pgadmin-hackers] patch for RM2292 [pgadmin4]

Hi, Pls find patch for RM2292 Changes: While restoring connections after app restart only establish connection if that connection was connected previously. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgadmin-hackers] Fix for csv download issue [RM2253] [RM2214] [pgadmin4]

Hi, Pls find attached patch for csv download issue when data contains non ASCII characters. And also when table name contains non ASCII characters -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, Here is patch for initial implementation of on demand loading of result set for query tool and datagrid. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 25, 2017 at 5:21 PM, Dave Page wrote: >

[pgadmin-hackers] Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Let me know your opinion on this. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

Hi, PFA patch for RM2305. Issue: Generic function qtLiteral was not adapting values properly which contains non ascii characters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/driver

[pgadmin-hackers] Re: [pgAdmin 4 - Bug #2274] Row Deletion Against Tables With PKs Not at Ordinal 0 Position Fail

cols as primary key. 4. Table with 4 columns with 2nd and 4th cols as primary key. 5. Table with 4 columns with 4th col as primary key. 6. Table with 4 columns with 1st col as primary key. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

[pgadmin-hackers] [RM2283] [pgAdmin4] minor patch for select2 cell

Hi, PFA minor patch for RM2283. Issue: When setting default selection of multiple values we need to check if select2 cell is in multiselect mode. We need to check this as javascript assumes string as array of chars and tries to set individual char as selected option in cell. RM2283.patch Descri

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

Hi, Please find updated patch for RM2244. Changes: View Data was broken in last patch when table contains more that 1 column. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Mar 20, 2017 at 4:10 PM, Dave Page

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

Hi, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 17, 2017 at 4:04 PM, Dave Page wrote: > Hi > > On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal > wrote: > > Hi, > > > >

[pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

Hi, Here is patch for RM2243 and RM2244 Changes: 1. Pickup correct encoding in qtLiteral to decode. 2. While releasing database connection only decode database name if it's not unicode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enter

[pgadmin-hackers] Numeric controls validation issue in nested schema [pgAdmin4]

Hi, PFA minor patch for numeric control . This Fixes #2241 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi, Please find updated patch for encoding issue. Apart from encoding issue I have also fixed issue of wrong data was show in query editor for string types and array string types for databases with encoding other than utf-8. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Note: Apply patches which I have just sent (with subject pgAdmin4 minor issues [pgAdmin4]) before applying this patch. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Feb 17, 2017 at 4:22 PM, Murtuza Zabuawala

[pgadmin-hackers] pgAdmin4 mirror issues [pgAdmin4]

ate: 54000 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/event_triggers/templates/event_triggers/sql/9.3_plus/properties.sql b/web/pgadmin/browser/ser

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 6:48 PM, Dave Page wrote: > Hi > > On Mon, Feb 6, 2017 at 12:57 PM, Harshal Dhumal > wrote: > > Hi, > > > &

[pgadmin-hackers] Patch from RM1983 [pgAdmin4]

not decoded properly. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py index

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi, Pls find updated patch (V7) for direct file navigation with below bug fixes. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 16, 2017 at 8:42 PM, Dave Page wrote: > Hi > > On Sat, Jan 14, 201

[pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]

Hi, This patch includes following change: Properly remove any event listeners added by subnode control. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company subnode_cleanup.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi, Pls updated patch for RM1911. 1. This includes fix for issue index out of range when user enters path of folder without trailing slash (showed by Dave). 2. To make this functionality compatible with save last used directory feature. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB

Fwd: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi Dave, Please find attached rebased patch. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sun, Jan 8, 2017 at 4:07 PM, Dave Page wrote: > Hi > > Can you rebase this please? It no longer applies :-(

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi Dave, Here is updated (V4) patch. Changes: 1] Now can enter both type of slashes ( / and \ ) and all will get replaced with the platform standard. 2] Added unicode support. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi Dave, Please find updated patch below for direct file navigation. I have covered all of above mentioned case. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Nov 25, 2016 at 4:09 PM, Dave Page wrote: >

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi Dave, Please find updated attached patch for RM1911 (V2) -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Nov 21, 2016 at 7:48 PM, Dave Page wrote: > Hi > > On Sat, Nov 19, 2016 at 5:57 PM, Harsh

[pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

Hi, PFA for RM1911 Feature added: Allow user add file/folder path directly in input field. Other improvements like clean up after file manager is closed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

Re: [pgadmin-hackers] PGAdmin 4 Bug report

Hi, This is known issue and already reported here https://redmine.postgresql.org/issues/1797 This will be taken care in future release. Until this issue gets fixed you can use normal english characters in directory name/path. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Oct 24, 2016 at 1:34 PM, Dave Page wrote: > Hi > > On Mon, Oct 24, 2016 at 7:27 AM, Harshal Dhumal > wrote: > > Hi Dave, >

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

Hi Dave, I mean reverse engineered sql tab. Currently it's not implemented for both pgagent schedule and jobs. I have created Rm for that RM1891 <https://redmine.postgresql.org/issues/1891> -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The

[pgadmin-hackers] patch for RM1875 exclusion constraint support for pg-9.6 [pgAdmin4]

Hi, PFA patch for RM1875. Issue fixed: 1. Exclusion constraint added support for pg-9.6 2. Fixed index out of list (python error) when Exclusion constraint is created without name. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

l tab) for step. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore this patch as I haven't

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

Hi, Please ignore this patch as I haven't fixed same issue for schedule. Also there is issue "malformed array literal" when we try to save schedule. I'll be sending updated patch. Thanks Harshal, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.

[pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

Hi, PFA attached patch for pgagent issue RM1878 issue fixed: ProgrammingError: can't adapt type 'Undefined' -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/

[pgadmin-hackers] patch for RM1863 [pgadmin4]

Hi, PFA patch for RM1863. Issue fixed: Correctly interpret composite data type for columns while generating sql. also minor UI improvement in foreign key column tab -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgadmin-hackers] patch for RM1861 [pgAdmin4]

Hi, PFA minor patch for RM1861. Issue fixed: SQL not generated for exclusion constraint on table -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas

[pgadmin-hackers] Patch for RM1531 and other improvements related to same issue [pgAdmin4]

Hi, PFA patch for RM 1531. Changes: 1. Fixed update privileges for views and materialized views. 2. Apart from this fixed wrong sql for privilege update. 3. Fixed: Error message was not got cleared even after removing entry with error on privilege tab. -- *Harshal Dhumal* *Software Engineer

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi, Please find attached updated patch for RM1720. Also test this patch with updated test suite patch which Navnath would be sending. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 21, 2016 at 8:39 PM

[pgadmin-hackers] Patch for RM1720 [pgadmin4]

another in some cases. To avoid this issue we now deleting server connection details (server manger) when user drops server. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

Ok, I'll do that once that work is completed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 1, 2016 at 3:57 PM, Dave Page wrote: > Per my earlier email to Priyanka, I'm not going to commit

[pgadmin-hackers] Package node test cases [pgadmin4]

Hi, PFA patch for package node test cases. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/tests/__init__.py b/web/pgadmin/browser

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:45 PM, Dave Page wrote: > Hi > > On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal > wrote: > > Hi, > > PFA pa

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

Hi, PFA patch for wrong header and body were generated. Fixed the header and body sql parsing issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:10 PM, Khushboo Vashi < khushboo

[pgadmin-hackers] patch for RM1538: show db default acls [pgadmin4]

Hi, PFA patch for rm 1538 to show default database privileges in properties mode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js

[pgadmin-hackers] [pgadmin4] fix for RM1417

Hi, PFA patch for issue RM1417. Changes: Fixed privileges parsing issue while editing privileges of exiting object. Additional Note: This was general issue and was not related to runtime or pg 9.6. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The

[pgadmin-hackers] patch for RM1177 [pgadmin4]

Hi, PFA patch for RM1177. Issue fixed: Added a check to warn the user if the binary path is not set before running external commands. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

[pgadmin-hackers] RM1492 [pgadmin4]

Hi, PFA patch for RM1492 Issue fixed: Generate proper queries for "View all/first 100/last 100 rows" with table containing columns with capital letters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff -

Re: [pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 3, 2016 at 6:30 PM, Dave Page wrote: > Hi > > On Wed, Aug 3, 2016 at 12:43 PM, Harshal Dhumal > wrote: > > Hi Dave, > > > > This because o

[pgadmin-hackers] patch for RM1450 [pgAdmin4]

Hi, PFA patch for RM1450. Changes: Added save password option in sever create mode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin

Re: [pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

Hi Dave, This because on python 2.X simplejson throws KeyError instead of TypeError if any error occurs while loading json data from given object. Now I have handled that exception as well in attached patch. I'm sending this as separate patch instead part of RM1500. -- *Harshal D

[pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

real (and vice versa) 8] Renaming constraint (RM1500). -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/browse

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA updated patch for RM1260 (V4). Fixed create and delete operations for foreign table. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi wrote: > Hi Hars

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

and patch file -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM1260. > >

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA updated patch for RM1260. In addition to RM1260 issue I have added following changes in this patch. 1] datamodel.js: Added option check against undefined. 2] foreign key: fixed first empty option issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

[pgadmin-hackers] Fix for RM1154: Show proper error message for already delete object [pgadmin4]

Hi, PFA patch for rm1154. Issue fixed: Show proper error message if try to delete already deleted object. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers

[pgadmin-hackers] patch for RM1497

Hi, PFA attached for rm1497 Issue: fixed js error while re-rendering shubnode grid -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables

Re: [pgadmin-hackers] patch for RM1460 [pgAdmin4]

Hi Dave, Can you please try again with clean cache. Above mentioned scenario is working fine for me. Thanks. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 22, 2016 at 9:13 PM, Dave Page wrote: >

Re: [pgadmin-hackers] patch for RM1460 [pgAdmin4]

Hi, PFA attached patch to show save as option always and to show menu save option only when file is changed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 21, 2016 at 6:18 PM, Dave Page wrote: >

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

Hi, PFA rebased patch for RM1293 and RM1294. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please fin

[pgadmin-hackers] patch for RM1460 [pgAdmin4]

. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/datagrid/templates/datagrid/index.html b/web/pgadmin/tools/datagrid/templates/datagrid/index.html index 67cf107..1611887 100644 --- a/web/pgadmin/tools

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch RM1405 (version 4) Neel will be sending patch for QT issue for same functionality. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 18, 2016 at 4:02 PM, Dave Page wrote: > Perf

Re: [pgadmin-hackers] Regarding issue 1241

Hi, PFA patch for issue RM1241 Changes: 1. Altered variable control to make its UI consistence with privileges and Security labels. 2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for example) -- *Harshal Dhumal* *Software

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch for RM1405 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Yes sure > > -- &g

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes sure -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: > Hi > > Can you rebase this please? > > Thanks. > > On Mon, Jul 11, 2016 at 9:

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

to use download attr. of anchor tag () as it's not support by all of major browsers (e.g. Safari). Also it's not feasible to load data in html to download if result set of query is very huge (in GBs). -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.co

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA updated patch for issue RM1260 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > Please ignore this p

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, Please ignore this patch as this has some minor issue. I'll sent updated one. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.co

[pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

Hi, PFA patch for issue RM1260. Changes: Issue wasn't related to foreign table but was due the Select2 control. Now I have improved select2 control to handle null value in multi-select mode. Initial it was returning "null" instead it should return [] (empty array). --

[pgadmin-hackers] patch for issue RM1418 and RM1434 [pgadmin4]

Hi, PFA patch for Issue RM1418 and RM1434 Issues fixed: 1. Select2 control fixed for multi-select mode. 2. Index constrains (primary and unique key) fixed column listing issue. 3. Table node "inherited from" (Select2 control) was not showing table name with public schema -- *Hars

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

: 4267545e08cb28b8c4574bb7a5da0322ef7728d2 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 24, 2016 at 4:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue RM#12

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA updated patch for RM1336 and keyboard shortcuts file separately. This patch is same as last patch except I have removed keyboard shortcut list from this patch. Also please see my inline response below. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA patch This contains: 1] All shortcuts' list which we are using in pgAdmin4. 2] Fixed shortcut display tooltips. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 2:34 PM, Dave Page

[pgadmin-hackers] fix for issue rm1425 [pgAdmin4]

Hi, PFA patch for issue RM1425. Issue fixed: Loading panel does not hide in Mac runtime due error in js. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/index.html b

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are Shift+Command+E, Shift+Command+X, Shift+Command+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:05 AM

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, Here is updated patch for RM1336 Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterpri

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA upadated patch for RM1336 Issue fixed: Query tool shortcuts weren't working on mac runtime. Also changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" dialog in run

[pgadmin-hackers] Patch for RM1399 [pGADMIN4]

Hi, PFA patch for issue rm1399 Issue: Sometimes codemirror does not render properly in SQL tab -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

One more thing that this also fails in pgadmin3 as well. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 23, 2016 at 6:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, >

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

*"!#$%^&*()_+{}|:\"<>?=-\\][';/**.,"* but in pg_dump error it says *failed: invalid connection option "!#$%^&*()_+{}|:"<>?"* -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise Postgre

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

Hi, PFA updated patch for issues 1220 and 1221 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 21, 2016 at 4:41 PM, Dave Page wrote: > Hi > > On Tue, Jun 21, 2016 at 11:38 AM, Harshal Dhumal

  1   2   3   >