Re: [pgadmin-hackers] SQL formatting

Hello jarek, Upcoming release will have a new feature, external formatting tool. You can setup pgAdmin to invoke your script with Ctrl-Shift-F in the query editor. There are a few other utilities available, see discussion http://www.postgresql.org/message-id/110456625.20150503104...@mail.ru http:

Re: [pgadmin-hackers] [Patch] Windows installer: allow manually setting WIXDIR as appropriate.

Hello, +1 I proposed the same once but had no feedback. Nikolai, why doesn't the first version work for you? I have it done similar: if NOT "%WIXDIR%"=="" GOTO WIXDIR_SET SET WIXDIR="C:\Program Files (x86)\Windows Installer XML v3\bin" :WIXDIR_SET Saturday, October 3, 2015, 12:10:30 AM, Nikol

Re: [pgadmin-hackers] Repaint lockup in ctlSQLBox::OnPositionStc on windows (Was: SQL-panel causes 100% CPU and lockup on windows)

Hello Nikolai, Appreciate your research! I suggest you to send a *.patch (git diff) attachmeht to the list for the team members and others interested to test it in their environments. Sunday, October 4, 2015, 1:36:45 AM, you wrote: NZ> Hi all, NZ> ok, it is broken since this commit: NZ> http

Re: [pgadmin-hackers] [pgadmin-support] Stability and compatability issues on windows xp

Hello, NZ> So, is it planned e.g. to publish some beta windows binaries? +1 for publishing beta binaries. NZ> I'm on windows xp sp3 (32-bit). Windows XP is not supported officially, http://www.pgadmin.org/download/windows.php From v1.16.0, Windows XP/2003 or later is required, and from 1.20.

Re: [pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

Hi Ashesh, Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste items are disabled all the time (seen on Ubuntu, Kubuntu). Tuesday, September 22, 2015, 10:56:32 AM, you wrote: AV> Resolved an issue related enable/disable menu items in Query Editor AV> specifically for Unity Deskto

Re: [pgadmin-hackers] PATCH: improve sorting in the Data Editor

isedb.com> wrote: Sanket, Can you please review it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company http://www.linkedin.com/in/asheshvashi On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <jinfros...@mail.ru> wrote: Hello, Here is a small improvement a

Re: [pgadmin-hackers] PATCH: improve sorting in the Data Editor

an you please review it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company http://www.linkedin.com/in/asheshvashi On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <jinfros...@mail.ru> wrote: Hello, Here is a small improvement about sorting in the Data editor.

Re: [pgadmin-hackers] PATCH: improve sorting in the Data Editor

3, 2015 at 10:49 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: Sanket, Can you please review it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company http://www.linkedin.com/in/asheshvashi On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <jin

[pgadmin-hackers] PATCH: improve sorting in the Data Editor

Hello, Here is a small improvement about sorting in the Data editor. Problem: If a table has a PK or OIDs, it gets sorted by PK/OID by default. When a user wants to sort by any other column, he has first to click "Remove sort" in the context menu, and only then click "Sort ascending"(descending)

Re: [pgadmin-hackers] Running an SQL command that works after detaching from my SSH tunnel?

Hello Jacek, Anyway, you'll want to make queries run by client on the remote site (on database host itself or another long-running machine with stable connection). Regarding pgAdmin running on your machine, there isn't much you can do with it. You can create pgAgent jobs for long running queries

Re: [pgadmin-hackers] PATCH: Format SQL (external tool)

J>> Hi J.F AJ>> The version of fsql you have suggested works for me as well. I AJ>> have reviewed your patch and it looks good to me. Please remove AJ>> the commented code (wxString s; //, tmp  at line 873 in sysSettings.cpp. AJ>> On Mon, May 18, 2015 at 10:31 PM, J

Re: [pgadmin-hackers] Fwd: PATCH: Format SQL (external tool)

me. Please remove AJ>> the commented code (wxString s; //, tmp at line 873 in sysSettings.cpp. AJ>> On Mon, May 18, 2015 at 10:31 PM, J.F. Oster wrote: AJ>> Hi Akshay, AJ>> fsqlf.exe is the program to use; wx_fsqlf.exe is just a GUI wrapper. AJ>> I've got th

Re: [pgadmin-hackers] Fwd: PATCH: Format SQL (external tool)

Settings.cpp. AJ> On Mon, May 18, 2015 at 10:31 PM, J.F. Oster wrote: AJ> Hi Akshay, AJ> fsqlf.exe is the program to use; wx_fsqlf.exe is just a GUI wrapper. AJ> I've got the latest version (fsqlf.v0.03-292-gd0fd9bf.zip), and it really fails to run AJ> Please try the p

Re: [pgadmin-hackers] Fwd: PATCH: Format SQL (external tool)

. On Mon, May 18, 2015 at 10:10 AM, Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: Sure. On Fri, May 15, 2015 at 9:30 PM, Dave Page <dp...@pgadmin.org> wrote: Akshay, can you take a look please? Thanks. On Fri, May 15, 2015 at 4:53 PM, J.F. Oster <jinfros...@mail.ru> wrote

[pgadmin-hackers] Fwd: PATCH: Format SQL (external tool)

Hello! Please take a look at the patch. Thanks. Per discussion http://www.postgresql.org/message-id/capyomk5nt9tm-r3womblzoy60vqa+qyrdy4u84_2k9uwlbw...@mail.gmail.com It's most useful for making readable queries generated by ORMs such as Hibernate. But in general, external processing can go far

Re: [pgadmin-hackers] Server Status window displays nothing

Hello Adam, Could you try a build with wxWidgets 2.8.12 ? Looks like there are some bugs with refreshing/drawing in wxWidgets 3.0. Thursday, May 14, 2015, 1:08:21 AM, you wrote: > On Mon, May 4, 2015 at 1:19 AM, Ashesh Vashi wrote: On Sun, May 3, 2015 at 8:27 PM, Adam Dingle

[pgadmin-hackers] PATCH: Format SQL (external tool)

Hello All! Per discussion http://www.postgresql.org/message-id/capyomk5nt9tm-r3womblzoy60vqa+qyrdy4u84_2k9uwlbw...@mail.gmail.com It's most useful for making readable queries generated by ORMs such as Hibernate. But in general, external processing can go far beyond formatting task. I've implemen

[pgadmin-hackers] PATCH: focus on browser tree on startup

Hi! Explicitly set focus on the browser tree on startup. I've noticed that on Ubuntu that doesn't happen automatically but on Windows does! Make it consistent. -- Best regards, J.F. 150419_browser_focus.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@

Re: [pgadmin-hackers] PATCH: Add missing nodes to graphical explain plan

Hello Dave, I wonder if this patch will get into 1.20... Wednesday, November 5, 2014, 5:25:10 PM, J.F. Oster wrote: JFO> Hello, JFO> Per recent discussion on pgadmin-support ("index only scans are not JFO> shown graphically"), JFO>> Insert JFO>> Update JFO&

Re: [pgadmin-hackers] Some trivial patch

Hello, Regarding the patch, I confirm successful build on Windows and Ubuntu. Monday, November 3, 2014, 11:53:50 AM, Mads Jensen wrote: MJ> A couple of improvements. I can compile without the wx/regex.h header on MJ> Ubuntu 14.04, and also the WXK_SPACE works. MJ> I still haven't fully grasped

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Mon, Oct 27, 2014 at 4:14 PM, Dave Page wrote: SM> Ashesh, can you review/commit this please? SM> On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster wrote: >> Hello! >> >> This patch adds a few missing lines of code to handle smallserial >> columns the same way as serial and bi

Re: [pgadmin-hackers] pgAdmin III commit: Beautify the query shown in the SQL pane for the fu

d small modification done by Ashesh Vashi. AV> Branch AV> -- AV> master AV> Details AV> --- AV> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ea803ad68290bb506fd2148ee8ea8f4176e34197 AV> Author: J.F. Oster AV> Modified Files AV> -- AV&g

Re: [pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

Now contents of the second file is replaced on disk with contents of the previous file. SM> On Mon, Oct 27, 2014 at 4:14 PM, Dave Page wrote: SM> Ashesh, can you review/commit this please? SM> On Fri, Oct 24, 2014 at 8:35 PM, J.F. Oster wrote: >> Hello! >> >> A user may

[pgadmin-hackers] PATCH: Stored procedure large parameter list

Hello! Please consider this patch. It's a small formatting improvement for pgFunction::GetSql() per discussion: http://www.postgresql.org/message-id/CAHYn==4bqljo5y+aganc-hwrtkhpyduueq_nvbpbpypb5jr...@mail.gmail.com -- Best regards, J.F. 141026_function_params_multiline.patch Description: Bina

[pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

Hello! A user may occasionaly assign content of a previously edited file into a next file opened in the same Query window, by calling Undo and Save. Simple non-MDI text editors (for example, notepad.exe) prevent an issue by clearing undo/redo history, so should we do. Please see the attached patc

[pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

Hello! This patch adds a few missing lines of code to handle smallserial columns the same way as serial and bigserial. -- Best regards, J.F. 141024_editgrid_serial.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to you

[pgadmin-hackers] PATCH: Fix Explain data output column not auto-sizing

Hello! There is a small bug with Explain data output. Steps to reproduce: 1. Open a new Query window. 2. Perform Explain of any query. Switch to "Data output" tab. Column was auto-sized, ok. 3. Execute the query. 4. Perform Explain again. Switch to "Data output" tab. Column wasn't auto-sized thi

[pgadmin-hackers] PATCH: Few changes regarding Windows build

Hi! Please consider pushing these changes: 1. Windows Installer XML v.3.7 gets installed into a different location than before, so an env.variable WIXDIR should be set up properly. 2. I've got an error when building Installer target: C:\pgbuild\pgadmin3\pkg\win32\src\i18ndata.wxs(5): error LG

[pgadmin-hackers] PATCH: new feature for Query tool: Favourites injection

Hello! When writing ad hoc queries or plpgsql code it is often handy to operate with small text snippets as the building blocks. PgAdmin has no Templates feature, but Favourites is very close to it. What is missing - the ability to quickly apply (inject) some snippet in the cursor position, prefer

Re: [pgadmin-hackers] pgAdmin III commit: Support the new check_option parameter of views

Hello Guillaume, I've noticed that views for which I had never specified check_option or security_barrier (in pgsql 9.3) have got incorrect DDL generated - the "WITH (options)" clause is empty: CREATE OR REPLACE VIEW account_v WITH () AS SELECT acc.id, ... Once I set security_barrier on and bac

[pgadmin-hackers] PATCH: More search in object's definitions

Hello! This patch adds search capabilities for: * Column's type names and default values * Everything in a view definition * Column names in composite types, tables and foreign tables I'm not sure how far should this feature be developed further. Is it enough to cover most typical needs? (with t

Re: [pgadmin-hackers] PATCH: save and restore the settings of the search objects dialog

Hello, On Sun, Jun 22, 2014 at 11:29 AM, Dmitriy Olshevskiy wrote: > Hello. > I think it'll be useful to save the settings of search objects dialog. So I > decided to add this feature. > Please see the attached patch. > Thank you. Reporting my user experience :) SaveSettings() is called on Cance

[pgadmin-hackers] Strip sRGB profile in PNG images

Hello! PgAdmin built with wxWidgets 3.0 under Windows gives following warning messagebox on startup (twice): 12:41:22: Warning: iCCP: known incorrect sRGB profile After that the application works normally. As discussed here https://bbs.archlinux.org/viewtopic.php?pid=1269845 warnings are trigger

Re: [pgadmin-hackers] pgAdmin III commit: Handle the 9.4 MOVE clause of ALTER TABLESPACE

Hello Guillaume, Some changes to pgAdmin3.vcxproj are missing. Please see the attached patch to fix it. Wednesday, July 2, 2014, 7:47:42 PM, you wrote: GL> Handle the 9.4 MOVE clause of ALTER TABLESPACE GL> Branch GL> -- GL> master GL> Details GL> --- GL> http://git.postgresql.org/git

[pgadmin-hackers] PATCH: wxLogInfo() in wxWidgets 3.0

Hello! I've noticed that pgAdmin built with wxWidgets 3.0 stopped logging INFO messages. wxLogInfo() became alias for wxLogVerbose() which is sensitive to the wxLog::ms_bVerbose flag. Attached patch fixes the issue. -- Best regards, J.F. 140629_logVerbose.patch Description: Binary data -- Se

Re: [pgadmin-hackers] wrong current schema in Search Objects dialog box

Hello, Monday, June 16, 2014, 11:58:28 AM, Dave Page wrote: DP> Do you have a few minutes to look at this please? Sure! DP> On Sun, Jun 15, 2014 at 7:30 PM, Dmitriy Olshevskiy wrote: >> I applied this patch >> http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commitdiff;h=010e38cdd4991feaf2

Re: [pgadmin-hackers] PATCH: Search Objects by definitions and comments

the top do DP> not have enough space to live in (on OSX at least - please see the DP> attached screenshot). Please give them some more wiggle room :-) Done, changed vgap from 3 to 5. Please see the attached patch. -- DP> On Sat, Jun 7, 2014 at 5:28 AM, J.F. Oster wrote: >> H

[pgadmin-hackers] PATCH: Search Objects by definitions and comments

Hello, Can someone review this patch, please? Monday, May 5, 2014, 6:22:15 PM, J.F. Oster wrote: JFO> Hello Ashesh, JFO> Have you had time to look into the patch? AV>> On Mon, Apr 7, 2014 at 10:47 PM, J.F. Oster wrote: AV>> Hello Ashesh, AV>> Friday, April 4, 201

Re: [pgadmin-hackers] Patch for closing frmEditGrid dialog using accelerator

Hello Fredrik, +1 for Ctrl-W. I've made the same change :) Didn't post it because of another patch in review queue. Saturday, June 7, 2014, 1:58:55 AM, Fredrik de Vibe wrote: FdV> I've been using pgadmin3 for some time, and while I really appreciate FdV> the tool, I've found it to be a *slight*

[pgadmin-hackers] PATCH: Precise control over query's modification state

Hello, Regarding this report: http://www.postgresql.org/message-id/c61c1de0-a5ed-4318-9391-7e35081c5...@empiric.al AZ>> 7. When I open a SQL console while an object/function/etc is AZ>> selected, the text inside is how to create it. That’s AZ>> (occasionally) helpful. However, if I close it witho

Re: [pgadmin-hackers] [pgadmin-support] Search feature request

Hello Ashesh, Have you had time to look into the patch? AV> On Mon, Apr 7, 2014 at 10:47 PM, J.F. Oster wrote: AV> Hello Ashesh, AV> Friday, April 4, 2014, 4:24:01 PM, Dave Page wrote: DP>> Ashesh, can you or one of the team help J. F. figure out the status DP>> bar

Re: [pgadmin-hackers] [pgadmin-support] Search feature request

StatusBar); to the constructor. That line exists in one of the parent's constructor for most dialogs. dlgSearchObject is of different inheritance hierarchy thus missing that bit of code. Also made few minor fixes. Please see the patch. DP> On Fri, Apr 4, 2014 at 12:33 PM, J.F. Oster wrote:

[pgadmin-hackers] PATCH: Save settings regardless of Find&Replace dialog's close method

Hello, Make "Find & Replace" dialog in SQL Box remember search settings when it is closed (in any way; in fact it's being hidden). Existing instances of dialog, once invoked again, will keep their own settings. New instance of dialog will gain settings of the last dialog which has been closed bef

Re: [pgadmin-hackers] PATCH: Enable backwards search in SQL Box

Hello, Thursday, March 13, 2014, 3:50:40 PM, Akshay Joshi wrote: DP>> Thanks. Akshay, can you take another look please? AJ> I have reviewed and tested the patch. Working fine and code looks good to me. Dave, will you apply it? >> By the way, I was puzzled why search dialog's settings are sav

Re: [pgadmin-hackers] [pgadmin-support] Search feature request

Thursday, March 6, 2014, 12:38:33 AM, Guillaume Lelarge wrote: GL> On Wed, 2014-03-05 at 07:40 -0600, Michael Shapiro wrote: >> I know that PgAdmin has the ability to find a pattern in various object >> names. >> >> Can PgAdmin search the actual text of procedures to find a pattern as well. >>

Re: [pgadmin-hackers] PATCH: Enable backwards search in SQL Box

for this is that the radio buttons give the most DP> obvious visual cue, so F3 (Find Next) should follow what they are DP> set to. DP> ═ DP> On Thu, Feb 20, 2014 at 5:09 PM, Ashesh Vashi DP> wrote: DP> Sure. DP> I will do that. DP> On Thu, Feb 20, 2014 at 4:52 PM,

[pgadmin-hackers] PATCH: Enable backwards search in SQL Box

Hello! Pressing F3 in query editor makes the previously started search continue forwards. This patch adds expected behavior for Shift-F3. There is a minor inconvenience when just changing the search direction - you have to press (Shift-)F3 *twice* for the (previous)next occurence to get highligh

[pgadmin-hackers] Ways to improve PgAdmin III SQL context help

Hello All! Currently when I press F1 in the SQL Query window, PgAdmin III looks for first token of selected (or whole) text, recognizes most of SQL commands and tries to open corresponding help page. I tried to extend that list with data types, functions, system catalogs&views etc: https://github

[pgadmin-hackers] PATCH: Enable deselecting in SQL Grid

Hello! When working with datasets, it is handy for a user to both select and deselect arbitary rows/columns by clicking labels with Control pressed. As I can see, wxGrid "out of box" doesn't deselect, that is annoying. This patch adds missing functionality. Also something should be done to suppor

[pgadmin-hackers] PATCH: Fix bug in inherited column definition

Hello! Please see attached screenshot and a patch to fix that. There are 6 system columns (tableoid,cmax,xmax,cmin,xmin,ctid) which are counted before inherited columns go. Steps to reproduce: 1. Connect to database 2. Create table parenttable (f1 integer, f2 integer,... and so on) 3. Create t

Re: [pgadmin-hackers] PATCH: Improve status bar in Edit Data window

Hello Dave, Thursday, January 2, 2014, 4:01:47 PM, Dave Page wrote: >> 1000 rows LIMIT >> 1000 rows LIMIT, FILTER >> 797 rows, FILTER >> Will that help distracted users? DP> I think adding a bright yellow warning exclamation would be a good DP> idea too. Something like: DP> /!\ Data filtered DP

[pgadmin-hackers] PATCH: Improve status bar in Edit Data window

Hello Dave! Monday, December 16, 2013, 7:39:52 PM, Dave Page wrote: >> I'd suggest adding a setting in Options dialogue, say "Default rows >> limit", defaulting itself to "No limit" to retain current behaviour. >> Please let me know if it is worth trying to implement this proposal. DP> Iirc, tha

[pgadmin-hackers] PATCH: Enable deselecting in SQL Grid

Hello All! When working with datasets, it is handy for a user to both select and deselect arbitary number of rows/columns by clicking labels with Control pressed. As I can see, wxGrid "out of box" doesn't deselect (for reasons I can't figure out), that is annoying sometimes. This patch fills the

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

Hello Dave, Wednesday, December 11, 2013, 4:20:26 PM, you wrote: DP> I took a look at this, and my only real concern is that the DP> auto-sizing code is forcing the grid to fully populate itself, which DP> it's currently specifically designed not to. The result of this is DP> that if you have a l

[pgadmin-hackers] PATCH: Save & restore last active panel in Options dialogue

Hello All, This little improvement saves some time for a user actively playing with program's options. Last chosen treeview item label (translated!) is saved among other settings and used on next dialogue invocation to find and select treeview item with same label. Сontrol over panels visibility

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

Hello Dinesh, Thursday, December 5, 2013, 1:38:10 PM, you wrote: DK> I have reviewed your patch and managed to traverse each line DK> of your code, except "AutoColumn" function body. Could you give me DK> some information, when the pgAdmin goes to this function call. You mean AutoSizeColumn()?

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

ion like below. Sure, done. Please see the fixed patch attached. DK>> Thursday, November 21, 2013, 12:03:04 PM, you wrote: DK>>> Hi, DK>>> On Wed, Nov 20, 2013 at 11:02 PM, J.F. Oster wrote: DK>>> Hello Dinesh, DK>>>> Do SELECT '1',

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

ader length. Ok, now in AutoSizeColumns() I save max column sizes to colMaxSizes array which will be used in AutoSizeColumn() and OnLabelDoubleClick() without looping through rows again. Please see the fixed patch attached. DK> Thursday, November 21, 2013, 12:03:04 PM, you wrote: DK>&

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

d->AutoSizeColumns() after, but didn't find the place where that resizing is done. Thursday, November 21, 2013, 12:03:04 PM, you wrote: DK> Hi, DK> On Wed, Nov 20, 2013 at 11:02 PM, J.F. Oster wrote: DK> Hello Dinesh, DK>> Do SELECT '1', 'f'; ==>>&g

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

DB for tutorials, webinars, whitepapers and more DK> On Wed, Nov 20, 2013 at 12:06 PM, Dinesh Kumar DK> wrote: DK> Thanks for fixing. DK> Let me look into this. DK> Dinesh DK> --  DK> Dinesh Kumar DK> Software Engineer DK> Ph: +918087463317 DK> Sky

Re: [pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

would suggest that a column should DK> never take up more than 50% of the visible space, unless that space DK> would otherwise be unused (e.g. you have 1 very narrow column, and one DK> large). DK> Thanks. DK> On Sun, Nov 17, 2013 at 6:41 PM, J.F. Oster wrote: >> Hi All,

[pgadmin-hackers] PATCH: Choose best width for Data Output columns of Query tool

Hi All, Please see the attached patch. It makes use of wxGrid's AutoSizeColumns() and applies some reasonable limits afterwards. Works nicely in most scenarios I could imagine. Tested with wxWidgets 2.8.12 on Ubuntu Linux. Possibly this code should be moved to some procedure and triggered from on