Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-30 Thread Jan Alexander Steffens
On Fri, Jan 27, 2017 at 5:56 PM Dave Page wrote: > On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens > wrote: > > I did mean Py_SetPath, not PySys_SetPath. > > Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so I assumed it > was a typo. > >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Jan Alexander Steffens
On Fri, Jan 27, 2017 at 12:04 PM Dave Page wrote: > On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens > wrote: > > Looking through the cpython code, Py_SetPath(NULL) clears the calculated > > module search path again. Try calling this before the Py_Initialize. > >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Jan Alexander Steffens
On Thu, Jan 26, 2017 at 3:58 PM Dave Page wrote: > In the meantime, I'm thinking something like the attached patch would > be more appropriate. The only issue I can find with it at the moment > (having just tested on a Mac dev environment for now) is that if > initialisation fails and you enter a

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Jan Alexander Steffens
mentioned installers would > be able to find their environments based purely on the executable > name. > Wouldn't the installed Python on Windows or OSX be caught be the PATH search Python does, too? Unfortunately I can't test either. From 14cd1000f23e5d450380efb51926132eba64f26e Mo

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Jan Alexander Steffens
On Wed, Jan 25, 2017 at 12:39 PM Dave Page wrote: > As far as I can see, this breaks usage in development environments, or > any configurations where the Python code may be separated from the > runtime. Am I missing something? > What kind of setup are you talking about? It's not clear to me. If

[pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Jan Alexander Steffens
self-explanatory. Thanks, Jan Steffens From 038e787a61c37f3eebd75cf6bbc8e441ad5b7f91 Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Fri, 6 Jan 2017 12:11:35 +0100 Subject: [PATCH] Simplify Server's python setup If the program name is set to match the venv'