Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

is my first ever contribution to this > project (or any project using C++ for that matter), I would prefer not to > take on such big changes right away. On the other hand, I would be more > then willing to collaborate with somebody on some of bigger changes, if > needed. > >

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-02 12:08 GMT+01:00 Dave Page : > On Tue, Feb 2, 2016 at 3:17 AM, Sergey Busel wrote: > > Patch file for multiple SQL tabs is attached. > > Thanks - I see how this could be useful. I think it needs a little > work before it could be included: > > - Unused code should be removed, not commen

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

Nice! This is something I wanted to work on myself but have not had the time to yet. -- john 2016-01-31 20:03 GMT+01:00 Sergey Busel : > Hello, > It's my first time here and I hope I am sending this to the right mailing > list. > > I am starting to use pgAdmin 3 more and more nowadays and though

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Thanks, appreciated. Can it be committed then? :) 2015-09-23 9:49 GMT+02:00 Sanket Mehta : > Hi John/Ashesh, > > I have reviewed the patch and it seems fine to me. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Wed, Sep 23, 201

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hi Sanket, Did you give the patch a try? I would really like it to for the next release :) -- john 2015-09-16 20:27 GMT+02:00 John Obaterspok : > Hi Sanket, > > Attached patch is rebased now. > > Regards, > > -- john > > > 2015-09-16 11:20 GMT+02:00 Sanket Mehta

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

;>> >>> Can you please take a look at it? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com> >>> >>&g

Re: [pgadmin-hackers] [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)

Hi, Was the patch to format execution time in a more readable manner okay? Never got any feedback from the updated version. Regards, John 2015-06-15 21:28 GMT+02:00 John Obaterspok : > Hi, > > Attached is an updated patch. > > -- john > > 2015-06-12 6:50 G

[pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

Hello, I'm updated the patch to add commit/rollback actions in the toolbar with the following: 1) updated icons (based on existing pgadmin icon with arrows drawn by me) 2) add entry to menu as well 3) disable icons when not in a transaction 4) Ctrl+Shift C|R shortcut Hopefully all issues are reso

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

t; Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, Jun 23, 2015 at 1:47 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jun 22, 2015 at 2:02 PM, John Obaterspok < >> john.obaters...@gmail.com> wrote: >> >>> Dave, >>> >>

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

attached with this mail. > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, Jun 16, 2015 at 12:59 PM, John Obaterspok < > john.obaters...@gmail.com> wrote: > >> Hello, >> >> I forgot to mention that yesterday I did a search fo

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

edb.com> wrote: > >> Hi Dave, >> >> Do you have any comments on the same? >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Wed, Jun 17, 2015 at 5:52 PM, John Obaterspok < >> john.obaters...@gm

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

prisedb.com> wrote: > >> Sure Dave. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, Jun 16, 2015 at 4:55 PM, Dave Page wrote: >> >>> Sanket, can you look at this please? >>> >>&g

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

will soon send a new patch for the same. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Jun 15, 2015 at 11:33 PM, John Obaterspok < > john.obaters...@gmail.com> wrote: > >> I'm using Visual Studio 2010 on Windows 7 x64. wx

[pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

Hello, With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this. -- john 0001-Add-Commit-Rollback-toolbar-action.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)

, please send patch as an attachment. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/ashesh

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

oop. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Sun, Jun 14, 2015 at 2:00 PM, John Obaterspok < >> john.obaters...@gmail.com> wrote: >> >>> Hello Sanket, >>> >>> Just enter &q

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

ri, Jun 12, 2015 at 11:50 AM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >> >> I am looking into the same and few other issues in code and will send the >> patch soon. >> >> >> Regards, >> Sanket Mehta >> Sr Software enginee

[pgadmin-hackers] [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)

Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec) Signed-off-by: John Obaterspok diff --git a/pgadmin/dlg/dlgClasses.cpp b/pgadmin/dlg/dlgClasses.cpp index 9a3e473..e6fa488 100644 --- a/pgadmin/dlg/dlgClasses.cpp +++ b

[pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

Fix crash when string has only alphas (like 'rollback') diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp index b5a2f56..110bbc7 100644 --- a/pgadmin/frm/frmQuery.cpp +++ b/pgadmin/frm/frmQuery.cpp @@ -2522,7 +2522,7 @@ bool frmQuery::isBeginNotRequired(wxString query) /* * Chec