[pgadmin-hackers] Invitation to a Community Developer Forum

2017-06-14 Thread Matthew Kleiman
Hi Hackers! As a community of open-source developers, it is valuable to have a space to come together and discuss technical topics about the project. We would like to invite everyone in the community to a public developer forum on Thursday, June 29 from 8-9am EDT (Meeting time in different timezon

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-02 Thread Matthew Kleiman
Hunk #43 FAILED at 1583. >> >>>> >> >> Hunk #44 FAILED at 1600. >> >>>> >> >> Hunk #45 FAILED at 1637. >> >>>> >> >> Hunk #46 FAILED at 1650. >> >>>> >> >> Hunk #47 FAILED at 1763. >> >>>> >> >> Hu

Re: [pgadmin-hackers] Process for Creating Translations

2017-06-02 Thread Matthew Kleiman
> > I periodically update the translation templates, and then put a shout > out to the translators. I try to minimise that though - I don't want > to be pinging them every other commit for obvious reasons. Thanks for the response, Dave. To clarify, we should continue to wrap English text in the g

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-02 Thread Matthew Kleiman
We are working on this now. Should I open a bug or a feature in redmine to track this work publicly or just keep it in our backlog only? On Thu, Jun 1, 2017 at 11:11 AM, Dave Page wrote: > > > On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman > wrote: > >> Hi Hackers!

[pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-01 Thread Matthew Kleiman
Hi Hackers! We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-31 Thread Matthew Kleiman
nge the history tab >> >> Do you want a single commit for each of the following? >> React (just adds the React library via yarn) >> Webpack (adds Webpack library via yarn and creates the >> webpack.config.js) >> ESLint (adds ESLint library via yarn, creates .e

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-30 Thread Matthew Kleiman
; >> server_types=ServerType.types() > >> File > >> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/ > psycopg2/__init__.py", > >> line 309, in connect > >> os.environ['PGAPPNAME'] = '{0} - {1}'.format(config.APP

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-24 Thread Matthew Kleiman
Hi Dave, This one is our bad! We didn't create a grunt task to run the tests only once, as you would in CI. grunt tests currently runs the tests and continues to watch for changes, running the tests again each time the source code is modified. We will create a task that is suitable to run in CI.

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-18 Thread Matthew Kleiman
Dave, Can you try running grunt tests on the command line? The tests task will run the eslint and karma grunt tasks, which should automatically webpack the React components before running the jasmine tests in karma. If it still fails, send us the output of that. Thanks, Matt On Thu, May 18, 20

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-17 Thread Matthew Kleiman
Hi Dave Have you confirmed that removing the changes we made to shorten the class > names used for rows and cells doesn't affect the performance or memory > utilisation of the grid? We haven't noticed any performance issues with this upgraded version of SlickGrid, nor our other changes to the qu

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-15 Thread Matthew Kleiman
Hey Merlin Yes, we are using the 6pac fork. We've found Ben (6pac) to be very responsive. He accepted two PRs we wrote to the SlickGrid in a very timely manner. Thanks, Matt On Mon, May 15, 2017 at 4:46 PM Merlin Moncure wrote: > On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira >

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-14 Thread Matthew Kleiman
Hi Akshay I really appreciate you taking a look at this on a Sunday! I am not able to get access to my work computer to run your changes directly. From what you are saying, though, it sounds like a reasonable change. If this change is passing in your environment, I say go ahead and make the change

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-28 Thread Matthew Kleiman
Hi Khushboo, That sounds good. Sorry if we weren't clear at first. Have a good holiday weekend! Sarah & Matt On Fri, Apr 28, 2017 at 4:35 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Sarah, > > On Thu, Apr 27, 2017 at 7:38 PM, Sarah McAlear > wrote: > >> Hi Kushboo! >> >

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-10 Thread Matthew Kleiman
you performing to trigger the behavior (is it the query tool or something else)? It would also help if you could attach a screenshot of the issue. Thanks, George & Matt On Mon, Apr 10, 2017 at 5:52 AM Dave Page wrote: > Hi Matt, > > On Fri, Apr 7, 2017 at 10:56 PM, Matthew Kleiman

Re: [pgadmin-hackers] [pgadmin4][patch] Remove (...) from links

2017-04-04 Thread Matthew Kleiman
Okay, feel free to disregard this patch. On Mon, Apr 3, 2017 at 11:17 AM, Dave Page wrote: > Hi > > On Mon, Apr 3, 2017 at 2:47 PM, Sarah McAlear wrote: > > Hi Hackers! > > > > A lot of the links in the app's dropdown menu had a trailing (...), which > > made it seem like there was truncated te

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-04-04 Thread Matthew Kleiman
Hi Surinder, We looked at your fix for default values in the query tool editor. We think the user experience could be further improved by seeing the actual default value instead of the empty cell. As an intermediate step, there would be user value in seeing "[default]" instead of the blank cell