Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Murtuza Zabuawala
Thanks Dave. Tested and working fine. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 1, 2017 at 7:20 PM, Dave Page wrote: > Hi > > On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala > wrote: > > Hi,

[pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

2017-02-01 Thread Murtuza Zabuawala
Hi, PFA minor patch to display value '0' in Read only text editor. RM#2138 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/slickgrid/slick.pgadmin.editors.js b/web/pgadmin/static/js

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-02-01 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch, issue was conn.release(did=did) was removing all connection for same database from connection manager. We have now created new connection for offline updates using "conn_id" parameter instead of did. Please review. -- Regards, Murtuza Zabuawala Enterpri

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Murtuza Zabuawala
Hi Dave, Please find minor patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 4:10 PM, Dave Page wrote: > On Tue, Jan 31, 2017 at 10:36 AM, Murtuza Zabuawala > wrote: > > Hi Dave,

Re: [pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-31 Thread Murtuza Zabuawala
Hi Dave, Even I tested against Python3.5 but did not receive any such error and I tried again after your mail but still did not receive error. murtuza@vm:~/pgadmin4/web/regression$ python3 --version Python 3.5.0 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The

Re: [pgadmin-hackers] Regarding Import and Export Issue

2017-01-31 Thread Murtuza Zabuawala
is the actual result on running the above steps i.e. the bug behavior. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 1:10 PM, wrote: > Hello > > I have issue for the for the tables data in the E

[pgadmin-hackers] [pgAdmin4][Patch] Minor fix in test file for the Template loader

2017-01-30 Thread Murtuza Zabuawala
nlocked File "", line 658, in exec_module File "", line 764, in get_code File "", line 724, in source_to_code File "", line 222, in _call_with_frames_removed File "/../../pgadmin4/web/pgadmin/utils/tests/test_versioned_template_loader.py&quo

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-01-30 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 30, 2017 at 8:07 PM, Dave Page wrote: > Can you rebase this please? > > Thanks. > > On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zab

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-29 Thread Murtuza Zabuawala
Hi Dave, I found one typo as given below and apart from that, code is working as expected with new template loader, - web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py:241: return 'ppas/*#{0#}*'.format(ver) -- Regards, Murtuza Zabuawala Enterpri

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

2017-01-29 Thread Murtuza Zabuawala
Hi, Please find a patch to fix the issue in timestamp & time type when user tries to provide scale/lengt to them. I did some refactoring in code to handle it at one place, affected nodes would be Type, Table & Column. *RM#2076* -- Regards, Murtuza Zabuawala Enterprise

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-29 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch, Tested against maintenance database as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jan 25, 2017 at 6:39 PM, Dave Page wrote: > Hi > > On Wed, Jan 25, 2017 at 12:21 PM

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-29 Thread Murtuza Zabuawala
Sure Dave, I will take a look. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 27, 2017 at 9:57 PM, Dave Page wrote: > Scrub that Khushboo - Murtuza, can you review on Monday please? I'm > being told Khushbo

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-25 Thread Murtuza Zabuawala
Hi Dave, Last patch had Python-3 fix for test suite, but now it is already committed. PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jan 25, 2017 at 5:18 PM, Dave Page wrote: > Can you rebase this please?

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-22 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 20, 2017 at 6:59 PM, Dave Page wrote: > FYI, I've reverted this patch for now, as I found it was causing other > problems.

[pgadmin-hackers] [Patch] Fix the Reset Statistic for a table pop up message

2017-01-22 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue of Reset Statistic for a table pop up message was not displaying properly. RM#2091 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2091.patch Description: Binary data -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-22 Thread Murtuza Zabuawala
I tested with Python-2.7 on Windows10 (32-bit) & on MacOS I tested with Python3.5 (64-bit), It is working as expected, I suspect that as you are running with Server 2012, permissions might be the issue, Can you try running with Administrator? -- Regards, Murtuza Zabuawala EnterpriseDB:

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Murtuza Zabuawala
That's strange. I tested in Chrome, Need check in IE. Meanwhile can try with Chrome/Firefox? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas wrote: > Hi Murtaza, > > I jus

Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-20 Thread Murtuza Zabuawala
Hi Fahar, Could you please test this updated patch? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas wrote: > Thanks Dave. > > On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote:

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-19 Thread Murtuza Zabuawala
Let me check -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 20, 2017 at 2:16 AM, George Gelashvili wrote: > Hi Dave and Murtuza, > > FYI - on our machines, running the DatabasesUpdateTestCase fails with an >

Re: [pgadmin-hackers] pgadmin4.1.1 ERROR,22021,"invalid byte sequence for encoding ""UTF8""

2017-01-18 Thread Murtuza Zabuawala
inition Tab > Check Encoding, Collation & Character type) ? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jan 18, 2017 at 9:15 PM, Bhanu Gandikota wrote: > Getting following error in PostgreSQL 9.6.1 DB logs whe

[pgadmin-hackers] PATCH: To fix the issue in Variable control (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where variable control was not displaying values properly in edit mode. This issue was due to wrong value set in model. RM#2067 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2067.patch Description

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
Hi Dave, I am not able to re-produce it, I reviewed reconnect to database logic and it is not affected by this patch, Would you please provide me exact steps? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 9, 2017 at 8:27 AM

[pgadmin-hackers] PATCH: To display column information properly in Properties Panel (pgAdmin4)

2017-01-13 Thread Murtuza Zabuawala
ol in Backform as well as in Backgrid. RM#2065 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2065.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscri

[pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)

2017-01-06 Thread Murtuza Zabuawala
stop alertify dialog from closing even with confirm prompt hence we have removed the button. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1364.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hacker

[pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2016-12-30 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in database node where it was not showing comments if database created with allow_connections=false. RM#2024 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2024_v1.patch Description

[pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2016-12-30 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where we were fetching wrong OID while generating node which was causing "index out of range". error when user try to access that exclusion constraint . RM#1896 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

[pgadmin-hackers] PATCH: Table dialogue column specification issues (pgAdmin4)

2016-12-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix one last pending issue from RM#1394, Now user can change the value of SwitchCell when they goto SwitchCell using Tab key press, earlier it was not working as expected when user presses Tab key and user come to Switchcell for user input. RM#1394 -- Regards, Murtuza Zabuawala

[pgadmin-hackers] PATCH: Table dialogue column specification issues (pgAdmin4)

2016-12-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix one last pending issue from RM#1394, Now user can change the value of SwitchCell when they goto SwitchCell using Tab key press, earlier it was not working as expected when user presses Tab key and user come to Switchcell for user input. RM#1394 -- Regards, Murtuza Zabuawala

[pgadmin-hackers] PATCH: To fix the issue in Notes control (pgAdmin4)

2016-12-21 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where Backform Notes control was not displaying & wrapping words properly when resize. This is a very minor css style change & there is no RM open for this. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Po

Re: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

2016-12-16 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch with suggested changes, I only thought of SqlFieldControl but yes we can use the same configuration everywhere. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Dec 16, 2016 at 6:38 PM

Re: [pgadmin-hackers] PATCH: To fix the issue of column order in Primary Key/Index constraints (pgAdmin4)

2016-12-16 Thread Murtuza Zabuawala
Hi Dave, Please find updates patch for the same. RM#1842 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Nov 25, 2016 at 3:37 PM, Dave Page wrote: > On Thu, Nov 24, 2016 at 9:57 AM, Murtuza Zabuawala > wrote:

[pgadmin-hackers] PATCH: To fix issue in database node (pgAdmin4)

2016-11-24 Thread Murtuza Zabuawala
Hi, PFA patch to display a flag if current database can be used as template while creating new database. RM#1800 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1800.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue of column order in Primary Key/Index constraints (pgAdmin4)

2016-11-24 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where column order in Primary Key/Index constraints was maintained while creating sql from template. RM#1842 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1842.patch Description: Binary data

[pgadmin-hackers] PATCH: To fix the issue grid columns alignment in Firefox (pgAdmin4)

2016-11-18 Thread Murtuza Zabuawala
Hi, PFA updated patch to fix the issue where SlickGrid was not rendering columns properly in Firefox browser. RM#1680 *Issue:* There was conflict in between Bootstrap's & SlickGrid's box sizing model calculation. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterp

[pgadmin-hackers] PATCH: To fix the issue in trigger node (pgAdmin4)

2016-11-18 Thread Murtuza Zabuawala
the same. *Issue:* Wrong parent id was given while creation of trigger & node() method was not implemented which was causing refresh error issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1747.patch Description: Binary data

[pgadmin-hackers] PATCH: To fix the issue where query tool was not displaying messages from function

2016-11-18 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where query tool was not displaying messages from functions. RM#1953 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1953.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix type casting for OID's (pgAdmin4)

2016-11-11 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where sql were failing to execute due to invalid type casting of OID. Total: 82 SQL templates affected by this patch, I have searched & tried to cover all the affected SQL from various nodes in this patch. Please review. RM#1951 -- Regards, Murtuza Zabua

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-11-11 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch, Both of the issues pointed by you in last email are addressed in this patch. Please review. RM#1227 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 21, 2016 at 5:57 PM, Neel Patel wrote: >

[pgadmin-hackers] PATCH: To fix the issue where trigger function was not schema qualified in trigger SQL (pgAdmin4)

2016-11-10 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where trigger function was not schema qualified in trigger SQL. RM#1949 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1949.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix the issue in Schema node (pgAdmin4)

2016-11-07 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user was not able to see generated SQL while creating/updating schema. RM#1937 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1937.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

2016-11-04 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in trigger node where it was not displaying arguments of Trigger function RM#1912 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1912.patch Description: Binary data -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in constraints node (pgAdmin4)

2016-10-31 Thread Murtuza Zabuawala
f this behaviour. I will send separate patch for displaying icon in grid meanwhile please review updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 28, 2016 at 9:04 PM, Dave Page wrote: > Hi > > On Fri, Oct

[pgadmin-hackers] PATCH: To fix the issue in domain node (pgAdmin4)

2016-10-28 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in domain node where we were not parsing the query output properly causing malformed sql. RM#1865 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1865.patch Description: Binary data

[pgadmin-hackers] PATCH: To fix the issue in unique constraints node (pgAdmin4)

2016-10-28 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in unique constraints node where refresh node functionality was broken. RM#1893 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1893.patch Description: Binary data -- Sent via pgadmin-hackers mailing

[pgadmin-hackers] PATCH: To fix the issue in constraints node (pgAdmin4)

2016-10-28 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in exclusion constrains where it was throwing error when user clicks on dependencies tab. RM#1892 I have found & also fixed the same issue in Index constrains in this patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterp

[pgadmin-hackers] PATCH: To fix quoting issue in the rolename (pgAdmin4)

2016-10-28 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where it was not quoting rolename properly in function node, I fixed the similar issues for trigger function node. RM#1899 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1899.patch

[pgadmin-hackers] PATCH: To raise an error if background job fails to start (pgAdmin4)

2016-10-21 Thread Murtuza Zabuawala
not able find any resolution meanwhile please review this issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1679.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make change

[pgadmin-hackers] PATCH: To display Security Label control properly in procedure node(pgAdmin4)

2016-10-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where behaviour of security label control was different when in CREATE mode & in EDIT mode. RM#1576 *issue:* Corrected the condition for node type checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-20 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch for the same. *Issue:* We were not properly fetching result from server in case of direct debugging when we restart debugging of same object. Thanks to Neel for helping in this issue. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Murtuza Zabuawala
Could you delete 'keys' table from pgadmin4.db file & try again? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Oct 20, 2016 at 11:26 AM, Fahar Abbas wrote: > Murtaza, > > I have applied this patch and

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue for Pyhton3. RM#1849 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Oct 20, 2016 at 11:03 AM, Fahar Abbas wrote: > Hi Dave, > > I have reopened fol

Re: [pgadmin-hackers] Setting up pgAdmin4 as a web application

2016-10-19 Thread Murtuza Zabuawala
You can refer my config for activating virtual environment. http://i.stack.imgur.com/8HbKw.png -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 19, 2016 at 8:19 PM, Dave Page wrote: > On Wed, Oct 19, 2016 at 3:43

[pgadmin-hackers] PATCH: To fix the issue in browser tree (pgAdmin4)

2016-10-18 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where node was appended to wrong parent if its desired parent is not loaded. RM#1838 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1838.patch Description: Binary data -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-07 Thread Murtuza Zabuawala
, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 7, 2016 at 4:16 PM, Dave Page wrote: > Hi > > It still seems buggy. I started debugging list_emp() from our sample > DB, and just hit Step Into a few times randomly. It got a

Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-06 Thread Murtuza Zabuawala
Hi Dave, The issue you mentioned is different issue and not related to synonyms node. I will create separate ticket & work on it mean while you can commit changes for RM#1611 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, O

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-06 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch with suggestion given. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 7:29 PM, Dave Page wrote: > OK, that's much better. I think I've figured out what's causi

Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch, Added schema filter in sql. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 5:38 PM, Dave Page wrote: > Hi > > On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch for the same. RM#1227 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Oct 3, 2016 at 6:05 PM, Dave Page wrote: > Hi > > On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala

[pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in synonym node, where it was not horning parent node while creating in different node, issue was that we were not sending node properly. RM#1611 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] PATCH: To fix the issue where pgAdmin4 was not honouring ssl mode options (pgAdmin4)

2016-10-04 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where pgAdmin4 was not honouring ssl mode options. RM#1817 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1817.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] column not found in pgSet: usercreatedb

2016-09-29 Thread Murtuza Zabuawala
Hello, What is the error? Could you provide more details please like version/platform/screenshot? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 29, 2016 at 4:35 PM, Aspitek Kenya Ltd wrote: > hi > Am getting this

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix mentioned issue as well as incremental msgs updates in Messages Tab. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 26, 2016 at 6:24 PM, Dave Page wrote: > On Mon, Sep 26, 2016 at 1

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix `` tag display. Please clear cache & try again with this updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zabuawala < murtuza

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
On Mon, Sep 26, 2016 at 5:08 PM, Dave Page wrote: > Hi > > On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue where it was not disabling buttons after > > execution gets finished. > > RM#1227 > >

[pgadmin-hackers] PATCH: To support new version of sqlparse (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi, PFA patch to address the issue where if user upgrades sqlparse module to >0.1.19, it breaks sqleditor auto-complete feature. RM#1725 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1725.patch Description: Binary data -- S

[pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-09-26 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where it was not disabling buttons after execution gets finished. RM#1227 *Issue:* If user clicks on buttons after execution is complete then it was throwing error, expected behaviour was all button should gets disabled except execute button. -- Regards, Murtuza

[pgadmin-hackers] PATCH: To fix the '/logout' redirects to '/' (pgAdmin4)

2016-09-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where '/logout' redirects to '/', which cause issue if pgAdmin4 is running in virtual root environment. RM#1691 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadm

[pgadmin-hackers] PATCH: Do not display 'CREATE Script' on Server-group & Server node (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where we were displaying 'CREATE Script' on Server-group & Server node. RM#1578 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1578.patch Description: Binary data -- Sent via p

Re: [pgadmin-hackers] PATCH: Adding support of Package in synonym (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
Yes, I can. Seems like it got broken after we have made changes for sorting nodes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 22, 2016 at 7:27 PM, Dave Page wrote: > Thanks - committed. I noticed while testing that

[pgadmin-hackers] PATCH: Adding support of Package in synonym (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
Hi, PFA patch to add support for creating synonym for Packages. RM#1611 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1611.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] PATCH: To fix the issue with stats table in PG9.6 (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 22, 2016 at 5:33 PM, Dave Page wrote: > Can you rebase this please? > > (pgadmin4)piranha:web dpage$ git apply ~/Downloads/RM_1719.patc

[pgadmin-hackers] PATCH: Patch to fix favicon in virtual root (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
Hi, PFA patch to add favicon in base template for proper reference. RM#1692 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1692.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue with stats table in PG9.6 (pgAdmin4)

2016-09-22 Thread Murtuza Zabuawala
, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index 0b6c6ca..24859e8 100644 --- a/web/pgadmin/browser/server_groups/servers/__init__.py

[pgadmin-hackers] PATCH: To fix JSON array handling (pgAdmin4)

2016-09-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where SlickGrid was not displaying nested JSON data properly. This patch fixes: RM#1713 & RM#1404 *Issue:* Nested JSON data was not handled properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Com

[pgadmin-hackers] PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

2016-09-20 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in debugger where we were not displaying result properly in result tab for composite types. RM#1662 @Neel, Would you please review the patch? *Issue:* Column name key was hardcoded in dict causing overwriting other columns. -- Regards, Murtuza Zabuawala

[pgadmin-hackers] PATCH: To fix the issue where user gets error following application server restart (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user gets error following application server restart. RM#1707 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1707.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix column editor issue (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
breaking while expanding subnode control. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1703_1704.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

[pgadmin-hackers] PATCH: To fix the issue in Packages node (pgAdmin4)

2016-09-19 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in Packages node where after updating any package user was getting 'Not Found' error. RM#1625 *Issue:* It was due to wrong parent was provided while sending the node to client. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprise

[pgadmin-hackers] PATCH: To fix the issue in various node for special character (pgAdmin4)

2016-09-16 Thread Murtuza Zabuawala
Hi, PFA minor patch which will fix the issue where user was not able to create objects if parent schema has special characters in it. RM#1598 *Issue:* We had escape special character in labels to prevent XSS Vulnerability in node browser tree which cause this issue. -- Regards, Murtuza

Re: [pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

2016-09-16 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Sep 16, 2016 at 3:31 PM, Dave Page wrote: > Can you rebase this please? > > Thanks. > > On Thu, Sep 15, 2

[pgadmin-hackers] PATCH: To fix the isssue where several default privileges cause error (pgAdmin4)

2016-09-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where several default privileges cause error on database. RM#1670 *Issue:* There were multiple rows returned by subquery that was the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1670.patch

[pgadmin-hackers] PATCH: To fix the performance of delete operation (pgAdmin4)

2016-09-15 Thread Murtuza Zabuawala
rows and then execute all 100 delete statements one by one due to which we were getting poor performance. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1696.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] PATCH: To fixed the issue where query tool attempts to "load arrow_right_spearmint.png" file (pgAdmin4)

2016-09-14 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where query tool attempts to "load arrow_right_spearmint.png" file. RM#1693 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1693.patch Description: Binary data -- Sent via pgadm

[pgadmin-hackers] PATCH: To fix condition checking (pgAdmin4)

2016-09-14 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix condition checking which was went into code with commit: 4ba8f4830bcdd8a9085b212 Thanks to Surinder for pointing out. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fixed_condition_checking.patch

[pgadmin-hackers] PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)

2016-09-14 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where executing a query disables the Save button in the query tool RM#1695 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1695.patch Description: Binary data -- Sent via

[pgadmin-hackers] PATCH: Do not sort columns based on their lables (pgAdmin4)

2016-09-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where we were sorting columns based on labels instead of their position. RM#1687 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js

[pgadmin-hackers] PATCH: To fix the issue of Table node (pgAdmin4)

2016-09-13 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where code breaks when user tries to view data on table which do not have any column(s). RM#1677 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web

[pgadmin-hackers] PATCH: To fix the issue in Rules node (pgAdmin4)

2016-09-13 Thread Murtuza Zabuawala
Hi, PFA minor patch for rules node where it was throwing when user tries to create new rule. RM#1681 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates

[pgadmin-hackers] PATCH: To fix the issue on Table collection node refresh (pgAdmin4)

2016-09-13 Thread Murtuza Zabuawala
displaying on console and not on GUI. @Ashesh, Would you please review this minor patch (File: misc_typo_fix.patch), I hope it does not affect anything else :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

[pgadmin-hackers] PATCH: To fix the issue where user cannot view long data in Query Tool output (pgAdmin4)

2016-09-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user was not able to view long data in the data grid. To fix the issue we have added Readonly editors in the grid to view data. RM#1672, RM#1668 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog

2016-09-11 Thread Murtuza Zabuawala
pgadmin4.git;a=commit;h=013ff1090e4b084166077a9e43196a91d7e17e24> -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 12, 2016 at 10:42 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Please find attached with following fi

[pgadmin-hackers] PATCH: To fix the issue of highlighting error in the query tool (pgAdmin4)

2016-09-09 Thread Murtuza Zabuawala
Hi, PFA patch for highlighting error in the query tool which was broken due to commit: d6391c7e9b26e5e10bb3 RM#1676 *Issue: * We removed timeout in poll function due to which we were not able fetch error properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at 7:30 PM, Dave Page wrote: > I think it's better to warn them as early as possible, as we do in >

[pgadmin-hackers] PATCH: wrong sql in function node (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi, PFA patch to fix an issue where function node displaying wrong SQL for a function returning a SETOF record, the display is wrong: it displays: RETURNS SETOF "SETOF record" instead of RETURNS SETOF record RM#1631 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprise

Re: [pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Sure I'll do it, But I thought like let user traverse through file manager (he may or may not select any file to load) and warn only if he/she try to load file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at

[pgadmin-hackers] PATCH: Adding more confirmations in query tool (pgAdmin4)

2016-09-07 Thread Murtuza Zabuawala
Hi, PFA patch to add more confirmations in query tool before taking any actions which might cause lose changes, - Clearing editor - Clearing history - Load file data RM#1666 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] PATCH: handling of range types (pgAdmin4)

2016-09-06 Thread Murtuza Zabuawala
Hi, PFA patch to add range type support in pgAdmin4. RM#1658 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1658.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Python2.6 compatibility fixes (pgAdmin4)

2016-09-06 Thread Murtuza Zabuawala
+++ Adding related RM. RM#1636 & RM#1659 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor

[pgadmin-hackers] PATCH: Python2.6 compatibility fixes (pgAdmin4)

2016-09-06 Thread Murtuza Zabuawala
Hi, PFA minor patch for Python2.6 compatibility with pgAdmin4. Please review. Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company python26_compatibility.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

[pgadmin-hackers] PATCH: Added user confirmation on panel close (pgAdmin4)

2016-09-05 Thread Murtuza Zabuawala
Hi, PFA patch to add user confirmation on panel close whenever user has any changes to save in grid or in sql text area. RM#1661 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor

<    1   2   3   4   5   >